From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.143.172.20 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794752669; b=2UZcGEdZH3kaQN28Y3dHkntC4UiIGCSP4wlo23o97trCenqyA/bRlBkSBlZ5TG0/ZMvN L8YKCR8Pz2rf7Hb7xtk5g69CChAId0ARIrodqqcBPC8uJzpJNJg70u3QEjyaVzfLr53/l E0nKtODQLWyBKIjpptTme+d6UHYA6oRjYq0ZMK3yUA5lI6wCRseE/VvkjUpuffYmOYemX oJViU32xkb0/7mW0hMK8k7fQjnzt8W1pmcPK8ankg140iXOOaKCI8CYvIjNCAatMeUEB6 NY4+Asxsvi5hFsVeBWiiPkF5DAUh39tzGxN6peTKmmQK9yyzE4dYuIob/Q/8YblIsRg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794752669; h=DMARC-Filter:Received:Received:Received:From:To:Cc:Subject:Date: Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding:X-Rspamd-Bar:X-Rspamd-Report:X-Rspamd-Score: DKIM-Signature; bh=vcanUONDfh4UpwdX4o7Q9IMWZ0FQX/y7PhEqP7yd0GI=; b=CkP9/wS7qSZXddYbnOj9scfjQ5N77loOTUYvxqUGmyWsvIamNJsrgMJZgKhRiabnX/u+ BP15e83VvwQK5opkhTXfFGudyNZlMk09OKdH27coh+I7RvMZjmrMk56tLThtozXuAG01o pE3sKlQMv0lGUHQFm0AOPNg1mZ/gZtUsbxtnMj7l1Q1CmDAjiaf/PGWEtTyL1kzryDhDm aqz2hFy1Z/jJ4Orko4CdorNUwKe5/GpPpkaqwN132iG5bHzdB182f3BPI3kmAi2RNf3yH +L3aog4sdheXE+8YX9DBN8uamG0H4gKf6hHLlP4zxyOBCiNLzqhfX3KkRShAW+yxpYQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=lausen.nl; spf=pass smtp.mailfrom=lausen.nl; dkim=pass header.d=lausen.nl header.i=@lausen.nl header.a=rsa-sha256 header.s=uberspace header.b=wc9by7I+; arc=none smtp.remote-ip=95.143.172.20 Received: from mailgate01.uberspace.is (mailgate01.uberspace.is [95.143.172.20]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1031C606A8A0 for ; Sun, 15 Nov 2026 14:24:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 1031C606A8A0 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lausen.nl Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lausen.nl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=lausen.nl header.i=@lausen.nl header.a=rsa-sha256 header.s=uberspace header.b=wc9by7I+ Received: from devico.uberspace.de (devico.uberspace.de [185.26.156.185]) by mailgate01.uberspace.is (Postfix) with ESMTPS id 6DBD960D6D for ; Sun, 15 Nov 2026 15:24:27 +0100 (CET) Received: (qmail 22121 invoked by uid 990); 15 Nov 2026 14:24:27 -0000 Authentication-Results: devico.uberspace.de; auth=pass (plain) Received: from unknown (HELO unknown) (::1) by devico.uberspace.de (Haraka/3.1.1) with ESMTPSA; Sun, 15 Nov 2026 15:24:27 +0100 From: Leonard Lausen To: Ping-Ke Shih Cc: leonard@lausen.nl, Shawn Lin , Heiko Stuebner , linux-wireless@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] wifi: rtw88: 8822c: filter hardware-handled control frames on SDIO Date: Sun, 15 Nov 2026 14:23:30 +0000 Message-ID: <20261115142330.359247-4-leonard@lausen.nl> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261115142330.359247-2-leonard@lausen.nl> References: <20261115142330.359247-2-leonard@lausen.nl> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Bar: ----- X-Rspamd-Report: REPLY(-4) BAYES_HAM(-2.999999) MID_CONTAINS_FROM(1) MIME_GOOD(-0.1) R_MISSING_CHARSET(0.5) X-Rspamd-Score: -5.599999 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=lausen.nl; s=uberspace; h=from:to:cc:subject:date; bh=0TRBf06mo4IgPwGwnvbNv30x92205M3V5CcT3zrUl3o=; b=wc9by7I+3JGBK/Oc6+bASwD97QqerUv6hamR6+se/F2occAtCIHswHSlIXEpapmfz9lsOW+rf2 GCZST68Pd0Q2D5sotV2l1bJ2N1HTJN4Sn/u6nxp1pPviQHAWl0baeDBNZJgFycwRRUDXo7IrH+gT wTH7UAvbjA9+sM6FbS8qnqjOgkJaUzzfvVwWDX6ag8cX6N/MfeVVeOC2OjGIuGh6ABIyljAw0lSu U1sd51T1Z+RcGQ5uLN1rslJoDsM8kWhe4OthejYNsJjIld7da36T2lhpw4qvJ4czLF2i583jFU5d ld7EQBDoXTGwBNraF1P0BwyONNkUbe9NqoxzWcWo6L48UOGQJCf5Ve4+CO5Si+yWF9Q1Kxw8Q4K/ Irhot6hs91bKGV5RpbFpLcvx1S2BO/SYM7S/IMXy5EhvJjZ1Vfh0cO01NXDxTXrtmOk1W09E6pVy YCidZt8iTwufehXAjUMkI+Qw2BU9EugERVFBwK0C8hcBxb0/VHrd/yQpntGWgR/XWHWu8CE96f8j W8sUlqW42/TnMumIbw3COZgOMbCPtggB65UdtrC/xcmG2jjTMlpm7R17O2fGsHj6cZNNIRX1Wo+d QDhVU/FeepyHz6jIIy3ZPzvdcGACHKCocMo/rYhIfzv90NDajnH7amjyfkuA0AmP5/B1SX1S1kY0 o= RTL8822C forwards every control-frame subtype to the host by default. ACK, Block Ack, RTS and CTS frames are handled by hardware, but forwarding them also adds small SDIO transfers to the data path. Clear these four subtypes from the SDIO default RX filter. Retain BAR, PS-Poll and the remaining subtypes, and store the default in rxfltmap1 so FIF_CONTROL can still request all control frames. Limit the new default to SDIO, where profiling identified the overhead and throughput tests measured a benefit. PCIe and USB use different receive paths and have not been validated with this filter setting. FriendlyElec's RTL8822CS driver also filters control frames at startup; this change retains additional subtypes for mac80211. On RTL8822CS/NanoPi M5 at 198 MHz SDR104, this patch alone increased median TCP upload from 170 to 258 Mbit/s (+52%). A separate download test (four 30-second samples per configuration) measured 241 to 263 Mbit/s (+9%). Link: https://github.com/friendlyarm/rtl8822cs/blob/c8b944a34bba2116fcdb060362bde40242bb87e5/hal/rtl8822c/rtl8822c_halinit.c --- drivers/net/wireless/realtek/rtw88/reg.h | 4 ++++ drivers/net/wireless/realtek/rtw88/rtw8822c.c | 9 +++++++++ 2 files changed, 13 insertions(+) diff --git a/drivers/net/wireless/realtek/rtw88/reg.h b/drivers/net/wireless/realtek/rtw88/reg.h index afcdb66fdb9a1..8e220580be4f8 100644 --- a/drivers/net/wireless/realtek/rtw88/reg.h +++ b/drivers/net/wireless/realtek/rtw88/reg.h @@ -587,6 +587,10 @@ #define REG_RXFLTMAP0 0x06A0 #define REG_RXFLTMAP1 0x06A2 +#define BIT_RXFLTMAP1_BACK BIT(9) +#define BIT_RXFLTMAP1_RTS BIT(11) +#define BIT_RXFLTMAP1_CTS BIT(12) +#define BIT_RXFLTMAP1_ACK BIT(13) #define REG_RXFLTMAP2 0x06A4 #define REG_RXFLTMAP4 0x068A #define REG_BT_COEX_TABLE0 0x06C0 diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822c.c b/drivers/net/wireless/realtek/rtw88/rtw8822c.c index 32d9709f2c243..9c9e4f2397282 100644 --- a/drivers/net/wireless/realtek/rtw88/rtw8822c.c +++ b/drivers/net/wireless/realtek/rtw88/rtw8822c.c @@ -2096,6 +2096,15 @@ static int rtw8822c_mac_init(struct rtw_dev *rtwdev) rtw_write8(rtwdev, REG_WMAC_TRXPTCL_CTL_H + 2, WLAN_BAR_ACK_TYPE); rtw_write16(rtwdev, REG_RXFLTMAP0, WLAN_RX_FILTER0); rtwdev->hal.rxfltmap1 = WLAN_RX_FILTER1; + if (rtw_hci_type(rtwdev) == RTW_HCI_TYPE_SDIO) { + /* Hardware handles these frames; retain BAR and PS-Poll for + * mac80211. FIF_CONTROL restores all subtypes for monitors. + */ + rtwdev->hal.rxfltmap1 &= ~(BIT_RXFLTMAP1_BACK | + BIT_RXFLTMAP1_RTS | + BIT_RXFLTMAP1_CTS | + BIT_RXFLTMAP1_ACK); + } rtw_write16(rtwdev, REG_RXFLTMAP1, rtwdev->hal.rxfltmap1); rtw_write16(rtwdev, REG_RXFLTMAP2, WLAN_RX_FILTER2); rtw_write32(rtwdev, REG_RCR, WLAN_RCR_CFG);