From: David Laight <david.laight.linux@gmail.com>
To: Thorsten Blum <blum@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
Breno Leitao <leitao@debian.org>,
Christian Brauner <brauner@kernel.org>,
Sang-Heon Jeon <ekffu200098@gmail.com>,
Wilson Felipe Pereira <wfelipe@google.com>,
Ryan Roberts <ryan.roberts@arm.com>,
"Mike Rapoport (Microsoft)" <rppt@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] init: Use strscpy() in do_initcalls()
Date: Sun, 15 Nov 2026 15:00:52 +0000 [thread overview]
Message-ID: <20261115150052.6189a1a1@pumpkin> (raw)
In-Reply-To: <20261114115230.30345-3-blum@kernel.org>
On Sat, 14 Nov 2026 12:52:29 +0100
Thorsten Blum <blum@kernel.org> wrote:
> Replace the deprecated strcpy() [1] with strscpy() to bound the copy to
> the allocated buffer size.
>
> Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy [1]
> Signed-off-by: Thorsten Blum <blum@kernel.org>
> ---
> init/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/init/main.c b/init/main.c
> index db8fb6ebe830..93a2b12976f0 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -1481,7 +1481,7 @@ static void __init do_initcalls(void)
>
> for (level = 0; level < ARRAY_SIZE(initcall_levels) - 1; level++) {
> /* Parser modifies command_line, restore it each time */
> - strcpy(command_line, saved_command_line);
> + strscpy(command_line, saved_command_line, len);
That could be a memcpy().
David
> do_initcall_level(level, command_line);
> }
>
>
prev parent reply other threads:[~2026-11-15 15:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 11:52 Thorsten Blum
2026-11-14 11:52 ` [PATCH 2/2] init: Use kmalloc() " Thorsten Blum
2026-11-15 15:00 ` David Laight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261115150052.6189a1a1@pumpkin \
--to=david.laight.linux@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=blum@kernel.org \
--cc=brauner@kernel.org \
--cc=ekffu200098@gmail.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=wfelipe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®