From: Firas Sharary <firassharary3@gmail.com>
To: Antoine Pichot <antoine.pichot@gmail.com>
Cc: linux-media@vger.kernel.org, sakari.ailus@linux.intel.com,
mchehab@kernel.org, hansg@kernel.org,
andriy.shevchenko@linux.intel.com, dan.scally@ideasonboard.com,
djrscally@gmail.com, dmanresa@gmail.com,
dave.stevenson@raspberrypi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/9] media: i2c: ov7251: fixes and infrared strobe for Surface Book 2
Date: Sun, 15 Nov 2026 19:53:01 +0200 [thread overview]
Message-ID: <20261115175301.8516-1-firassharary3@gmail.com> (raw)
In-Reply-To: <20261113024059.1087031-1-antoine.pichot@gmail.com>
Hi Antoine,
I tested this series on a Microsoft Surface Pro 7+ (IPU6 Tiger Lake,
8086:9a19, sensor INT347E, SKU Surface_Pro_7+_1960).
Setup: all nine patches on top of linux-surface 7.3.4. Patches 1 to 4
applied as they are. For 5 to 9 the only change was the pad operation
signature, since v7.3 does not pass the client info argument yet. The
tree also has "platform/x86: int3472: map the ov7251 power enable GPIO
to "vdda"", without which the sensor does not probe on this machine,
and linux-surface's V4L2_CID_ANALOGUE_GAIN rename.
Results:
- The sensor probes and streams 640x480 Y10 at 30 fps on the 319.2 MHz
link.
- Raw capture from the ISYS node, ten start/stop cycles of 15 to 20
frames: every frame arrived, none was pinned at full scale, and the
receiver logged no CSI-2 error in those runs. I had not run the old
PLL setting on this machine, so I cannot compare patch 1 with the
behaviour before it.
- With V4L2_CID_FLASH_STROBE_OE off, every frame sits at the black level
(mean 16 to 17 of 1023). With it on, frames alternate between that and
a lit frame (mean roughly 240 to 340 at the default exposure of 504
and gain 16, with a face about half a metre away). The emitter is off
whenever the sensor is not streaming.
- Patch 9: the rotation control reads 90, and the frames are upright
after turning them 90 degrees counter-clockwise.
Face authentication with Howdy works on the lit frames.
Tested-by: Firas Sharary <firassharary3@gmail.com> # Surface Pro 7+
Thanks,
Firas
next prev parent reply other threads:[~2026-11-15 17:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 2:40 Antoine Pichot
2026-11-13 2:40 ` [PATCH v3 1/9] media: i2c: ov7251: Use in-range PLL1 dividers for the 319.2 MHz link Antoine Pichot
2026-11-13 2:40 ` [PATCH v3 2/9] media: i2c: ov7251: Fix link frequency index Antoine Pichot
2026-11-13 2:40 ` [PATCH v3 3/9] media: i2c: ov7251: Report the pixel array rate for both link frequencies Antoine Pichot
2026-11-13 2:40 ` [PATCH v3 4/9] media: i2c: ov7251: Reset vblank when the frame interval changes Antoine Pichot
2026-11-13 2:40 ` [PATCH v3 5/9] media: i2c: ov7251: Use sub-device active state Antoine Pichot
2026-11-13 2:40 ` [PATCH v3 6/9] media: i2c: ov7251: Add orientation and rotation controls Antoine Pichot
2026-11-13 2:40 ` [PATCH v3 7/9] media: i2c: ov7251: Move the common registers into the global init table Antoine Pichot
2026-11-13 2:40 ` [PATCH v3 8/9] media: i2c: ov7251: Add strobe output enable control Antoine Pichot
2026-11-13 2:40 ` [PATCH v3 9/9] media: ipu-bridge: Add a rotation quirk for the Surface Book 2 and Pro 7+ Antoine Pichot
2026-11-15 17:53 ` Firas Sharary [this message]
2026-11-15 22:18 ` [PATCH v3 0/9] media: i2c: ov7251: fixes and infrared strobe for Surface Book 2 Antoine Pichot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261115175301.8516-1-firassharary3@gmail.com \
--to=firassharary3@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=antoine.pichot@gmail.com \
--cc=dan.scally@ideasonboard.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=djrscally@gmail.com \
--cc=dmanresa@gmail.com \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®