From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.52 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794765864; b=qTWE1apBqUPN0zuHV40Bf79/e47RtwKaAYUwbv5CgE/O0TCy06CqPNIOZTQFIc/rc5+o 6P+AhM1dL25gBgz/lk5nNPaxRkfeKWu0DrER3+iO3Uk2UWmx9L6bA6gtHqZmIe3sZHl8a Xi1vUnQ64BpOJvXJDP3iAzwvmtAyjj1gywVjZYp0D2dPu68S53ldtJJcZbNoG5+7KryZL w0gsZ3mjqro4AIZrd/5ewHau/g4adAgXPxKjhkcioyBA0ubO3O4+AQQzWbX9Wg0ypd3Zs b8gls5q5qMT70lxZCcr3rkgd0XRIAPGcrGdEA6gJ0oQCRlr5CxWXpR6+8IrnszgnL7w== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794765864; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=lxukKPljbLBMj2KQ1RVi2fh6LR+mPswpZnw+yWTHXAg=; b=0bZOWY6jYs9AaJ3lQGWg5x+lA7ClWb1JS5yFHd9wPEDHi2jbbuNt9xzHAODwoOlU1kK3 y17Gvvt2Dt/0nQQa21G6A/HkbjpY5KQh2fRWNYlaX1CEp0eP27InJEA0SoqoT2Vl0A9Br 4/bE6u/qxsMIgCzkRlszW2Mpq4bAtxpLHv/KYCKS6j1bgUVrFZTuNixktWKV9AdnZQXwd gOSDCjmCsLAMY81zLUqWbDDZhx8VSYq0sM065imCpAosjZANpzi8j36kzDrrK73lYPsEk roDto2AKRuRAxPVrTWxyN66el7qe0JT8iaUPXviMqUOjcDNAfu92Qnb8sgX01KkSNeQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=DOC6fRFx; arc=none smtp.remote-ip=209.85.128.52 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B6C3606BAF3 for ; Sun, 15 Nov 2026 18:04:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 2B6C3606BAF3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=DOC6fRFx Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4bb61185057so8492965e9.1 for ; Sun, 15 Nov 2026 10:04:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794765861; x=1795370661; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=lxukKPljbLBMj2KQ1RVi2fh6LR+mPswpZnw+yWTHXAg=; b=DOC6fRFxtVO3+ChQZzvIui929ReJBuZRd50VNbS4+FpLPzHiYUk0WUdqprK6YJ0H9P stgxUdPJV/firlryJZiPgcjbYfkVubXUmYUllYeWbRbQj0/cU5mkXT5om3kdyMQmazN9 rSzbjQkUbitjYgmgKsWufTocTnMfvmkDAI3Oxgjdc/MAagWI/qQz5Ra6UjVwmcaHZeVm RH2isjXoghK2pAMewo3C0p+jKCU0hHuAnA5pmR6eYCj9i2rADSzBqE9st7UzJZGd+ArT tNWRMhr+eF01OpI7T/wIq6nvVSPeZcy8RRet4KfN8DcM1geWKJD9t7OMvDUoWoupSPqc /XLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794765861; x=1795370661; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=lxukKPljbLBMj2KQ1RVi2fh6LR+mPswpZnw+yWTHXAg=; b=J9kVz7tqAY70sF4xYyLykAI1l1KKHATt+gr0kAGQFlE6gsIzm/CovUxCWAzFD8smAO IPY1xXt2U8bhruNtUKZMrxcPl2weN1kaJwO7XHmsOudbT5FJ/IMxLlY4LoFyrN2u28M9 ArQSZaTjxtAvMwbTILXjysntjzQwd7htELQWokOLKEG8m5jaugAyfh3pPPasUYbrW8p3 8U2nfh9pQ68LPZXb3PB4kpsfDY7cnmCA1h9kXk/7gH/AzNxopJjGnmoFpSrxpnq0z8pm FacLDoXcaSe+kcLhRcYp31te/WWi5YsgjNwZ0Wm5UALuHRQdJ7BpbzhpHw3+oi7SPD0V iSyQ== X-Forwarded-Encrypted: i=1; AL+hErGMFTUpIvjA/nLxPJ4D8HKLh0bJtHgJZVRNGBHsuVhMBPXbfgWpmYZYuGcHaWDVuYaZ5JTSOp251fNrLRI=@vger.kernel.org X-Gm-Message-State: APuU4Z+1F0scbl3/F1k5yOTYnpt4TrYS1ybVXmZJkwZDiHnoUyBhcn/L lfChLyeiu9M3GLsFDMGX/Qp4E3HpEp6vXajkgojwW+GnJJ1P/EXVy5WW X-Gm-Gg: AYBFou2sKFOUZEVFaVAaNaNpyoZRhlSxtQGc1xeLpEezsPvZ+5yMJEicNlqKcMw85XC TrKXVeeRQdrceEt//jhXsE6dSukE03Ja9bIiqwkHQ+RURCYY39ThO7thXFnjJPsq5S5EuFCQ9q4 v4DSpTdhZ609rBjmwKzT2J2K05ydIG35z+fXLxeIkvw+VbSaEtaC1lbMXdxc5Ocy84y/wsLtgFf LV6J7sCZ5KvXf20qhRi9qb8PSw4JEXn8Kx5EQIp3r+v6M8hA7fR3PX3OX1F+8GpqUv3YKFcarbh 1uYjvFH1QgQ27WRXorPjIY0f9f53wrVcsRgwuMMm1KTmA1FrN5tuNs88oj2MyyPqzwg2r3iGds/ G6nUO8uSuRYzNTN5RD03gUL6wourKx2zd8gk2DadGyjV15XbYM69qrNzNji2OWP6MTquqzCC3dv KLRTtHPJmnEc0d4nw/XJr6oQuw2hKERiUuVP9qsnZ4gREonHwMuHehJvXAfkHkVs7FqzccwCKK1 fivepgofr6UGpRY6e2Kn43VAe2kvVqoTRZekHSm8yLYDKvxnIzdP62ReyhbyZP6KMwDlrR8LPxa Mrn59K5DpHqX9wtkbdiipgFnqeHec2W5qkke6OkmatooQQ== X-Received: by 2002:a05:6000:461b:b0:48d:f7c0:97c0 with SMTP id ffacd0b85a97d-49c71b5c656mr18500790f8f.50.1794765861443; Sun, 15 Nov 2026 10:04:21 -0800 (PST) Received: from infinity ([2001:b07:5d26:7a6a:365a:60ff:fe0d:cfc6]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-49c60f8c248sm17980448f8f.58.2026.11.15.10.04.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Nov 2026 10:04:20 -0800 (PST) From: koraynilay To: David Sterba , Namjae Jeon , Sungjong Seo , Alexander Viro , Christian Brauner , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , Konstantin Komarov , Paulo Alcantara Cc: Chris Mason , Yuezhang Mo , Jan Kara , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Ronnie Sahlberg , Shyam Prasad N , Bharath SM , Sergey Senozhatsky , ChenXiaoSong , "Darrick J . Wong" , Sean Smith , Andrey Albershteyn , Pedro Falcato , Amir Goldstein , =?UTF-8?q?Pali=20Roh=C3=A1r?= , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, exfat@lists.linux.dev, ntfs3@lists.linux.dev, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-api@vger.kernel.org, koraynilay Subject: [RFC PATCH v4 10/10] cifs: add provenance time (ptime) and map it to SMB's CreationTime Date: Sun, 15 Nov 2026 19:03:43 +0100 Message-ID: <20261115180343.576773-11-koray.fra@gmail.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261115180343.576773-1-koray.fra@gmail.com> References: <20261115180343.576773-1-koray.fra@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Implement provenance time (ptime) in cifs, as introduced in a previous commit ("vfs: add provenance time (ptime)"). Map it to SMB's CreationTime, making it settable from userspace and propagating it to the SMB server via FILE_BASIC_INFO. Support reading ptime via statx(2) and fileattr_get() from the cached CreationTime. Update cifs_fileattr_set() to check xflags instead of only legacy flags and add the cifs_set_file_crtime() helper to wrap the RPC call to the SMB server. Assisted-by: Gemini:3.8-flash-high antigravity-cli-1.5.7 Signed-off-by: koraynilay --- fs/smb/client/cifsfs.c | 8 +++ fs/smb/client/inode.c | 7 ++- fs/smb/client/ioctl.c | 109 ++++++++++++++++++++++++++++++----------- 3 files changed, 94 insertions(+), 30 deletions(-) diff --git a/fs/smb/client/cifsfs.c b/fs/smb/client/cifsfs.c index 8cff7857b450..c2f557e406d3 100644 --- a/fs/smb/client/cifsfs.c +++ b/fs/smb/client/cifsfs.c @@ -1307,6 +1307,14 @@ int cifs_fileattr_get(struct dentry *dentry, struct file_kattr *fa) if (READ_ONCE(CIFS_I(inode)->cifsAttrs) & ATTR_COMPRESSED) fa->flags |= FS_COMPR_FL; + /* Report provenance time (ptime) to userspace */ + if (CIFS_I(inode)->createtime) { + fa->fsx_xflags |= FS_XFLAG_PTIME; + fa->fsx_xflags_mask |= FS_XFLAG_PTIME; + fa->fsx_ptime = + cifs_NTtimeToUnix(cpu_to_le64(CIFS_I(inode)->createtime)); + } + /* * FS_CASEFOLD_FL is defined by UAPI as a folder attribute, * and userspace tools (e.g., lsattr) display it only on diff --git a/fs/smb/client/inode.c b/fs/smb/client/inode.c index 2647785ec1e4..f0b20a72b9c2 100644 --- a/fs/smb/client/inode.c +++ b/fs/smb/client/inode.c @@ -222,6 +222,7 @@ cifs_fattr_to_inode(struct inode *inode, struct cifs_fattr *fattr, cifs_i->cifsAttrs = fattr->cf_cifsattrs; cifs_i->reparse_tag = fattr->cf_cifstag; + cifs_i->createtime = fattr->cf_createtime; if (fattr->cf_flags & CIFS_FATTR_NEED_REVAL) cifs_i->time = 0; @@ -2958,7 +2959,8 @@ int cifs_getattr(const struct mnt_idmap *idmap, const struct path *path, * We need to be sure that all dirty pages are written and the server * has actual ctime, mtime and file length. */ - if ((request_mask & (STATX_CTIME | STATX_MTIME | STATX_SIZE | STATX_BLOCKS)) && + if ((request_mask & (STATX_CTIME | STATX_MTIME | STATX_PTIME + | STATX_SIZE | STATX_BLOCKS)) && !CIFS_CACHE_READ(CIFS_I(inode)) && inode->i_mapping && inode->i_mapping->nrpages != 0) { rc = filemap_fdatawait(inode->i_mapping); @@ -2992,6 +2994,9 @@ int cifs_getattr(const struct mnt_idmap *idmap, const struct path *path, stat->result_mask |= STATX_BTIME; stat->btime = cifs_NTtimeToUnix(cpu_to_le64(CIFS_I(inode)->createtime)); + stat->result_mask |= STATX_PTIME; + stat->ptime = + cifs_NTtimeToUnix(cpu_to_le64(CIFS_I(inode)->createtime)); } stat->attributes_mask |= (STATX_ATTR_COMPRESSED | STATX_ATTR_ENCRYPTED); diff --git a/fs/smb/client/ioctl.c b/fs/smb/client/ioctl.c index bb8808289a46..19a9556d39b4 100644 --- a/fs/smb/client/ioctl.c +++ b/fs/smb/client/ioctl.c @@ -181,6 +181,41 @@ static int cifs_set_compression(unsigned int xid, struct dentry *dentry, compression_state); } +static int cifs_set_file_crtime(unsigned int xid, struct dentry *dentry, + struct cifs_tcon *tcon, u64 crtime) +{ + struct inode *inode = d_inode(dentry); + struct TCP_Server_Info *server = tcon->ses->server; + FILE_BASIC_INFO info_buf = {}; + const char *full_path; + void *page; + int rc; + + if (!server->ops->set_file_info) + return -EOPNOTSUPP; + + info_buf.CreationTime = cpu_to_le64(crtime); + + page = alloc_dentry_path(); + full_path = build_path_from_dentry(dentry, page); + if (IS_ERR(full_path)) { + rc = PTR_ERR(full_path); + goto out; + } + + rc = server->ops->set_file_info(inode, full_path, &info_buf, xid); + if (rc == 0) { + CIFS_I(inode)->createtime = crtime; + CIFS_I(inode)->time = 0; + inode_set_ctime_current(inode); + } + +out: + free_dentry_path(page); + return rc; +} + +#define CIFS_SUPPORTED_XFLAGS (FS_XFLAG_PTIME) int cifs_fileattr_set(const struct mnt_idmap *idmap, struct dentry *dentry, struct file_kattr *fa) { @@ -193,49 +228,65 @@ int cifs_fileattr_set(const struct mnt_idmap *idmap, struct dentry *dentry, bool enable_compression; struct cifs_tcon *tcon; unsigned int xid; - int rc; + int rc = 0; - if (!fa->flags_valid) + if (fileattr_has_fsx_mask(fa, CIFS_SUPPORTED_XFLAGS)) return -EOPNOTSUPP; - /* - * chattr writes back all flags returned by fileattr_get(). Accept - * FS_CASEFOLD_FL only when it reflects the share's casefold state. - */ - if (fa->flags & FS_CASEFOLD_FL) { - rc = cifs_fileattr_get(dentry, ¤t_fa); - if (rc) - return rc; - if (current_fa.flags & FS_CASEFOLD_FL) - allowed |= FS_CASEFOLD_FL; - } - if (fa->flags & ~allowed) + if (fa->fsx_xflags_mask & ~CIFS_SUPPORTED_XFLAGS) return -EOPNOTSUPP; - enable_compression = fa->flags & FS_COMPR_FL; - compression_state = enable_compression ? COMPRESSION_FORMAT_DEFAULT : - COMPRESSION_FORMAT_NONE; + if (fa->flags_valid) { + /* + * chattr writes back all flags returned by fileattr_get(). Accept + * FS_CASEFOLD_FL only when it reflects the share's casefold state. + */ + if (fa->flags & FS_CASEFOLD_FL) { + rc = cifs_fileattr_get(dentry, ¤t_fa); + if (rc) + return rc; + if (current_fa.flags & FS_CASEFOLD_FL) + allowed |= FS_CASEFOLD_FL; + } + if (fa->flags & ~allowed) + return -EOPNOTSUPP; + } tlink = cifs_sb_tlink(cifs_sb); if (IS_ERR(tlink)) return PTR_ERR(tlink); tcon = tlink_tcon(tlink); - xid = get_xid(); - rc = cifs_set_compression(xid, dentry, tcon, NULL, compression_state); - free_xid(xid); - cifs_put_tlink(tlink); - if (!rc) { - spin_lock(&inode->i_lock); - if (enable_compression) - CIFS_I(inode)->cifsAttrs |= FILE_ATTRIBUTE_COMPRESSED; - else - CIFS_I(inode)->cifsAttrs &= ~FILE_ATTRIBUTE_COMPRESSED; - spin_unlock(&inode->i_lock); + /* modern xflags */ + if (fa->fsx_valid) { + if (fa->fsx_xflags_mask & FS_XFLAG_PTIME) { + rc = cifs_set_file_crtime(xid, dentry, tcon, + cifs_UnixTimeToNT(fa->fsx_ptime)); + if (rc) + goto out; + } + } else if (fa->flags_valid) { /* legacy flags */ + enable_compression = fa->flags & FS_COMPR_FL; + compression_state = enable_compression ? COMPRESSION_FORMAT_DEFAULT : + COMPRESSION_FORMAT_NONE; + + rc = cifs_set_compression(xid, dentry, tcon, NULL, compression_state); + + if (!rc) { + spin_lock(&inode->i_lock); + if (enable_compression) + CIFS_I(inode)->cifsAttrs |= FILE_ATTRIBUTE_COMPRESSED; + else + CIFS_I(inode)->cifsAttrs &= ~FILE_ATTRIBUTE_COMPRESSED; + spin_unlock(&inode->i_lock); + } + cifs_dbg(FYI, "set compress flag rc %d\n", rc); } - cifs_dbg(FYI, "set compress flag rc %d\n", rc); +out: + free_xid(xid); + cifs_put_tlink(tlink); return rc; } -- 2.56.0