mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "Barry Song (Xiaomi)" <baohua@kernel.org>
Cc: ryncsn@gmail.com, axelrasmussen@google.com,
	baolin.wang@linux.alibaba.com, baoquan.he@linux.dev,
	hannes@cmpxchg.org, hui.zhu@linux.dev, kunwu.chan@gmail.com,
	liam@infradead.org, lianux.mm@gmail.com,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	liuxiang.277@bytedance.com, lyugaofei@xiaomi.com,
	mhocko@kernel.org, mhocko@suse.com, qi.zheng@linux.dev,
	ridong.chen@linux.dev, rppt@kernel.org, shakeel.butt@linux.dev,
	sidchintamaneni@gmail.com, surenb@google.com,
	wangzicheng@honor.com, weixugc@google.com, yuanchu@google.com,
	zhangbo56@xiaomi.com, zhuhui@kylinos.cn
Subject: Re: [PATCH v9 10/16] mm/mglru: Run aging when pages are rare outside the youngest gen
Date: Sun, 15 Nov 2026 20:50:46 -0800	[thread overview]
Message-ID: <20261115205046.8473acf5a93d69d460598559@linux-foundation.org> (raw)
In-Reply-To: <20261116042556.42111-1-baohua@kernel.org>

On Mon, 16 Nov 2026 12:25:56 +0800 "Barry Song (Xiaomi)" <baohua@kernel.org> wrote:

> On Sun, Nov 15, 2026 at 11:55 PM Kairui Song <ryncsn@gmail.com> wrote:
> [...]
> >
> > A little nit: with the rounding above, I think we don't need youngest
> > / old as an array, just an accumulative value seems enough now? But
> > feel free to ignore this so we can avoid more update noise in this
> > series.
> 
> Makes sense to me!
> 
> I guess Andrew could help squash the cleanup below into the patch?

yep.

> As suggested by Kairui[1], we don't need youngest and old as
> array. just an accumulative value should be enough.
> 
> No functional change.

It got a bit messy because the later "mm/mglru: restrict eviction
accounting to eligible zones" alters this code also, but I think I
figured it out.  And I might have accidentally fixed an 80-col thing
while in there ;)

Here's the end-of-series result - please check.  It compiles!


static bool lru_gen_imbalanced(struct lruvec *lruvec, struct scan_control *sc,
		int swappiness)
{
	struct lru_gen_folio *lrugen = &lruvec->lrugen;
	unsigned long youngest = 0, old = 0;
	DEFINE_MAX_SEQ(lruvec);
	DEFINE_MIN_SEQ(lruvec);
	int type;

	if (sc->priority > AGING_PRIORITY)
		return false;

	/*
	 * Round up or down corner swappiness, to balance the heavy biased
	 * type better
	 */
	if (swappiness == MIN_SWAPPINESS + 1)
		swappiness = MIN_SWAPPINESS;
	else if (swappiness == MAX_SWAPPINESS)
		swappiness = MAX_SWAPPINESS + 1;

	for_each_evictable_type(type, swappiness) {
		unsigned long seq;

		youngest += lruvec_gen_size(lrugen, type, max_seq,
					    sc->reclaim_idx + 1);
		for (seq = min_seq[type]; seq < max_seq; seq++)
			old += lruvec_gen_size(lrugen, type, seq,
					       sc->reclaim_idx + 1);
	}

	/* the vast majority of pages sit in the youngest gen */
	return youngest > old * MAX_NR_GENS;
}


  reply	other threads:[~2026-11-16  4:50 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14 20:07 [PATCH v9 00/16] mm: mglru: fix swappiness behavior Barry Song (Xiaomi)
2026-11-14 20:07 ` [PATCH v9 01/16] mm/mglru: report evictable sizes per type Barry Song (Xiaomi)
2026-11-14 20:07 ` [PATCH v9 02/16] mm/mglru: extract lruvec_populated_min_seq() helper Barry Song (Xiaomi)
2026-11-14 20:07 ` [PATCH v9 03/16] mm/mglru: reclaim from the oldest populated gen Barry Song (Xiaomi)
2026-11-14 20:07 ` [PATCH v9 04/16] mm/mglru: lift the forced protection of reclaimer Barry Song (Xiaomi)
2026-11-14 20:07 ` [PATCH v9 05/16] mm/mglru: skip zones above reclaim_idx instead of rotating them Barry Song (Xiaomi)
2026-11-14 20:07 ` [PATCH v9 06/16] mm/mglru: return for unavailable anon reclaim earlier Barry Song (Xiaomi)
2026-11-14 20:07 ` [PATCH v9 07/16] mm/mglru: balance anon and file scan budget by refault rate Barry Song (Xiaomi)
2026-11-14 20:07 ` [PATCH v9 08/16] mm/mglru: lift youngest gen protection for higher priority Barry Song (Xiaomi)
2026-11-14 20:07 ` [PATCH v9 09/16] mm/mglru: Avoid placing rejected folios below populated gen Barry Song (Xiaomi)
2026-11-15 15:15   ` Kairui Song
2026-11-14 20:07 ` [PATCH v9 10/16] mm/mglru: Run aging when pages are rare outside the youngest gen Barry Song (Xiaomi)
2026-11-15 15:54   ` Kairui Song
2026-11-16  4:25     ` Barry Song (Xiaomi)
2026-11-16  4:50       ` Andrew Morton [this message]
2026-11-16  5:29         ` Barry Song
2026-11-14 20:07 ` [PATCH v9 11/16] mm/mglru: Run aging when one type is drained Barry Song (Xiaomi)
2026-11-14 20:07 ` [PATCH v9 12/16] mm/mglru: Restrict eviction accounting to eligible zones Barry Song (Xiaomi)
2026-11-14 20:08 ` [PATCH v9 13/16] mm/mglru: Reduce LRU lock contention by shrinking folio batches in inc_min_seq Barry Song (Xiaomi)
2026-11-15 15:52   ` Kairui Song
2026-11-14 20:08 ` [PATCH v9 14/16] mm/mglru: Avoid prolonged anon reclaim with swappiness=200 Barry Song (Xiaomi)
2026-11-14 20:08 ` [PATCH v9 15/16] mm/mglru: Make swappiness=1 file reclaim more aggressive Barry Song (Xiaomi)
2026-11-14 20:08 ` [PATCH v9 16/16] mm/mglru: Avoid scan anon while swapcache is low for GFP_NOIO allocation Barry Song (Xiaomi)
2026-11-14 22:09 ` [PATCH v9 00/16] mm: mglru: fix swappiness behavior Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261115205046.8473acf5a93d69d460598559@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=axelrasmussen@google.com \
    --cc=baohua@kernel.org \
    --cc=baolin.wang@linux.alibaba.com \
    --cc=baoquan.he@linux.dev \
    --cc=hannes@cmpxchg.org \
    --cc=hui.zhu@linux.dev \
    --cc=kunwu.chan@gmail.com \
    --cc=liam@infradead.org \
    --cc=lianux.mm@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=liuxiang.277@bytedance.com \
    --cc=lyugaofei@xiaomi.com \
    --cc=mhocko@kernel.org \
    --cc=mhocko@suse.com \
    --cc=qi.zheng@linux.dev \
    --cc=ridong.chen@linux.dev \
    --cc=rppt@kernel.org \
    --cc=ryncsn@gmail.com \
    --cc=shakeel.butt@linux.dev \
    --cc=sidchintamaneni@gmail.com \
    --cc=surenb@google.com \
    --cc=wangzicheng@honor.com \
    --cc=weixugc@google.com \
    --cc=yuanchu@google.com \
    --cc=zhangbo56@xiaomi.com \
    --cc=zhuhui@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®