From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Shirong Zhao <shxzhaosr@163.com>
Cc: Arend van Spriel <arend.vanspriel@broadcom.com>,
linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
brcm80211-dev-list.pdl@broadcom.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] wifi: brcmfmac: drop glom superframe on header parse failure
Date: Sun, 15 Nov 2026 22:02:49 +0100 [thread overview]
Message-ID: <20261115210253.883721-1-arend.vanspriel@broadcom.com> (raw)
In-Reply-To: <20261009072232.18-1-shxzhaosr@163.com>
On Fri, 9 Oct 2026 15:22:32 +0800, Shirong Zhao <shxzhaosr@163.com> wrote:
> brcmf_sdio_rxglom() uses rd_new.len_nxtfrm and rd_new.dat_offset
> right after the superframe brcmf_sdio_hdparse() without checking
> errcode. On parse failure those fields are either uninitialized
> (the early -ENODATA/-EIO/-EPROTO returns) or hold a rejected value
> (the -ENXIO bad-offset return), so bus->cur_read.len gets garbage
> and skb_pull() runs with a garbage length.
>
> Check errcode first and drop the superframe with the same cleanup
> used for a bad subframe below.
>
> Verified against wireless.git main (fd4e7f1137291), the current
> wireless fixes tree.
>
> Signed-off-by: Shirong Zhao <shxzhaosr@163.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
Nit: as this is a fix, please consider adding a Fixes tag, which looks to be
9d7d6f95bda1 ("brcmfmac: streamline header parse code of sdio glom read"),
and Cc: stable if you want it in the wireless tree.
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Regards,
Arend
next prev parent reply other threads:[~2026-11-15 21:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 10:33 [PATCH] " Shirong Zhao
2026-10-08 18:50 ` Arend van Spriel
2026-10-09 7:22 ` [PATCH v2] " Shirong Zhao
2026-11-15 21:02 ` Arend van Spriel [this message]
2026-11-16 4:15 ` [PATCH v3] " Shirong Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261115210253.883721-1-arend.vanspriel@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=shxzhaosr@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®