From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Andre Eikmeyer <dev@deq.rocks>
Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
brcm80211-dev-list.pdl@broadcom.com,
linux-kernel@vger.kernel.org,
Yossef Osman <Yossef.Osman@proton.me>,
Aditya Garg <aditya.garg@linux.dev>,
Arend van Spriel <arend.vanspriel@broadcom.com>
Subject: Re: [PATCH] wifi: brcmfmac: use a 200 ms power save timeout by default
Date: Sun, 15 Nov 2026 22:02:52 +0100 [thread overview]
Message-ID: <20261115210253.883721-4-arend.vanspriel@broadcom.com> (raw)
In-Reply-To: <20261104151626.70737-1-dev@deq.rocks>
On Wed, 4 Nov 2026 16:16:26 +0100, Andre Eikmeyer wrote:
> cfg80211 calls set_power_mgmt with timeout -1 when userspace leaves the
> dynamic power save timeout to the driver, as NetworkManager does. brcmfmac clamps that to BRCMF_PS_MAX_TIMEOUT_MS, so the firmware
> stays awake for 2 s after every frame in PM_FAST mode and rarely sleeps
> with the background traffic of a typical network.
>
> Use 200 ms for -1. macOS 15.4.1 sets pm2_sleep_ret to 200 ms on the
> BCM4377 of a MacBookAir9,1, seen in a trace of its iovar calls across a
> sleep and wake cycle. Measured on a MacBookPro15,1, idle with WLAN
> associated:
>
> pm2_sleep_ret 2000 ms: 11.2 W system power
> pm2_sleep_ret 200 ms: 9.2 W
> WLAN off: 8.8 W
>
> Tested-by: Yossef Osman <Yossef.Osman@proton.me>
> Tested-by: Aditya Garg <aditya.garg@linux.dev>
> Signed-off-by: Andre Eikmeyer <dev@deq.rocks>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 4 ++++
> 1 file changed, 4 insertions(+)
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Regards,
Arend
prev parent reply other threads:[~2026-11-15 21:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 15:16 Andre Eikmeyer
2026-11-15 21:02 ` Arend van Spriel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261115210253.883721-4-arend.vanspriel@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=Yossef.Osman@proton.me \
--cc=aditya.garg@linux.dev \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=dev@deq.rocks \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®