mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: Avi <thnkslprpt@gmail.com>
Cc: linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cache: sifive_ccache: skip disabled device tree nodes
Date: Mon, 16 Nov 2026 17:20:49 +0000	[thread overview]
Message-ID: <20261116-dreamlike-uncheck-9eebf91555d6@spud> (raw)
In-Reply-To: <CA+jvY9Ft4KKTGD7jM-pBFeN4orRuMs1pQUfcLerKGTW24KDQVQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2771 bytes --]

On Sat, Nov 14, 2026 at 07:40:42PM +0200, Avi wrote:
> On Thu, Nov 5, 2026 at 8:24 PM Conor Dooley <conor@kernel.org> wrote:
> >
> > On Wed, Oct 28, 2026 at 03:19:40PM +0200, Avi Weiss wrote:
> > > sifive_ccache_init() uses of_find_matching_node_and_match(), which also
> > > returns nodes marked as disabled. The initializer can therefore map and
> > > access a cache controller that the device tree marks unavailable.
> > >
> > > Select the first available matching node before accessing its registers.
> > > This also handles a disabled node preceding an enabled one.
> > >
> > > Fixes: a967a289f169 ("RISC-V: sifive_l2_cache: Add L2 cache controller driver for SiFive SoCs")
> > > Signed-off-by: Avi Weiss <thnkslprpt@gmail.com>
> > > ---
> > >  drivers/cache/sifive_ccache.c | 4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/cache/sifive_ccache.c b/drivers/cache/sifive_ccache.c
> > > index 71d3f94987fa..02878d54381d 100644
> > > --- a/drivers/cache/sifive_ccache.c
> > > +++ b/drivers/cache/sifive_ccache.c
> > > @@ -297,7 +297,9 @@ static int __init sifive_ccache_init(void)
> > >       unsigned long quirks __maybe_unused;
> > >       int rc;
> > >
> > > -     np = of_find_matching_node_and_match(NULL, sifive_ccache_ids, &match);
> > > +     for_each_matching_node_and_match(np, sifive_ccache_ids, &match)
> > > +             if (of_device_is_available(np))
> >
> > Are there any devices where this is actually possible? IOW, where there
> > are 2 ccache instances.

> It's more of a defensive thing. The 2 ccache instance was an example -
> the issue is also relevant for one disabled ccache node no?

That is true.
And on the two node front, the driver doesn't support that anyway either
before or after the patch. Consider what the new code does if there are
two nodes, both enabled.

But I don't think the ccache or llc-cache successor are intended for
that kind of situation anyway.

> Since of_find_matching_node_and_match() doesn't check whether a node
> is enabled, it can return a disabled one.
> 
> sifive_ccache_init() then goes ahead and maps and accesses its
> registers, even though the device tree marks it as disabled and normal
> OF platform-device creation would skip it.

Could we instead drop the loop and just check for availability, while
retaining of_find_matching_node_and_match()? I kinda feel like the loop
gives the impression that the driver supports multiple nodes, when it
realistically does not.

Cheers,
Conor.

> 
> >
> > > +                     break;
> > >       if (!np)
> > >               return -ENODEV;
> > >
> > >
> > > base-commit: 65ba8f34ec886ec72b2c07ddc8cf3d815c32869d
> > > --
> > > 2.43.0
> > >

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      reply	other threads:[~2026-11-16 17:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28 13:19 Avi Weiss
2026-11-05 18:24 ` Conor Dooley
2026-11-14 17:40   ` Avi
2026-11-16 17:20     ` Conor Dooley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116-dreamlike-uncheck-9eebf91555d6@spud \
    --to=conor@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=thnkslprpt@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®