From: Krzysztof Kozlowski <krzk@kernel.org>
To: Akshat Chandra <notmissinge@gmail.com>
Cc: linux-iio@vger.kernel.org, jic23@kernel.org, andy@kernel.org,
"Lukasz Kulga" <lukasz.kulga@gmail.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: chemical: Add Sensirion SGP41 binding
Date: Mon, 16 Nov 2026 13:28:38 +0100 [thread overview]
Message-ID: <20261116-eager-loutish-moose-0fdcfb@quoll> (raw)
In-Reply-To: <20261115055941.362185-2-notmissinge@gmail.com>
On Sun, Nov 15, 2026 at 11:29:39AM +0530, Akshat Chandra wrote:
> Add a Device Tree binding for the Sensirion SGP41 VOC and NOx gas
> sensor, including its VDD supply.
>
Few nits except Sashiko comments:
A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23
> Signed-off-by: Akshat Chandra <notmissinge@gmail.com>
> ---
> .../iio/chemical/sensirion,sgp41.yaml | 43 +++++++++++++++++++
> 1 file changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/chemical/sensirion,sgp41.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/chemical/sensirion,sgp41.yaml b/Documentation/devicetree/bindings/iio/chemical/sensirion,sgp41.yaml
> new file mode 100644
> index 000000000000..28528a695cf3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/chemical/sensirion,sgp41.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/chemical/sensirion,sgp41.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sensirion SGP41 VOC and NOx gas sensor
> +
> +maintainers:
> + - Akshat Chandra <notmissinge@gmail.com>
> +
> +description: |
Do not need '|' unless you need to preserve formatting.
> + Sensirion SGP41 indoor air quality sensor measuring raw VOC and NOx
> + signals over I2C.
> +
> +properties:
> + compatible:
> + const: sensirion,sgp41
> +
> + reg:
> + const: 0x59
> +
> + vdd-supply: true
> +
> +required:
> + - compatible
> + - reg
> + - vdd-supply
Missing blank line.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-11-16 12:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20261115055941.362185-1-notmissinge@gmail.com>
2026-11-15 5:59 ` Akshat Chandra
2026-11-16 12:28 ` Krzysztof Kozlowski [this message]
2026-11-15 5:59 ` [PATCH v2 2/2] iio: chemical: Add support for Sensirion SGP41 Akshat Chandra
2026-11-15 21:19 ` kernel test robot
2026-11-16 12:20 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116-eager-loutish-moose-0fdcfb@quoll \
--to=krzk@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.kulga@gmail.com \
--cc=notmissinge@gmail.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®