From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794809667; b=hDeg/XPmIQTc2xmVmUe8aEgnoFdHRtcM2WumRcVcoJ6li2t1f+fPgtFlftyxKqZgGaRs hla4Z4ED0AL4409gNNWm1HR27ixv2feJq699VhMJ/4YBdsBu62kMz4PrHCPv/M/BS3MmW wAGM0sls6rR9QyA7GvtMqQSsf3PlGPXpLPYP0lcFfO0GuNYUcsXpnlJ7S/rOLRxfMHZUp QzUinRfHj7RvVGTEjQLULrsp94c9zEA4Zc0be1nU1SQbrrwsNyGwB7dPdyNojE4V0YGE/ okKNiFnk9EHwZDQXmj/tx6yoyHs+JVkARs7Asp3Vd02W5mGon4Y5EmzYL4JcrbVtLLA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794809667; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:From:Date: Subject:MIME-Version:Content-Type:Content-Transfer-Encoding: Message-Id:References:In-Reply-To:To:Cc:X-Mailer: X-Developer-Signature:X-Developer-Key:X-Authority-Analysis: X-Proofpoint-Spam-Info:X-Proofpoint-Spam-Details-Enc: X-Proofpoint-ORIG-GUID:X-Proofpoint-GUID:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=quFqhC3AFLCeVG613t358vO+Tbv3j9opYxwnp7KC0vo=; b=qiCsThJpHKX2jK0/qfrNUwnAmiCsjg3qcnnOo6BpEIyJKSntdF1uNMYuFPp9EUJa9m5U H1VbtV9AW/5dFWxk+wEx4JGTVdItryd0KArFG8Xq//5+rdWpwx4nJWraFiC7aLSo8N8OV BvvBxmBegSlxVvf4+YzfmZdUgzBV6RaW2M/KQxTYQYPZjyMGMir6utSZdQHEzb73zxm+7 n8y46MBJt9vHVlNm+hUIHP54IqDZrzMMO4k+Fg3sjez1b6MQdSZ//2nmHUVKLPvDtcztz oGBwVlFq0q0gKgJpbgf+Mmwy/8mkJfnUkGRL/aeFCyde89X/m6isVPLWzxijHKtJfcA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=OgapWimU; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=NbCYztRs; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3521A606A32F for ; Mon, 16 Nov 2026 06:14:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 3521A606A32F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=OgapWimU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=NbCYztRs Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6AG5Mjeh2233621 for ; Mon, 16 Nov 2026 06:14:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= quFqhC3AFLCeVG613t358vO+Tbv3j9opYxwnp7KC0vo=; b=OgapWimUbgAKCYOI WMidKLEaimc7JqkRnrHN8neEilUXsYErFV0nuF55SY3raQbm8YqCkbIwvzpmOPGL YeSpx90uP6ihjjzADHLdSSPBfy3ldRT9vV+HKRuoJ7o2dhW2byeaok6l85xZHIwf Aa1VwgbE6tL3A/LF+96YC8S1Cw5FcolooIk2HW4knwT6VknxAAqlXG3uLOqnmefc +B0wnwMcU+8Xb0wfel8PY+b77mYWeloO8bo8k1hIPqQhmIG9hVZhAVxx9Ts7WIuB n3Haohw8v+lix+RCedVjJS0/0POmrrD1XOC/qxhQAuGoK5izrpCcGaqSI3Rt/E8b M3WaLA== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hxhm8vydv-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Nov 2026 06:14:25 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-cd5fd34fee0so1732393a12.3 for ; Sun, 15 Nov 2026 22:14:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1794809665; x=1795414465; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=quFqhC3AFLCeVG613t358vO+Tbv3j9opYxwnp7KC0vo=; b=NbCYztRsTatOmB1DpUx5G3qJi8aWBVQwDSkderFiK6AMAbvlCvh70dBwL0KMJJ38EE LwzmA/chieUVDDvepZytV59ESoF2SD+FpNyxFyOTpail5puJlur5T8Fd2fXL3W/jQy/Z klgJ/ewy32hEqZl5j74i7n2tyEbibRrO1dHjWrRuvecsjQsbiIIm+LhHdYEvLxQ+59vm wfg41YGQKNlERh2FcNlAcmuHfcXS7J2RYcqemX4++O2nS+X6vaGSnQdSvIpOikAu6Lap 6zF9rzSjMqxD+RCWQXIf5Le1onmCSHJpCmXpDYO2K2D6XSdy/n6zR1WK2ViAKM16/MDc tkAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794809665; x=1795414465; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=quFqhC3AFLCeVG613t358vO+Tbv3j9opYxwnp7KC0vo=; b=N8s0GMNTvwHxQMQTUl1Nv9kGiMDvNvEH71/qbDDurZ+Peen2SAN8Py3DZpsplmT1AQ sARh1TTSlTwKbVeRaJopcXBq4H38+gNRRJq0gCVDpMO+S3Kf7UVLiy7d8HyFF0NT0iYn IRTi+BLc0YEQlo03byJA+OmvRYvhVpjvSNaVIY6tVFc080kYNjkWLdrmys2oFJL/B4yn e6R334x5AkOmSJoXeQvJq9brTDb8npONwPbGF1UGJdXOsMyeVsDJHegN5A828LLFAt/p p3L7h6Tfyt+J8AbmX0GMzg49R4ncnY9BlD5WB2dXfIQMdJ7fYEC9Yt9ai6XnpbXK3kv0 utAw== X-Forwarded-Encrypted: i=1; AL+hErHTe46mxil+5zu/KGbDIRt1vzuyeKJG11XI3l6m8S8RtPQ8N1u/oIBN4o5bWwvLZIafj1WmrSCWeEuTX0o=@vger.kernel.org X-Gm-Message-State: APuU4Z/mhqGanze8DoMKcw5HH443UxGwumH62x8VeiqKkdMUX8jf64wA t7gRBrpts/5Sh5JivHqW4f7+J4C6WeCzSQCbji1Zb+gtwoQZVxotx5lwWuc+e+6WDnTLEIGTiF3 ezEXcciATxfLrjlFegHtSCLiVv8hs3HckxVKwK6rsS8NlKWTFFoUc39Ex8323ui35mmA= X-Gm-Gg: AZFdTZf5cbFpD4oB2gl/wiCoH+y7oKAHPUTymLQS/43Y9y0GHKmSBGpLprD2wrP6zk3 tqvL+wjJIcMlaMJIf9jLKXUCauPw5Y4cP8BeD6gAoYdHT8cRuyY721ePZMtyJQZuWKuAOo3AEn2 qdwCO7ycFw0b5zC+eLXDGCRaHPIZJ204oGor4/2ev1Huh7fTSOHhTg/vJRJNfJgDwdHMvPZ12Qs 4HyN0bRHPo/APMjpWdxeBQ4eFaoO4pMRNMCtu4XOZQItTrpA3dN5QkJzfI+K2b+lys7jl0nM354 WNNtWk8J5PEDFRmAfl/rOhNuKrC5fTTIspmH1Ee9pOpMla79LaUvVOxcaYEilR3whtfkE7I9bK+ kgT6F8FmyPZzx+MmaVrjfqt/5NuYXqdRwTQKU4WbFN2qNwjUuGm60/9CG4TXiWeK1wUf+ X-Received: by 2002:a17:90b:2f0c:b0:3b1:8300:f48e with SMTP id 98e67ed59e1d1-3b1b0b89c42mr8719334a91.49.1794809664932; Sun, 15 Nov 2026 22:14:24 -0800 (PST) X-Received: by 2002:a17:90b:2f0c:b0:3b1:8300:f48e with SMTP id 98e67ed59e1d1-3b1b0b89c42mr8719319a91.49.1794809664441; Sun, 15 Nov 2026 22:14:24 -0800 (PST) Received: from [10.213.109.130] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3b197d0f497sm20229444a91.8.2026.11.15.22.14.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Nov 2026 22:14:24 -0800 (PST) From: Jishnu Prakash Date: Mon, 16 Nov 2026 11:43:25 +0530 Subject: [PATCH v5 7/7] mfd: qcom-pm8008: Tolerate missing interrupt X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261116-pm8010_i2c_support-v5-7-5626ba17c0fb@oss.qualcomm.com> References: <20261116-pm8010_i2c_support-v5-0-5626ba17c0fb@oss.qualcomm.com> In-Reply-To: <20261116-pm8010_i2c_support-v5-0-5626ba17c0fb@oss.qualcomm.com> To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Guru Das Srinagesh , Liam Girdwood , Mark Brown Cc: linux-arm-msm@vger.kernel.org, mfd@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Konrad Dybcio , Dhruvin Rajpura , Nihal Kumar Gupta , Kamal Wadhwa , Oleg Keri , Burke Cates , Christian Cortner , Jishnu Prakash X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1794809616; l=4405; i=jishnu.prakash@oss.qualcomm.com; s=20251014; h=from:subject:message-id; bh=EfuTwFmhnLDuS09J9v0oeKJL4sbTdb1eqdg7aPMRmLk=; b=OEJXp9gJIgC0dnPTSo3KyclUz9p2h480OeYiZshte1kpbiYf+tHX/glu5qKYRAIABK0GiZcBP WGDp/gNihrDAfDgxpNyKDcjxIIlak3AKNxRmt5uAkk0JYEXPkzOMNGX X-Developer-Key: i=jishnu.prakash@oss.qualcomm.com; a=ed25519; pk=g89pXdLVwRjdTeQ+uX1QzvBO346E3hQAc1N7fcTXgmk= X-Authority-Analysis: v=2.4 cv=ItKL47/g c=1 sm=1 tr=0 ts=6afa9f42 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=pGLkceISAAAA:8 a=lbcZtXRpr0qBkvjFNboA:9 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMTE2MDAyNCBTYWx0ZWRfXx6r6bi/hzK1c Y4kR1Sxsr+T48c7m6bbzDpCMiA7rWOtViYo6eJEK0mSBB4lmSwS74mGlu1yhLT4cqny8qJfl+zu uPj2a5GsMgJ1onF2ciwz68wKWjOs5XU= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTE2MDAyNCBTYWx0ZWRfXyU4TDa37wNFX 1m1QbgUn6UjqOdikn4S0PjlmPtoS9Rz/OHss6z5nUcUpLEzHsX65oRociH9Uh0j3I6Djj6Y6ZeR 6CcAwFSxB9FSDpa0qQonLvO9vAWMfX8w2ggC401Lp6+qxoQYGG77HN6jEc2QOOzLCn/LqzNucQs pemQFP8Zh/8C7pr9fyifWDebAM5jyKBrAHBXsbMiztXcJlexG2C3vq69yXtgYTv3/yxVf0fvXFV bNHdtMHIfs86RzWJC4JeYHLOhzaaQISIoyA/TGU6i9LBxpepZ2IBpFEcxSTc55NzeKL8pUoKDq1 RFPMfPMmBiRXpXyDGLDjBctI2mDl6nZw2FDa1a9kfrGISsbS0Non+kL39mPsXhlYB7SdjyqL3Zb M3+cjPYWnI9TvpvhERzO/gDWrrdjV6oXurQAfzuUEpqgbAXW4mFbxC3RfWcVmtKHLjWaSabnKey cr25vBPKO6hOlHiZshg== X-Proofpoint-ORIG-GUID: GfIUVYyz2CJkqMOk-g_mJJl8_DVHGuBB X-Proofpoint-GUID: GfIUVYyz2CJkqMOk-g_mJJl8_DVHGuBB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-16_02,2026-11-11_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 adultscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611160024 From: Konrad Dybcio PM8010 is often wired up with the interrupt pin tied to ground. Only register the IRQ infrastructure if we have a parent irq. Signed-off-by: Konrad Dybcio Co-developed-by: Dhruvin Rajpura Signed-off-by: Dhruvin Rajpura Tested-by: Nihal Kumar Gupta # Glymur CRD Tested-by: Burke Cates # ASUS Zenbook A16 (UX3607OA) Tested-by: Christian Cortner # Asus Zenbook A16 (UX3607OA) Co-developed-by: Jishnu Prakash Signed-off-by: Jishnu Prakash --- drivers/mfd/qcom-pm8008.c | 82 ++++++++++++++++++++++++++++++++++------------- 1 file changed, 60 insertions(+), 22 deletions(-) diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c index 39fae8d48e46..9ebbecb90b0f 100644 --- a/drivers/mfd/qcom-pm8008.c +++ b/drivers/mfd/qcom-pm8008.c @@ -208,6 +208,14 @@ static const struct mfd_cell pm8010_cells[] = { MFD_CELL_RES("qpnp-temp-alarm", pm8008_temp_res), }; +static const struct mfd_cell pm8008_no_irq_cells[] = { + MFD_CELL_NAME("pm8008-regulator"), +}; + +static const struct mfd_cell pm8010_no_irq_cells[] = { + MFD_CELL_NAME("pm8010-regulator"), +}; + static void devm_irq_domain_fwnode_release(void *data) { struct fwnode_handle *fwnode = data; @@ -215,20 +223,51 @@ static void devm_irq_domain_fwnode_release(void *data) irq_domain_free_fwnode(fwnode); } +static int pm8008_irq_config(struct device *dev, int irq, struct regmap *regmap, + const struct regmap_irq_chip *irq_chip_desc, + struct regmap_irq_chip_data **irq_data) +{ + struct fwnode_handle *fwnode; + char *name; + int ret; + + name = devm_kasprintf(dev, GFP_KERNEL, "%pOF-internal", dev->of_node); + if (!name) + return -ENOMEM; + + name = strreplace(name, '/', ':'); + + fwnode = irq_domain_alloc_named_fwnode(name); + if (!fwnode) + return -ENOMEM; + + ret = devm_add_action_or_reset(dev, devm_irq_domain_fwnode_release, fwnode); + if (ret) + return ret; + + ret = devm_regmap_add_irq_chip_fwnode(dev, fwnode, regmap, irq, + IRQF_SHARED, 0, irq_chip_desc, + irq_data); + if (ret) { + dev_err(dev, "failed to add IRQ chip: %d\n", ret); + return ret; + } + + return 0; +} + static int pm8008_probe(struct i2c_client *client) { - struct regmap_irq_chip_data *irq_data; + struct regmap_irq_chip_data *irq_data = NULL; const struct regmap_irq_chip *irq_chip_desc; struct device *dev = &client->dev; const struct mfd_cell *mfd_cells; struct regmap *regmap, *regmap2; - struct fwnode_handle *fwnode; struct i2c_client *dummy; struct gpio_desc *reset; unsigned long pmic_type; const void *match_data; int num_mfd_cells; - char *name; int ret; match_data = of_device_get_match_data(dev); @@ -255,6 +294,19 @@ static int pm8008_probe(struct i2c_client *client) return -EINVAL; } + if (!client->irq) { + switch (pmic_type) { + case TYPE_PM8008: + mfd_cells = pm8008_no_irq_cells; + num_mfd_cells = ARRAY_SIZE(pm8008_no_irq_cells); + break; + case TYPE_PM8010: + mfd_cells = pm8010_no_irq_cells; + num_mfd_cells = ARRAY_SIZE(pm8010_no_irq_cells); + break; + } + } + dummy = devm_i2c_new_dummy_device(dev, client->adapter, client->addr + 1); if (IS_ERR(dummy)) { ret = PTR_ERR(dummy); @@ -285,25 +337,11 @@ static int pm8008_probe(struct i2c_client *client) */ usleep_range(1000, 2000); - name = devm_kasprintf(dev, GFP_KERNEL, "%pOF-internal", dev->of_node); - if (!name) - return -ENOMEM; - - name = strreplace(name, '/', ':'); - - fwnode = irq_domain_alloc_named_fwnode(name); - if (!fwnode) - return -ENOMEM; - - ret = devm_add_action_or_reset(dev, devm_irq_domain_fwnode_release, fwnode); - if (ret) - return ret; - - ret = devm_regmap_add_irq_chip_fwnode(dev, fwnode, regmap, client->irq, - IRQF_SHARED, 0, irq_chip_desc, &irq_data); - if (ret) { - dev_err(dev, "failed to add IRQ chip: %d\n", ret); - return ret; + if (client->irq) { + ret = pm8008_irq_config(dev, client->irq, regmap, irq_chip_desc, + &irq_data); + if (ret) + return ret; } return devm_mfd_add_devices(dev, PLATFORM_DEVID_AUTO, mfd_cells, -- 2.43.0