From: Nathan Chancellor <nathan@kernel.org>
To: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
stable@vger.kernel.org, Nathan Chancellor <nathan@kernel.org>
Subject: [PATCH v2] sched/topology: Avoid unsequenced accesses to jiffies in sd_init()
Date: Mon, 16 Nov 2026 13:55:26 -0700 [thread overview]
Message-ID: <20261116-topology-wunsequenced-v2-1-54611119172b@kernel.org> (raw)
After a recent improvement in clang to warn on unsequenced accesses to
volatile variables [1], an instance appears in sd_init(), which can
break the build with CONFIG_WERROR=y / W=e:
In file included from kernel/sched/build_utility.c:86:
kernel/sched/topology.c:2008:29: error: unsequenced accesses to volatile qualified 'jiffies' [-Werror,-Wunsequenced]
1998 | .last_balance = jiffies,
| ~~~~~~~
1999 | .balance_interval = sd_weight,
2000 |
2001 | /* 50% success rate */
2002 | .newidle_call = 512,
2003 | .newidle_success = 256,
2004 | .newidle_ratio = 512,
2005 | .newidle_stamp = now,
2006 |
2007 | .max_newidle_lb_cost = 0,
2008 | .last_decay_max_lb_cost = jiffies,
| ^
Per C11 5.1.2.3.2, accessing a volatile object is a side effect. Per C11
6.5.2, unsequenced side effects on the same scalar object are undefined
behavior. Per C11 6.7.9.23, the evaluation of the initialization list
expressions in a designated initializer is indeterminately sequenced
relative to each other, meaning any side effects in the initialization
list are unsequenced.
Add a local variable to hold the value of jiffies before the designated
initializer so that there are no unsequenced side effects while using a
consistent value, clearing up the warning.
Cc: stable@vger.kernel.org
Closes: https://github.com/ClangBuiltLinux/linux/issues/2190
Fixes: 2b4cfe64dee0 ("sched/numa: Initialize newidle balance stats in sd_numa_init()")
Link: https://github.com/llvm/llvm-project/commit/955715460eaf9188c241c74750637fc82dfcc423 [1]
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
Changes in v2:
- Use a local variable with one access to jiffies before designated
initializer (Nick)
- Link to v1: https://patch.msgid.link/20261114-topology-wunsequenced-v1-1-686a36fe61f5@kernel.org
---
kernel/sched/topology.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index 99878da03bce..60fad1690894 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -1956,6 +1956,7 @@ sd_init(struct sched_domain_topology_level *tl,
int sd_id, sd_weight, sd_flags = 0;
struct cpumask *sd_span;
u64 now = sched_clock();
+ unsigned long j;
sd_span = sched_domain_span(sd);
cpumask_and(sd_span, cpu_map, tl->mask(tl, cpu));
@@ -1973,6 +1974,7 @@ sd_init(struct sched_domain_topology_level *tl,
#endif
sd_flags |= asym_cpu_capacity_classify(sd_span, cpu_map);
+ j = jiffies;
*sd = (struct sched_domain){
.min_interval = sd_weight,
.max_interval = 2*sd_weight,
@@ -1994,7 +1996,7 @@ sd_init(struct sched_domain_topology_level *tl,
| sd_flags
,
- .last_balance = jiffies,
+ .last_balance = j,
.balance_interval = sd_weight,
/* 50% success rate */
@@ -2004,7 +2006,7 @@ sd_init(struct sched_domain_topology_level *tl,
.newidle_stamp = now,
.max_newidle_lb_cost = 0,
- .last_decay_max_lb_cost = jiffies,
+ .last_decay_max_lb_cost = j,
.child = child,
.name = tl->name,
};
---
base-commit: d7e670601af6c564ccf6d3b2ddf70ee4f41a6d1c
base-tree: git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
change-id: 20261114-topology-wunsequenced-18f1d3b9167c
Best regards,
--
Cheers,
Nathan
next reply other threads:[~2026-11-16 20:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 20:55 Nathan Chancellor [this message]
2026-11-17 0:39 ` Nick Desaulniers
2026-11-17 18:30 ` Peter Zijlstra
2026-11-17 18:39 ` Nick Desaulniers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116-topology-wunsequenced-v2-1-54611119172b@kernel.org \
--to=nathan@kernel.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®