From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794836374; b=DQItVZ7sETv0yU8ADSyDl9lGn6+eBzrife2woAJD9d/5dtfVQAnYFA92AzPWBz0Tvedg QisbdQzuUlxGnetQIQKfoPb/DXUgVUCLK3OESJ6cawtew/sDe5LvfKrRJ6F0ThC9QFZIJ o8kDzVQg7V91aNAhLZqVXeGyYdvwy1kZmdr1rkXOls8P9G0jgQv/h0dYRm5SHpQDAp2Sd Azaop7VbXaJy/iQypFIwfnpqfeRgGR7+OeG/l44g9C3qPkcJYryrJe1NKwvbNkQLxd4Qz f8J854/zGdUHYnySt7JYitulqMpR7ffr88Nz3iirA24W6W6yxW2QK2y2wCA3MUqmxJw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794836374; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received: X-Received:Received:From:Date:Subject:MIME-Version:Content-Type: Content-Transfer-Encoding:Message-Id:X-B4-Tracking:X-Change-ID:To:Cc: X-Mailer:X-Developer-Signature:X-Developer-Key; bh=OmxDzzpyB6E7CRRo9uqBsBEYLzdun/syuP5owNmqoic=; b=QkSMoOahB1/8Ha/X3HAoGuqkBRqyqRBqBr74yr4251zj0EnsFCqxs4IHwMO2MHoD3Dfm 4iBkXn2aoIuQM3Bets5rc9hmBed5tKUvANUsm8ghUTqRmwBSKFY0uXzPWsOwmenVCwoKW D+zNzqjXxZ2SdIcSt5/cGmFZTU4VYbJKooKI/hDdxer5SU6NNHgsSWpQPjIdPaJRSI8n/ UGcP0St0gEjV5JL7gRsRo+Rrqs1nZTdg6+JtbnwIJa8YQmLPJ7bsBqeYft+PQAYut+kym b1CfXA83WchOBrwOHk3YPD8XZv1G0e8DorpmEQwcuRsxWDMIoDuFctSEnst35JdQmqw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=MgJTf4Vf; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=BTztOGsX; arc=none smtp.remote-ip=170.10.129.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99E4F606A32F for ; Mon, 16 Nov 2026 13:39:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 99E4F606A32F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=MgJTf4Vf; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=google header.b=BTztOGsX DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1794836372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OmxDzzpyB6E7CRRo9uqBsBEYLzdun/syuP5owNmqoic=; b=MgJTf4VfoZ1d/bbTtFNp0qtJPyeqet4rGqp6XIb8pjR+EXwsAagf9k+fARy6HhNC9ve1NT hCbxN4d8ZDKW9XnbY5oIHNm1eV+OiQqTBbMbK5GIuDOUcWOLcjtuI6mC9wlweCDepT+m08 ndRdy/R7HUDLMbm8C5QMfTA/b6kjYaA= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-121-OFy2-7yyMbiuUYVd8u3v7Q-1; Mon, 16 Nov 2026 08:39:29 -0500 X-MC-Unique: OFy2-7yyMbiuUYVd8u3v7Q-1 X-Mimecast-MFC-AGG-ID: OFy2-7yyMbiuUYVd8u3v7Q_1794836368 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-48df36eaaffso138227f8f.1 for ; Mon, 16 Nov 2026 05:39:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1794836368; x=1795441168; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=OmxDzzpyB6E7CRRo9uqBsBEYLzdun/syuP5owNmqoic=; b=BTztOGsXfFaxP6szTNQUmPZqJpbz4tLw1JZ0v49qQkNddLZ7YkaGedwBdvhDs7sz7g hhVyU/Yw8nKkFe7ty/H8NJnzEEso0ZZA7TnFPqPCW5LkQcxIYXzb9GOpdyt+/wyXEJ9X Jx9+gmBW+vvYv092nw0KPrUviySFdWNcfVExo9cX/GlNvyvmeZvbC00LyJwU6xnHuP6+ mob1qrdiCMohkI9/hfo2CcBVVM6blQ8zSpZi/qNMYBKGfoQDtfDC3QoiqYaIBvkAUDf6 Kwhz3mEw7CftNcmj4YGLHtiAYDMhTb0A8ZUNslciFEumhXXPUC5dzdEtU0mI+8I2DRKC Nd4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794836368; x=1795441168; h=cc:to:message-id:content-transfer-encoding:content-type :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=OmxDzzpyB6E7CRRo9uqBsBEYLzdun/syuP5owNmqoic=; b=YLMAXJFIg6/KFMP8RXU3oUxcTuk3oywd8FqeUYmaLY/vwxCoZthb3+5hcGLCS0CHl8 PTD5r3fTBQAMd9KRo1vY5vlEUFPqVjCDRTllklWcCdNMoZA8Lgc4BdhaN6JnegU9Ks0B d5hJFb50SEXdusO0QYrYycEldFdjX0NSI6b5lIz+jlnbtNInUTYCnYG6GegFslKBav99 NyBCEH2GYoyZR04rY62Ndz2ieTE4ZAM4AL5Nfjy3vS9yZRmEbgVG7JdGqf78aW9XqVs3 JOPxQXBoFZsVwIAB3556xX3AaGuA0zi+R/3jYhPwtLkOXOfWs4lSbbbWADgLnfNuC8in k6mQ== X-Forwarded-Encrypted: i=1; AL+hErGZc28owKPUL7XlHZJX871qolzcTh978+hyHwYKvvcbhrvX1SgIlanBfpPPTFhwqjo/gf07Qa8fsYcWIUk=@vger.kernel.org X-Gm-Message-State: APuU4Z+2VaySvQ8hMP2cHxReI/VYROKphz4leq897oOH+rAfakfwyKtR B4Sh/VuQzqQT3hEO2NbunwInLAdT5MpP5MUqktqLnVEQINk2Qi7RbJmnRw+LBYn4NO+GK+L0jMC K8rz2FQreqKX5VQj6XqI4VJyA1EUkzvvLc3bvFg7NFTJaP34Uw3zXs1WZP/up20Yhbw== X-Gm-Gg: AYBFou2Eq13fankN7J5tI6WsaxlrXoN7swr7RT0fU0629839jIFEGWzTEStWBWg5N5g FjN12jgwyjl18a7VN7F9SfO4RvNQMH7fuek0tTbGo6wqZZetc1nnMFu6V4NmxGTQguMMqUAQH0J FwARHJL7x5OLJE3q7l0D3z2LAm7aEiylwN0X+2jue3sGrpWEX5pKnX66bLrhcylzCKw335+nVMR BHX9EsERuSgtP6oAPsHCPDwYjHrWwpY/qMwWUkqETf7ZxgjrfxKeJiuqMVdl1X/TYhvrUOStYi4 sC7+1D4L31CTQxNKE9ET/d72HzMKl4PEMmyt1KdYaaPgEbd0lFQPS78euy8qSm6MrbYBWvLw2cR 6bSsw3K42JJv+Rw2TeZ/MPqOHyo4Ih0m9rPHwBmYg6S6eJ8x+cQnFS5ws3FlUozvL4V0WtugGPe w/bDsjtQPQFdPyUQ== X-Received: by 2002:a05:600c:16d5:b0:4bb:732a:2837 with SMTP id 5b1f17b1804b1-4bb732a2af5mr33746715e9.1.1794836367921; Mon, 16 Nov 2026 05:39:27 -0800 (PST) X-Received: by 2002:a05:600c:16d5:b0:4bb:732a:2837 with SMTP id 5b1f17b1804b1-4bb732a2af5mr33746245e9.1.1794836367447; Mon, 16 Nov 2026 05:39:27 -0800 (PST) Received: from localhost (119.red-83-42-172.dynamicip.rima-tde.net. [83.42.172.119]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4bb65ce005bsm207627955e9.14.2026.11.16.05.39.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 05:39:26 -0800 (PST) From: Enric Balletbo i Serra Date: Mon, 16 Nov 2026 14:39:24 +0100 Subject: [PATCH] scsi: ufs: core: Use ufshcd_query_attr_retry() for RTC update X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261116-ufs-rtc-query-retry-v1-1-4de69b175e8d@redhat.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/x2MuwqAMAwAf0UyG7BV2uKviINooll8pCqK+O8Wl 4Mb7h6IpEIR6uwBpVOiLHMSk2fQT908EsqQHGxhnTHG4cERde9xO0hvVNoTS7a+CBUHHxhSuSq xXP+1ad/3A8mVq9NlAAAA X-Change-ID: 20261116-ufs-rtc-query-retry-3f27084f878f To: Alim Akhtar , Bart Van Assche , Bean Huo , Stanley Jhu , "James E.J. Bottomley" , "Martin K. Petersen" , Mike Bi , Avri Altman , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= Cc: Luca Porzio , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, NXP S32 Linux Team , linux-arm-kernel@lists.infradead.org, Frank Li , Larisa Grigore , Enric Balletbo i Serra X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1794836365; l=1772; i=eballetb@redhat.com; s=20261026; h=from:subject:message-id; bh=e4EQGaaTBbd9wtA70t1Vx8NEbGVqrdd2zRrcBNi9mFQ=; b=3o+DwdK7dIKBz6QiRt3MIR24WrlJ7wPWsVy0sCk7n5BUey0tWzgVYp0XfhwhC4Xu/UUj5MgWO gtYumqrnV9qALJkaY/8FbG0RNWLrN8fNYqVjOI3l2N916/2CHcnF0ud X-Developer-Key: i=eballetb@redhat.com; a=ed25519; pk=5zh6xuAxTiQwglL2NXQFqWuyRPmCE8T5KPXLbNXhnKI= ufshcd_update_rtc() uses ufshcd_query_attr() directly to write the bSecondsPassed attribute, making it the only query attribute caller in the UFS core that does not use the retry variant. All other callers use ufshcd_query_attr_retry(), which retries up to three times on transient failures before escalating to dev_err. This causes spurious error messages during boot on some platforms when the write-attribute command hits a transient OCS_INVALID_COMMAND_STATUS error: ufs-s32n7 4ac80000.ufs: ufshcd_query_attr: opcode 0x04 for idn 15 failed, index 0, err = 15 ufs-s32n7 4ac80000.ufs: ufshcd_update_rtc: Failed to update rtc 15 Switch to ufshcd_query_attr_retry() to handle transient failures gracefully, consistent with every other attribute query in the driver. Fixes: 6bf999e0eb41 ("scsi: ufs: core: Add UFS RTC support") Signed-off-by: Enric Balletbo i Serra --- drivers/ufs/core/ufshcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index 3c28bc67c65f..1cd32b7cc967 100644 --- a/drivers/ufs/core/ufshcd.c +++ b/drivers/ufs/core/ufshcd.c @@ -8821,8 +8821,8 @@ static void ufshcd_update_rtc(struct ufs_hba *hba) if (ufshcd_rpm_get_if_active(hba) <= 0) return; - err = ufshcd_query_attr(hba, UPIU_QUERY_OPCODE_WRITE_ATTR, QUERY_ATTR_IDN_SECONDS_PASSED, - 0, 0, &val); + err = ufshcd_query_attr_retry(hba, UPIU_QUERY_OPCODE_WRITE_ATTR, + QUERY_ATTR_IDN_SECONDS_PASSED, 0, 0, &val); ufshcd_rpm_put(hba); if (err) --- base-commit: aebb7274476403040d582c61478df8f4a7bf9cd3 change-id: 20261116-ufs-rtc-query-retry-3f27084f878f Best regards, -- Enric Balletbo i Serra