From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=202.12.124.137 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794795242; b=R8jeOJQRjZ9/SqiBGimYtgZDnVjxnZbQfHM1Jt2cIj+yPm7xU654BHaafvhJuJFJ6+LD pPEzCk3cU/hTec7JmdXm3Vaz3E6p6H0oq/+SnXcsOv3vSU7Lw70b4fgLlXiHmsvhKH/BC 2D43hWUQ5qtDs6QwOuDjZR/iU0Tx6dWL0vZsT3CDxTWhVxAexslmu0vs+H11BwUaDub2G +T7XMws7D5xinsub5UG3aVoMINzHg6UBUBsMbS4JvL/RzyCXiuqIzfMadifE5meAdGFml wFjkML/f88JoBG6fiY5rdqY6Y/DfWyop5y8rVixGYh3JhjQXMH6Azm6NEvCS30SDzcA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794795242; h=DMARC-Filter:Received:Received:DKIM-Signature:DKIM-Signature: X-DKIM2-Info:DKIM2-Signature:X-DKIM2-Info:Message-Instance: X-ME-Sender:X-ME-Received:X-ME-Proxy-Cause:X-ME-Proxy:Feedback-ID: Received:From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding; bh=ugaUD7Exh/dOiKWEmehd/cblaOSUygEQnFqj0j36kzI=; b=Xz0C+1a56rNrmlsMJWUj7wCf55gj3F/t2YQZMsrgZAWYi9CE1xA2b/H4PPhXMTrDgD6i eZgLjorOSExGRLcRHwz8Zz5XsfXn2vHHZY43whgw8YDlFJZL9aLBJtVa5Ymhr2XyU72LD c5hrVAtlOrGy9NHDN3Ud8TXBUiiDqZ5RUc8z5Ledk6KF/3HIsNc7hhGC+mB56lxtcCM6r ufctT0Neg+5fDIZOGRrvPGhQGDcMfsyHOQHrWEoAAFc4fMbNLBrH6Kdd5G86SNmLyv2Yd 2b9E4wobPAMwsaCx/fu/Wo82mJnNcuuXeR2sQgzmLwIAjvbvC4CjfMGbTPPf3UngN8Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=fastmail.org; spf=pass smtp.mailfrom=fastmail.org; dkim=pass header.d=fastmail.org header.i=@fastmail.org header.a=rsa-sha256 header.s=fm3 header.b=sE8pUHqW; dkim=pass header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=BZGes3vz; arc=none smtp.remote-ip=202.12.124.137 Received: from flow-b2-smtp.messagingengine.com (flow-b2-smtp.messagingengine.com [202.12.124.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5681D606A31F for ; Mon, 16 Nov 2026 02:14:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 5681D606A31F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fastmail.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fastmail.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=fastmail.org header.i=@fastmail.org header.a=rsa-sha256 header.s=fm3 header.b=sE8pUHqW; dkim=pass (2048-bit key, unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=BZGes3vz Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailflow.stl.internal (Postfix) with ESMTP id CA2CE1302C5B for ; Sun, 15 Nov 2026 21:14:00 -0500 (EST) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-02.internal (MEProxy); Sun, 15 Nov 2026 21:14:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm3; t=1794795239; x= 1794802439; bh=ugaUD7Exh/dOiKWEmehd/cblaOSUygEQnFqj0j36kzI=; b=s E8pUHqWl1m8mrq6LGKaDGpr//EwfkzcHxNv96nMbi/eJqLKBKWcmp/lyn+xCHzyX DjgVZng5cIcIv7Qfa0UG+z1evZ2pFe0pbGAX5nOR/cVnV8L3xX6hXm/UgfH7RB/f d5DbKxR9ZNgzV6pYcEYeRSrlcRmeDT0WWATxew5ltc04+5bqDzFTyY0+GIXhCl+Q PyPB+6sPGK6c7k28WUKkQQqxE/s5dPrQcEnRzHrVVW0mI492mKX/mj2kAIRXgows efjr/G9HYaVt0GRdmwL7TnvyxUPRjboD/8rJLNHKAO0sCqbDgSvIt1WREddy0Nl5 3JuW3UedVm/qezKeX365g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1794795239; x=1794802439; bh=u gaUD7Exh/dOiKWEmehd/cblaOSUygEQnFqj0j36kzI=; b=BZGes3vz5UcWMD4bQ 7SmaGE9gGty/asUHAbxNRiAjXe/1zKkyB/8Z8G8iNkA3gIZPpS7BHFzieHop4fXK soLsl0UPGSKVgdQPrznnRZv2rxjqV7WyY/bU0oiuOKp9J/wbvaRjW+HmPSJSUsoc zefIoU1e0CLyHKp9eKXSo9Srx4dNWJMJ5NuHZYRGvWQVcywVMk4ffOwnKjjbqNdC yPWgi1pmb8GVE3M9WCIijHF79nFMUc9hJxPuTUKgxRelfIRJt4pcM+su2TmeyJW5 GbEi8IGIZ/DsIL73jmnD1T14YWGHs1V/6EGb+9rKmr77RuUES81qoyKv0decfQ2P 9WByw== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=sign d=fastmail.org a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1794795239; d=fastmail.org; mf=PGljYkBmYXN0bWFpbC5vcmc+; rt=PGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc+; s=fm3:rsa-sha256:Btkm9pUC/KqWMvQi3xhE32giPlfKKQWh7UhuSaM0CbJ/wWG 5eSK9a5FpsdLGR3OcfVVdEpt3GBjKsMIT8AFMO41ztlsyJJ0zcANBBFuAjsP5Nhy FJJ00pdh7bAH15cZH1JnBlmTZLQu9J97qfMjmoyVzTQC+ZEAOKdU8wTEFkDZy9bd RkRZrHDZH6uH974pHKycFsGw6MSISy/8ct6HMamJRRaAqJ0CsoGRRqvlCS62QMPF fUXYY018Z1LaDakVNRvHxB9awlxI4ccOPke7psDIJNBKOhQSygpYZkyVRIxSwuK3 rlRPbc50pPSmxAykfohhmZcY0NtXErL2GOT9gIQ==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=mi-m=1; hc=11; hn=cc,content-transfer-encoding,date,feedback-id,from, in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:a0SUuwxdXjfHi9veqSVPqwMMof9IFkme6BOSKv1wGq4=:ugaUD7Exh/dOiKWEmehd/cblaOSUygEQnFqj0j36kzI=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGFIhyhDLa8hCqx+pHyX8RXm1/F8IxDFWP8po2umGjNomO14L385ifnOaol0e1Q5S mozlZXmxCzAlnLWsWrciqC6HsT5r/gK8BNB9f9TVyiBE7J9LY1DnAVrwQx2I38fNqJl3sB RszqqvNLy5iEFfWM2ZaJt4+ymipA1yv7b4IC0rIe5AT/vDy6OaPXXuZksIR1iB1AkBSIxm VAeH3j5Z1CSzyCYYnL6dC47Odz3LiGX0GVTlZTL/K9Q13klpH3uZA+NemLKVnbCa9OneN1 SLWhBX7j4vD66cdqEqh91UULtg0ueJ31/Quw5mTnuG2s9j+ffvQX8JabMhbsmSAtzLuYXu 6P5qYNEz5cYSQ0Cy0sxLxI4fnRnc50MCnyhLyoPqQ4NgFTv9cQykdYWuuD9ZZkpYdgVvMY YP1UIorhMlfjvKrC4gQtgc5JBwrxJ3m+ZUdjOZfiavUxdYYQuFPBIhUY0XXUR53L3RJw8X s+2zghNronIEMpwT/7EWoj/0FAqMXoQbgw3vB77e2KgBRowUoqJcVnbq4l1Lr6oAgJcS97 ALmWSnnM/V18sQsk+qYvpA7H/B/b5IeIda3LjEquH9IqbCu28uF8d137xX9nDLWFQv4e94 8P/THNLu1OpzR83z47tupFqUboSdePPxcV7q+GmRY2qejXMbuA9qOPTrFd4A X-ME-Proxy: Feedback-ID: ib53e4b78:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 15 Nov 2026 21:13:57 -0500 (EST) From: Ian Bridges To: koray.fra@gmail.com Cc: linkinjeon@kernel.org, senozhatsky@chromium.org, tom@talpey.com, chenxiaosong@chenxiaosong.com, hyc.lee@gmail.com, linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, Ian Bridges Subject: Re: [PATCH v3 1/2] ksmbd: decode and honor DOS attribute validity flags Date: Sun, 15 Nov 2026 20:13:51 -0600 Message-ID: <20261116021351.2485365-1-icb@fastmail.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261115155308.415734-1-koray.fra@gmail.com> References: <20261115155308.415734-1-koray.fra@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi, On Sun, Nov 15, 2026 at 04:53:07PM +0100, koraynilay wrote: > Currently, when setting file attributes via FSCTL_SET_SPARSE, > FSCTL_SET_COMPRESSION, or FileBasicInformation, ksmbd hardcodes > flags = 0x51 (XATTR_DOSINFO_ATTRIB | XATTR_DOSINFO_CREATE_TIME | > XATTR_DOSINFO_ITIME). This injects unrequested creation time and itime > into user.DOSATTRIB on disk, even though the client only requested an > attribute modification. I tested both patches with the server code of ksmbd-for-next (3bc1fb9c3b20). Files whose xattr older ksmbd left without the creation time flag now report their stored creation time and attributes, and a rewrite sets the flag again. A file created over SMB keeps its flags and itime when it is made sparse or compressed. A creation time set through a second handle survives a later sparse request through the first. smbtorture gives the same results as without the series, and KASAN reports nothing. Reviewed-by: Ian Bridges Tested-by: Ian Bridges