mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: HyeongJun An <sammiee5311@gmail.com>
To: Takashi Iwai <tiwai@suse.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Mark Brown <broonie@kernel.org>,
	Shuah Khan <shuah@kernel.org>,
	linux-sound@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	HyeongJun An <sammiee5311@gmail.com>
Subject: [PATCH 0/4] ALSA: seq: ump: Fix Note On/Off and key pressure conversion
Date: Mon, 16 Nov 2026 12:03:33 +0900	[thread overview]
Message-ID: <20261116030338.422671-1-sammiee5311@gmail.com> (raw)

Hello Takashi,

While extending seq-ump-test, I found three conversion bugs in
seq_ump_convert.c. In each case the UMP core or the other sequencer
path already does the right thing, and the fix follows it.

Patches 1-3 are the fixes. They also apply to for-linus. Patch 4 adds
the tests on top of seq-ump-test.c in for-next.

Without patches 1-3, the new tests midi1_key_pressure,
ump_midi1_to_midi2_note and ump_midi2_to_midi1_note fail and the other
25 pass. With them, all 28 pass.

Prepared with Claude Code (Claude Opus 5.5). Tested on x86_64 under
qemu, on sound/for-next.

Best regards,
HyeongJun An

HyeongJun An (4):
  ALSA: seq: ump: Don't turn a zero key pressure into a Note Off
  ALSA: seq: ump: Convert a zero-velocity Note On to Note Off for MIDI
    2.0
  ALSA: seq: ump: Keep a soft MIDI 2.0 Note On from becoming a Note Off
  selftests/alsa: Test the sequencer UMP Note On/Off conversion

 sound/core/seq/seq_ump_convert.c            |  10 +-
 tools/testing/selftests/alsa/seq-ump-test.c | 187 +++++++++++++++++++-
 2 files changed, 188 insertions(+), 9 deletions(-)

-- 
2.43.0


             reply	other threads:[~2026-11-16  3:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  3:03 HyeongJun An [this message]
2026-11-16  3:03 ` [PATCH 1/4] ALSA: seq: ump: Don't turn a zero key pressure into a Note Off HyeongJun An
2026-11-16  3:03 ` [PATCH 2/4] ALSA: seq: ump: Convert a zero-velocity Note On to Note Off for MIDI 2.0 HyeongJun An
2026-11-16  3:03 ` [PATCH 3/4] ALSA: seq: ump: Keep a soft MIDI 2.0 Note On from becoming a Note Off HyeongJun An
2026-11-16  3:03 ` [PATCH 4/4] selftests/alsa: Test the sequencer UMP Note On/Off conversion HyeongJun An

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116030338.422671-1-sammiee5311@gmail.com \
    --to=sammiee5311@gmail.com \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=shuah@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®