mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Yuho Choi <oss.patchbox@gmail.com>
Cc: "Jason Wang" <jasowangio@gmail.com>,
	"Eugenio Pérez" <eperezma@redhat.com>,
	"Xuan Zhuo" <xuanzhuo@linux.alibaba.com>,
	virtualization@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] vdpa/vp_vdpa: Wait for device reset to complete
Date: Mon, 16 Nov 2026 03:18:18 -0500	[thread overview]
Message-ID: <20261116031658-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20261116030152.1704527-2-oss.patchbox@gmail.com>

On Sun, Nov 15, 2026 at 10:01:44PM -0500, Yuho Choi wrote:
> vp_vdpa_reset() writes 0 to device_status and returns success right
> away. The virtio specification requires the driver to wait until a read
> of device_status returns 0 before reinitializing the device, and
> virtio_pci_modern's vp_reset() does exactly that: the read-back flushes
> the posted status write and any in-flight device writes, including
> MSI-X messages.
> 
> Without it, vhost-vdpa (or virtio-vdpa) can go on to tear down the
> IOTLB/IOMMU mappings or reprogram the queues while the device has not
> yet finished its reset, and may still be DMAing to the old virtqueue
> addresses. The MSI-X vectors are also freed while an interrupt from
> the old configuration may still be in flight.
> 
> Poll device_status after writing 0, in the same way as vp_reset(),
> before freeing the IRQs and returning.
> 
> Fixes: 64b9f64f80a6 ("vdpa: introduce virtio pci driver")
> Signed-off-by: Yuho Choi <oss.patchbox@gmail.com>
> ---
> v2:
> - Drop Cc: stable, as this has not been reproduced.
> - Rebased on current mainline. No code change.
> 
> v1: https://lore.kernel.org/r/20260926211507.1330179-1-oss.patchbox@gmail.com
> 
> Like vp_reset(), the new loop has no bound, so a surprise-removed
> device that reads back all ones would keep it spinning (the Sashiko
> review of v1 pointed this out). I kept it the same as vp_reset()
> rather than handling that case only here.
> 
> Compile-tested only (x86_64 defconfig + VP_VDPA, W=1).

If you can't bother testing, why should I bother merging?

>  drivers/vdpa/virtio_pci/vp_vdpa.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c
> index 646efd9384fb..eba82ff253ea 100644
> --- a/drivers/vdpa/virtio_pci/vp_vdpa.c
> +++ b/drivers/vdpa/virtio_pci/vp_vdpa.c
> @@ -8,6 +8,7 @@
>   * Based on virtio_pci_modern.c.
>   */
>  
> +#include <linux/delay.h>
>  #include <linux/interrupt.h>
>  #include <linux/module.h>
>  #include <linux/pci.h>
> @@ -236,6 +237,9 @@ static int vp_vdpa_reset(struct vdpa_device *vdpa)
>  	u8 s = vp_vdpa_get_status(vdpa);
>  
>  	vp_modern_set_status(mdev, 0);
> +	/* Wait for the reset to complete */
> +	while (vp_modern_get_status(mdev))
> +		fsleep(1000);
>  
>  	if (s & VIRTIO_CONFIG_S_DRIVER_OK)
>  		vp_vdpa_free_irq(vp_vdpa);
> 
> base-commit: 067c5c24cef23d913b67eaaf71ae67e7169a6620
> -- 
> 2.43.0


      reply	other threads:[~2026-11-16  8:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  3:01 Yuho Choi
2026-11-16  8:18 ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116031658-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=eperezma@redhat.com \
    --cc=jasowangio@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oss.patchbox@gmail.com \
    --cc=virtualization@lists.linux.dev \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®