mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adil Tepe <tadilhusrev@gmail.com>
To: Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	David Heidelberg <david@ixit.cz>
Cc: "Adil Hüsrev Tepe" <tadilhusrev@gmail.com>,
	"Andrew Lunn" <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	netdev@vger.kernel.org, oe-linux-nfc@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/6] nfc: s3fwrn5: drop of_match_ptr() from the I2C driver
Date: Mon, 16 Nov 2026 09:25:41 +0300	[thread overview]
Message-ID: <20261116062542.275485-2-adil.tepe@basarsoft.com.tr> (raw)
In-Reply-To: <20260811220135.472380-2-jorijnvdgraaf@catcrafts.net>

From: Adil Hüsrev Tepe <tadilhusrev@gmail.com>

Hi Jorijn,

Tested on a Samsung Galaxy XCover5 (Exynos850) on top of 7.4-rc1: the
s3fwrn5 I2C driver probes, binds, and does DEV_UP/START_POLL/DEV_DOWN
cleanly with these preparatory patches applied; the "s3fwrn5_i2c" rename
and the of_match_ptr() removal cause no regression, and the PVDD supply
is enabled as expected (NFC is dead without it on this board).

For patches 1/6, 2/6 and 4/6:

Tested-by: Adil Hüsrev Tepe <tadilhusrev@gmail.com>

(3/6 is the binding; I can give Reviewed-by there if useful, but I did
not write the binding so I'll leave that to the DT maintainers.)

The variant patch 5/6 needs a clock-rate fix before it works on this
26 MHz board -- details in my reply to that patch.

Assisted-by: LLM
-- Adil Hüsrev Tepe

  reply	other threads:[~2026-11-16  6:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11 22:01 [PATCH v5 0/6] nfc: s3fwrn5: support the S3NRN4V variant Jorijn van der Graaf
2026-08-11 22:01 ` [PATCH v5 1/6] nfc: s3fwrn5: drop of_match_ptr() from the I2C driver Jorijn van der Graaf
2026-11-16  6:25   ` Adil Tepe [this message]
2026-08-11 22:01 ` [PATCH v5 2/6] nfc: s3fwrn5: use the "s3fwrn5_i2c" string literal directly Jorijn van der Graaf
2026-08-11 22:01 ` [PATCH v5 3/6] dt-bindings: net: nfc: samsung,s3fwrn5: add the S3NRN4V Jorijn van der Graaf
2026-08-11 22:01 ` [PATCH v5 4/6] nfc: s3fwrn5: enable the PVDD supply Jorijn van der Graaf
2026-08-11 22:01 ` [PATCH v5 5/6] nfc: s3fwrn5: support the S3NRN4V variant Jorijn van der Graaf
2026-08-12 11:18   ` David Heidelberg
2026-08-12 15:28     ` Jorijn van der Graaf
2026-11-16  6:25   ` Adil Tepe
2026-08-11 22:01 ` [PATCH v5 6/6] arm64: dts: qcom: milos-fairphone-fp6: Add NFC Jorijn van der Graaf
2026-08-18 10:27   ` Konrad Dybcio
2026-09-27  3:48   ` Alexander Koskovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116062542.275485-2-adil.tepe@basarsoft.com.tr \
    --to=tadilhusrev@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=david@ixit.cz \
    --cc=edumazet@google.com \
    --cc=jorijnvdgraaf@catcrafts.net \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oe-linux-nfc@lists.linux.dev \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®