From: Mehmet Fide <mehmet.fide@gmail.com>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: Luka Gejak <luka.gejak@linux.dev>,
Zong-Zhe Yang <kevin_yang@realtek.com>,
Tzu-En Huang <tehuang@realtek.com>,
Yan-Hsuan Chuang <yhchuang@realtek.com>,
Kalle Valo <kvalo@kernel.org>,
Stanislaw Gruszka <sgruszka@redhat.com>,
Brian Norris <briannorris@chromium.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
mehmet.fide@screeningeagle.com
Subject: [PATCH rtw-next v2 0/3] wifi: rtw88: three fixes around the firmware recovery
Date: Mon, 16 Nov 2026 08:20:11 +0100 [thread overview]
Message-ID: <20261116072014.1142494-1-mehmet.fide@gmail.com> (raw)
From: Mehmet Fide <mehmet.fide@screeningeagle.com>
Three fixes for what a firmware crash test showed on an RTL8822CE.
They do not depend on the channel switch series, but patch 1 and
patch 2 of that series (v11) both change rtw_fw_update_beacon_work():
the one applied second needs both conditions in its test, and I will
rebase it when asked.
Tested on rtw-next on an i.MX8MP board with PROVE_LOCKING,
DEBUG_ATOMIC_SLEEP and kmemleak, with hostapd. The
firmware crashes were triggered from debugfs on the RTL8822CE:
- patch 1: three crashes with an associated station interface lost
five reserved pages before and none after; six crashes with an AP
interface lost three before and none after. A test build that queues
the beacon update work between the reset and the reconfiguration
warned "Should not have an empty reserved page" with v1 and did not
with v2
- patch 2: an unbind after the crashes warned "Have pending ack
frames!" before and did not after. With a test build that drops
every TX report of the firmware, the unbind of the RTL8822CE warned
before; after, neither it nor the RTL8822BU did
- patch 3: each of three crashes with an associated station gave the
"sleeping function called from invalid context" report before and
none did after; the link was back after every crash
With the three patches, AP, association, power save, firmware crash
and scan tests on the RTL8822CE, RTL8822CU, RTL8822BU and RTL8821CU
(two adapters) on both bands gave no kernel report and no kmemleak
report, also after the rebase.
v2:
- patch 1: the beacon update work does nothing while
RTW_FLAG_RESTARTING is set (Luka Gejak)
- patches 2 and 3: Reviewed-by Luka Gejak, no change
- rebased on rtw-next
v1: https://lore.kernel.org/linux-wireless/20261111213239.569224-1-mehmet.fide@gmail.com/
Mehmet Fide (3):
wifi: rtw88: free the reserved pages of an interface on firmware
recovery
wifi: rtw88: report the frames purged from the TX report queue
wifi: rtw88: reset the stations outside of RCU on firmware recovery
drivers/net/wireless/realtek/rtw88/fw.c | 6 ++++--
drivers/net/wireless/realtek/rtw88/main.c | 8 +++-----
drivers/net/wireless/realtek/rtw88/tx.c | 20 ++++++++++++++++----
drivers/net/wireless/realtek/rtw88/tx.h | 1 +
4 files changed, 24 insertions(+), 11 deletions(-)
base-commit: 61a5eb87b2d9b4d5e353780b781cf691f39ba9e1
--
2.56.0
next reply other threads:[~2026-11-16 7:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 7:20 Mehmet Fide [this message]
2026-11-16 7:20 ` [PATCH rtw-next v2 1/3] wifi: rtw88: free the reserved pages of an interface on " Mehmet Fide
2026-11-16 7:20 ` [PATCH rtw-next v2 2/3] wifi: rtw88: report the frames purged from the TX report queue Mehmet Fide
2026-11-16 7:20 ` [PATCH rtw-next v2 3/3] wifi: rtw88: reset the stations outside of RCU on firmware recovery Mehmet Fide
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116072014.1142494-1-mehmet.fide@gmail.com \
--to=mehmet.fide@gmail.com \
--cc=briannorris@chromium.org \
--cc=kevin_yang@realtek.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luka.gejak@linux.dev \
--cc=mehmet.fide@screeningeagle.com \
--cc=pkshih@realtek.com \
--cc=sgruszka@redhat.com \
--cc=tehuang@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®