mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Williamson <alex@shazbot.org>
To: Gustavo Andrade <gustavogyn@gmail.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	kvm@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org, alex@shazbot.org
Subject: Re: [RFC PATCH 0/1] vfio/pci: Wait for GB202 firmware after reset
Date: Mon, 16 Nov 2026 07:40:22 -0800	[thread overview]
Message-ID: <20261116074022.29d96bd7@shazbot.org> (raw)
In-Reply-To: <CAPZV9qUMZcwVF=CUK4LY4G6Qoqd5ykCXE5ocX8VCy_f1c6+aBw@mail.gmail.com>

On Sat, 14 Nov 2026 22:47:34 -0300
Gustavo Andrade <gustavogyn@gmail.com> wrote:

> Hi Jason,
> 
> Thanks for the feedback. I submitted this as an RFC because, while the
> workaround solved the issue for me, it seemed unusual that only my
> card required it, since I haven't seen recent reports of this issue.
> 
> How would you suggest I proceed? I am currently running the latest
> VBIOS available for my card (Palit RTX 5090 GameRock, version
> 98.02.2E.80.10), which is also the most recent version listed in the
> TechPowerUp database.

I imagine a better shape for a quirk is a resetfn in QEMU.

The fact that nova knows about this issue and has code to handle it
suggests to me that it's only the guest initial boot and reboot, where
the VBIOS is run before the FSP is initialized, that's causing the
problem. We don't want to pollute every vfio-pci reset with this
wait-for-device action (if we did, a reset_done callback would be a
better solution) and I also don't think we want to implement a
kernel PCI-core device specific reset.  Either of those would make the
device behave differently in a VM, or modify the current bare metal
behavior that's clearly expected by drivers like nova.

A resetfn in QEMU can be device specific, wait for FSP to initialize,
and not affect runtime resets where it would be the driver's
responsibility to wait for FSP, as nova already does.  For example
something similar to vfio_radeon_reset(), but calling the
VFIO_DEVICE_RESET ioctl and then stalling for the FSP initialization
to complete.  Thanks,

Alex

      reply	other threads:[~2026-11-16 15:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14  2:48 Gustavo A.
2026-11-14  2:49 ` [RFC PATCH] vfio/pci: Wait for GB202 firmware initialization " Gustavo A.
2026-11-14 23:58 ` [RFC PATCH 0/1] vfio/pci: Wait for GB202 firmware " Jason Gunthorpe
     [not found]   ` <CAPZV9qUvgKjoBXGjYXJzwnCmqzSfu781ZSG8zW6Fn4PokUN2uQ@mail.gmail.com>
2026-11-15  1:47     ` Gustavo Andrade
2026-11-16 15:40       ` Alex Williamson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116074022.29d96bd7@shazbot.org \
    --to=alex@shazbot.org \
    --cc=bhelgaas@google.com \
    --cc=gustavogyn@gmail.com \
    --cc=jgg@nvidia.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®