From: Nhat Tran <nhat.tranminhk2@gmail.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: renesas-usb-vbus-regulator: Fix module autoloading
Date: Mon, 16 Nov 2026 16:17:20 +0700 [thread overview]
Message-ID: <20261116091720.112637-1-nhat.tranminhk2@gmail.com> (raw)
In-Reply-To: <TYYPR01MB66035439726639C9F4C2A5B9867C2@TYYPR01MB6603.jpnprd01.prod.outlook.com>
Hi Biju,
On Mon, Nov 16, 2026 at 09:00 UTC, Biju Das wrote:
> A patch is already mainlined [1] with these changes as part of RZ/G3L
> regulator support.
Sorry, I missed that series. Please drop this patch.
On Mon, Nov 16, 2026 at 09:06 UTC, Biju Das wrote:
>> +static const struct platform_device_id rzg2l_usb_vbus_regulator_ids[] = {
>> + { .name = "rzg2l-usb-vbus-regulator" },
>
> Have you tested this patch properly?
>
> I had an issue in probing the device related to id_table match due to
> string length restriction in [2]
You are right. "rzg2l-usb-vbus-regulator" is 24 characters long, so it
does not fit in name[PLATFORM_NAME_SIZE] together with its terminating
NUL.
I tested it on an RZ/G2L SMARC EVK with the driver built as a module:
the module was loaded automatically and USB0 probed. But that only
worked by luck: driver_data is 0 and directly follows name[], so
strcmp() stops there. With a non-zero driver_data, as in your RZ/G3L
patch, the match fails. Renaming the device, as you did, is the right
fix.
Thanks for the review,
Nhat
prev parent reply other threads:[~2026-11-16 9:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 8:44 Nhat Tran
2026-11-16 9:00 ` Biju Das
2026-11-16 9:06 ` Biju Das
2026-11-16 9:17 ` Nhat Tran [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116091720.112637-1-nhat.tranminhk2@gmail.com \
--to=nhat.tranminhk2@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®