From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Andre Eikmeyer <dev@deq.rocks>
Cc: arend.vanspriel@broadcom.com, linux-wireless@vger.kernel.org,
brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com,
linux-kernel@vger.kernel.org, sebastian.reichel@collabora.com,
Lukas Klizas <lukas@klizas.lt>,
Yossef Osman <Yossef.Osman@proton.me>,
Aditya Garg <aditya.garg@linux.dev>
Subject: Re: [PATCH] wifi: brcmfmac: reload the firmware after a missing D3 ACK
Date: Mon, 16 Nov 2026 12:08:39 +0100 [thread overview]
Message-ID: <20261116110839.4481-1-arend.vanspriel@broadcom.com> (raw)
In-Reply-To: <20261104151616.70623-1-dev@deq.rocks>
On Wed, 4 Nov 2026 16:16:16 +0100, Andre Eikmeyer <dev@deq.rocks> wrote:
> Since commit 6f88e6ebdc1a ("wifi: brcmfmac: Improve D3 substate entering
> timeout handling") system suspend goes on after a missing D3 ACK when
> WoWL is off. On resume brcmf_pcie_pm_leave_D3() still takes the hot
> resume path when the INTMASK register reads back nonzero. Firmware that
> did not answer D3_INFORM can do that and stays dead afterwards.
>
> [...]
>
> Record the missing ACK and force the remove and re-probe path on the
> next resume so the firmware is loaded again.
>
> brcmf_msgbuf_delete_flowring() waits for outstanding tx status before
> it checks the bus state. Check the bus first and stop waiting when it
> goes down, since the firmware does not report tx status then.
>
> Fixes: 6f88e6ebdc1a ("wifi: brcmfmac: Improve D3 substate entering timeout handling")
> ---
> .../broadcom/brcm80211/brcmfmac/msgbuf.c | 22 ++++++++++++-------
> .../broadcom/brcm80211/brcmfmac/pcie.c | 16 ++++++++++++++
> 2 files changed, 30 insertions(+), 8 deletions(-)
Thanks for the patch. The resume problem is addressed by Andre Eikmeyer's
series "wifi: brcmfmac: pcie: S3 and deep sleep on the T2 Mac chips" [1]:
- Patch 3/5 ("probe again after a resume through firmware") sends
brcmf_pcie_pm_leave_D3() straight to the remove and re-probe path when
the platform firmware handled the resume and WoWL is off, before the
INTMASK check that lets a dead firmware take the hot resume path.
- Patch 4/5 ("send the flowring delete without waiting for tx status")
removes the tx status wait in brcmf_msgbuf_delete_flowring() that stalls
the flowring teardown when the firmware is gone.
Your patch forces the re-probe on any missed D3 ACK for every PCIe chip,
which also hits firmware that never ACKs D3_INFORM when idle, such as
BCM43752 behind 6f88e6ebdc1a, and logs an error for an expected case. Note
that the msgbuf.c change is a separate change from the D3 ACK handling as
well.
Please test with that series applied. If a case remains where a missed D3
ACK leaves the firmware dead, send a patch on top of it, limited to the
affected chips, with a description of the failure.
[1] https://patchwork.kernel.org/project/linux-wireless/list/?series=1208304
Regards,
Arend
next prev parent reply other threads:[~2026-11-16 11:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 15:16 Andre Eikmeyer
2026-11-16 11:08 ` Arend van Spriel [this message]
2026-11-17 12:12 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116110839.4481-1-arend.vanspriel@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=Yossef.Osman@proton.me \
--cc=aditya.garg@linux.dev \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=dev@deq.rocks \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lukas@klizas.lt \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®