From: Andrew Morton <akpm@linux-foundation.org>
To: Sasha Levin <sashal@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Theodore Ts'o <tytso@mit.edu>, Willy Tarreau <w@1wt.eu>,
workflows@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
David Hildenbrand <david@kernel.org>
Subject: Re: [PATCH] docs: submitting-patches: ask bug fixes for their user-visible impact
Date: Mon, 16 Nov 2026 11:34:53 -0800 [thread overview]
Message-ID: <20261116113453.013103c694ad966c56ddeb31@linux-foundation.org> (raw)
In-Reply-To: <20261116191436.188098-1-sashal@kernel.org>
On Mon, 16 Nov 2026 14:14:36 -0500 Sasha Levin <sashal@kernel.org> wrote:
> "Describe your changes" already asks for the user-visible impact of a
> change, but changelogs for fixes still tend to say what the code does,
> why that's wrong and what the patch changes, and stop there. Whoever
> has to decide if the fix needs backporting is left to work out what
> the bug does to a running system.
>
> Say what that means for a bug fix: describe the worst a user can see
> and what it takes to trigger it, say so if the bug was never seen to
> happen, and say so if it has no visible effect at all. Give the
> paragraph a label so people can be pointed at it.
>
> Coding assistants are told to commit a fix with a message that
> describes the problem and the solution. Add the user-visible impact to
> that list and point them at the section.
Thanks. Hopefully this will reduce my outbound nagmails.
Acked-by: Andrew Morton <akpm@linux-foundation.org>
> +For a bug fix, this means saying what the bug does to a running system:
> +the worst that a user can see, and what it takes to trigger it. An
> +account of what the code does wrong is not a substitute, as it leaves
> +every reader to work the consequences out again. If the bug was found
> +by review or by a tool and has never been seen to happen, say so. If
> +it has no effect that a user could notice, say that too. Maintainers
> +and the people looking after stable trees decide from this whether the
> +fix needs to be backported.
However, I fear that in these times this isn't strong enough.
The question used to be "will this bug impact real-world people doing
real-world things".
That's an insufficient question to be asking now. An additional
question is "can this bug permit a sufficiently motivated, well funded
and LLM-using Bad Actor to cause problems".
Real-world people's real-world workloads don't use an LLM-written
exploit to set 16 CPUs hammering away at an LLM-detected kernel race
for an hour.
So those fantastically-hard-to-hit bugs have become things which we
(and those whom we serve) care about more than we used to.
Maybe this doc addresses that elsewhere, tl;dr ;)
next prev parent reply other threads:[~2026-11-16 19:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 19:14 Sasha Levin
2026-11-16 19:34 ` Andrew Morton [this message]
2026-11-16 19:49 ` Willy Tarreau
2026-11-16 19:52 ` Sasha Levin
2026-11-16 19:58 ` Andrew Morton
2026-11-16 20:01 ` Willy Tarreau
2026-11-16 19:47 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116113453.013103c694ad966c56ddeb31@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=david@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sashal@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tytso@mit.edu \
--cc=w@1wt.eu \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®