From: Anil Kaushik <anilkaushikwireless@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, idosch@nvidia.com,
nicolas.dichtel@6wind.com, jacob.e.keller@intel.com,
jiri@resnulli.us, fw@strlen.de, martineau@kernel.org,
v3rdant.xiang@gmail.com, aliceryhl@google.com,
linux-kernel@vger.kernel.org, nhorman@tuxdriver.com,
shuah@kernel.org, linux-kselftest@vger.kernel.org,
anilkaushikwireless@gmail.com
Subject: [PATCH net v7 0/2] genetlink: Reject joining multicast groups no family owns
Date: Mon, 16 Nov 2026 12:40:28 +0000 [thread overview]
Message-ID: <20261116124030.1595567-1-anilkaushikwireless@gmail.com> (raw)
genl_bind() lets any user join a multicast group ID that no family owns.
A family registered later can get that ID, and the socket stays a member
without a capability check. Patch 1 makes genl_bind() return -ENOENT for
such an ID. Patch 2 adds a selftest for it.
v7:
- Add a selftest as patch 2, as Nicolas asked.
- Say in the comments on the static IDs, and on NET_DM_GRP_ALERT, that
they can be joined only after the family is registered (Sashiko).
- Say in the commit message that the unregister window was already
there for the capability check.
v6: https://lore.kernel.org/netdev/20261112094205.1120090-1-anilkaushikwireless@gmail.com/
I used an LLM to help write and review the code, the tests and the
commit messages of this series. I checked and tested every change
myself.
Anil Kaushik (2):
genetlink: Reject joining multicast groups no family owns
selftests: net: test joining genetlink groups no family owns
include/linux/netlink.h | 3 +
include/uapi/linux/net_dropmon.h | 2 +
net/netlink/af_netlink.c | 6 +
net/netlink/genetlink.c | 5 +-
tools/testing/selftests/net/Makefile | 1 +
tools/testing/selftests/net/nl_genl_mcast.py | 109 +++++++++++++++++++
6 files changed, 125 insertions(+), 1 deletion(-)
create mode 100755 tools/testing/selftests/net/nl_genl_mcast.py
base-commit: 070411c1590c8172eb4d86f045d99c372f22fe23
--
2.25.1
next reply other threads:[~2026-11-16 12:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 12:40 Anil Kaushik [this message]
2026-11-16 12:40 ` [PATCH net v7 1/2] " Anil Kaushik
2026-11-16 12:40 ` [PATCH net v7 2/2] selftests: net: test joining genetlink " Anil Kaushik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116124030.1595567-1-anilkaushikwireless@gmail.com \
--to=anilkaushikwireless@gmail.com \
--cc=aliceryhl@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=v3rdant.xiang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®