mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Hungyu Lin <dennylin0707@gmail.com>
Cc: jgg@ziepe.ca, maorg@nvidia.com, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/mlx5: Check the DM type before mapping a MEMIC operation
Date: Mon, 16 Nov 2026 15:22:05 +0200	[thread overview]
Message-ID: <20261116132205.GM11319@unreal> (raw)
In-Reply-To: <20261115104342.56112-1-dennylin0707@gmail.com>

On Sun, Nov 15, 2026 at 10:43:42AM +0000, Hungyu Lin wrote:
> MLX5_IB_METHOD_DM_MAP_OP_ADDR accepts a handle to any DM object and
> converts it with to_memic() without checking the DM type. The handle can
> refer to a SW ICM object, which is a struct mlx5_ib_dm_icm and is
> smaller than struct mlx5_ib_dm_memic.
> 
> The handler then uses the ops_xa_lock, ops and ref members, which are
> all located past the end of the mlx5_ib_dm_icm allocation, so it locks
> and modifies memory that belongs to other slab objects.
> 
> Return -EOPNOTSUPP for DM objects that are not MEMIC, as
> MLX5_IB_METHOD_DM_QUERY already does.
> 
> Fixes: cea85fa5dbc2 ("RDMA/mlx5: Add support in MEMIC operations")
> Cc: stable@vger.kernel.org
> Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
> ---
>  drivers/infiniband/hw/mlx5/dm.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/infiniband/hw/mlx5/dm.c b/drivers/infiniband/hw/mlx5/dm.c
> index 7a6fe4fea3e2..16e42fd6c802 100644
> --- a/drivers/infiniband/hw/mlx5/dm.c
> +++ b/drivers/infiniband/hw/mlx5/dm.c
> @@ -213,6 +213,9 @@ static int UVERBS_HANDLER(MLX5_IB_METHOD_DM_MAP_OP_ADDR)(
>  	int err;
>  	u8 op;
>  
> +	if (dm->base.type != MLX5_IB_UAPI_DM_TYPE_MEMIC)
> +		return -EOPNOTSUPP;
> +
>  	err = uverbs_copy_from(&op, attrs, MLX5_IB_ATTR_DM_MAP_OP_ADDR_REQ_OP);
>  	if (err)
>  		return err;

I applied this patch with the following change:

diff --git a/drivers/infiniband/hw/mlx5/dm.c b/drivers/infiniband/hw/mlx5/dm.c
index 6a1971b9627b1..7d1e642a8d4c9 100644
--- a/drivers/infiniband/hw/mlx5/dm.c
+++ b/drivers/infiniband/hw/mlx5/dm.c
@@ -208,12 +208,13 @@ static int UVERBS_HANDLER(MLX5_IB_METHOD_DM_MAP_OP_ADDR)(
                attrs, MLX5_IB_ATTR_DM_MAP_OP_ADDR_REQ_HANDLE);
        struct mlx5_ib_dev *dev = to_mdev(uobj->context->device);
        struct ib_dm *ibdm = uobj->object;
+       struct mlx5_ib_dm *mdm = to_mdm(ibdm);
        struct mlx5_ib_dm_memic *dm = to_memic(ibdm);
        struct mlx5_ib_dm_op_entry *op_entry;
        int err;
        u8 op;

-       if (dm->base.type != MLX5_IB_UAPI_DM_TYPE_MEMIC)
+       if (mdm->base.type != MLX5_IB_UAPI_DM_TYPE_MEMIC)
                return -EOPNOTSUPP;

        err = uverbs_copy_from(&op, attrs, MLX5_IB_ATTR_DM_MAP_OP_ADDR_REQ_OP);

Thanks

> -- 
> 2.43.0

  reply	other threads:[~2026-11-16 13:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 10:43 Hungyu Lin
2026-11-16 13:22 ` Leon Romanovsky [this message]
2026-11-16 13:22 ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116132205.GM11319@unreal \
    --to=leon@kernel.org \
    --cc=dennylin0707@gmail.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=maorg@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®