From: Val Packett <val@packett.cool>
To: Georgi Djakov <djakov@kernel.org>
Cc: Val Packett <val@packett.cool>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Konrad Dybcio <konradybcio@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] interconnect: qcom: sc8180x: Mark MM0 BCM keepalive
Date: Mon, 16 Nov 2026 10:29:18 -0300 [thread overview]
Message-ID: <20261116133610.990456-2-val@packett.cool> (raw)
The MM0 BCM needs to be up at all times, otherwise (especially after
enabling camss support) on some boot attempts AOSS can hang:
qcom_rpmh TCS=0 [ctrlr-sts:BUSY amc-mode:0x1010000 irq-sts:WAITING]
qcom_rpmh CMD=3 [addr=0x50084(BCM/MM0) data=0x600001df resp-required sts=triggered+sent-to-aoss] (..)
qcom_rpmh HW IRQ 37 is NOT PENDING at GIC
qcom_rpmh Completion is not done
qcom_rpmh ERROR: Accelerator(s) at AOSS did not respond
SM8250, SM8350, SC7280, etc. all use keepalive on MM0 so this seems
like the right solution.
Signed-off-by: Val Packett <val@packett.cool>
---
Maybe camss is a red herring even (despite the only thing linked
to the BCM being SLAVE_MNOC_HF_MEM_NOC which is linked to camss
things.. well, also mdp0 and mdp1), I've had occasional boot
"freezes" (blank screen and not connected to WiFi) for much longer
on the Surface Pro X. Looking now at a `journalctl -b-1` after such a
freeze though I've discovered that RPMh debug output from above.
I don't have internal knowledge but I've seen that people have
added keepalive to BCMs to fix hangs, and this log implicated
BCM/MM0 directly while all the newer SoC interconnect drivers
did have keepalive on MM0...
Can't say I've had the time to *extensively* test this, that'll
take some time, but hopefully someone w/ HW knowledge can quickly
confirm or deny whether this is correct :)
Thanks,
~val
---
drivers/interconnect/qcom/sc8180x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/interconnect/qcom/sc8180x.c b/drivers/interconnect/qcom/sc8180x.c
index fef77cd2bf69..9031e49e6564 100644
--- a/drivers/interconnect/qcom/sc8180x.c
+++ b/drivers/interconnect/qcom/sc8180x.c
@@ -1365,6 +1365,7 @@ static struct qcom_icc_bcm bcm_sh0 = {
static struct qcom_icc_bcm bcm_mm0 = {
.name = "MM0",
+ .keepalive = true,
.num_nodes = 1,
.nodes = { &slv_qns_mem_noc_hf }
};
--
2.56.0
reply other threads:[~2026-11-16 13:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116133610.990456-2-val@packett.cool \
--to=val@packett.cool \
--cc=andersson@kernel.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®