From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: peterz@infradead.org, tglx@kernel.org, mingo@redhat.com,
linux-kernel@vger.kernel.org, will@kernel.org, boqun@kernel.org,
longman@redhat.com, rostedt@goodmis.org, clrkwllms@kernel.org,
dvhart@infradead.org, dave@stgolabs.net, andrealmeid@igalia.com,
shuah@kernel.org, juri.lelli@redhat.com,
linux-rt-devel@lists.linux.dev, linux-kselftest@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2 2/5] locking/rtmutex: Initialize the ww_mutex context of a waiter
Date: Mon, 16 Nov 2026 14:58:57 +0100 [thread overview]
Message-ID: <20261116135857.5t9HGji5@linutronix.de> (raw)
In-Reply-To: <20261108141347.1525532-3-mathieu.desnoyers@efficios.com>
On 2026-11-08 09:13:44 [-0500], Mathieu Desnoyers wrote:
> With PREEMPT_RT and CONFIG_DEBUG_RT_MUTEXES, FUTEX_LOCK_PI reports no
> deadlock. Two threads that each block on a PI futex the other holds
> sleep forever. Without PREEMPT_RT, the second one gets EDEADLK. A chain
> deeper than max_lock_depth is also admitted.
>
> With PREEMPT_RT, ww_mutexes are built on rtmutexes. They can create a
> cycle in the lock graph legitimately, and the wound/die logic resolves
> it. So the PREEMPT_RT chain walk turns deadlock detection off when it
> finds a waiter with a ww_mutex context, waiter->ww_ctx. It also drops
> the -EDEADLK of a walk that started from such a waiter.
I *think* this is unrelated because the futex caller shouldn't end up
here. The __rt_mutex_slowlock() -> rt_mutex_handle_deadlock() should be
different for the futex and ww_mutex case.
> But rt_mutex_init_waiter() does not set waiter->ww_ctx. Only
> __rt_mutex_slowlock_locked() sets it. So the waiters of PI futexes and
> rtlocks keep the 0x11 poison of CONFIG_DEBUG_RT_MUTEXES. Without that
> option, they keep what was on the stack, unless the compiler zeroes it.
> The chain walk then takes them for ww_mutex waiters.
Is this really the case?
You have a lock chain where the ww_mutex and a regular rtmutex interact?
This doesn't sound too crazy. __waiter_less() expects it to be NULL for
those.
>
> The ww_mutex build of the chain walk can also requeue such waiters. On
> two of them with equal priority, __waiter_less() would dereference the
> poison.
I *think* the enqueue part is only affected if a regular rtmutex already
exists. Because the rtmutex enqueue would ignore ww_mutex/ treat it as
equals.
This will affect rt_mutex_adjust_prio_chain(), the futex interface which
is the only user of the chainwalk.
> Fix this by clearing waiter->ww_ctx in rt_mutex_init_waiter().
>
> With this patch, the ABBA and the deep chain both get EDEADLK. The
> futex_lock_pi_inherit selftest added later in this series found this.
> Its deadlock and max_lock_depth cases cover it.
> Fixes: 6467822b8cc9 ("locking/rtmutex: Prevent spurious EDEADLK return caused by ww_mutexes")
> Cc: stable@vger.kernel.org
> Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
This is the right thing to do. Either my analysis is wrong or the
changelog confusing. I would argue that the full-chainwalk depends now
on a random stack value _and_ __waiter_less() might access the random
value if ww_mutex is enqueued and a regular mutex exists in the lock
chain.
Sebastian
next prev parent reply other threads:[~2026-11-16 13:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-08 14:13 [PATCH v2 0/5] locking/rtmutex: priority inheritance fixes and tests Mathieu Desnoyers
2026-11-08 14:13 ` [PATCH v2 1/5] locking/rtmutex: Stop spinning on the owner when the waiter is woken Mathieu Desnoyers
2026-11-16 12:06 ` Sebastian Andrzej Siewior
2026-11-08 14:13 ` [PATCH v2 2/5] locking/rtmutex: Initialize the ww_mutex context of a waiter Mathieu Desnoyers
2026-11-16 13:58 ` Sebastian Andrzej Siewior [this message]
2026-11-08 14:13 ` [PATCH v2 3/5] locking/rtmutex: Clone the sort keys in rt_mutex_enqueue_pi() Mathieu Desnoyers
2026-11-16 15:11 ` Sebastian Andrzej Siewior
2026-11-08 14:13 ` [PATCH v2 4/5] selftests/futex: Test priority inheritance on PI futexes Mathieu Desnoyers
2026-11-08 14:13 ` [PATCH v2 5/5] locking/ww_mutex/test: Time an ABBA with both owners running Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116135857.5t9HGji5@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=andrealmeid@igalia.com \
--cc=boqun@kernel.org \
--cc=clrkwllms@kernel.org \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=longman@redhat.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®