From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.171.202.116 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794840583; b=Q4hXwoFaYjCkIC6RpyPvkBzgMrP/qtmUAxA47EIhjV6DzEda6md2HnkwEkaLDzpHe3Cf cNaf1E4l/1YSTx8OvgOgkL/QOMMQa1xceNreN8UZuCuBoORqXZIo3BQffBtAXYQIVliEb EtNPHgRtDzf+kiLNkfXi0VF1v3dt/ihd2xMSPdbPC1HFTRSLaJs4p0Np45the7wJLZAHt bZ988+CcLYamVaXkuokd9jGFZInUTqowGOVR4GFWmLQylPlHTcLixch5iOqvol1gfGULL /k8710yRa3SEeXwyPdQOiKgNe8YE8ZkTWJFCJ/3RePgZDrXNZHoWRKdM1bbLSpEYmCg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794840583; h=DMARC-Filter:Received:Received:Received:DKIM-Signature:From:To:Cc: Subject:Date:Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding:X-Last-TLS-Session-Version; bh=etV+RFlcprPmoGZ+0AEdnBPJAYs8L7Hm7FCHjf7YO8U=; b=GyxPdW9hdjTFK2C9Q7O5R5djHrWh4N8RoxSm6TSkMWAhc9NjB9krwCWAuseoLsFXKAxW E8Di4OrgtMpDF5GYbuIQEdFbdkYXg4zeMeeesgQABXgMUwDeQT4CWuHg7Hk9AD++HYv11 YV95UxdNUGc7FxZ6nGNXj7SuT7yhUP54mh0tLqmHYvF02gcWJRxvSoUPeceyDG2yO1bls lqIszd2UnnkNUiv3fKc7eZ9buRa8Koy9QBqaB8PDCshWSdrfmKlKTLZOofOPrHE84kQrY F/kQk7274+niKZd6F5XqTffVmcF1UN6JzM6+JK2XR5U72DBk9/qvv+B6eiDE+AxtODg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=DKPYvOpB; arc=none smtp.remote-ip=185.171.202.116 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CB1B606A323 for ; Mon, 16 Nov 2026 14:49:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 8CB1B606A323 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=dkim header.b=DKPYvOpB Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 48CA1C4EFD7; Mon, 16 Nov 2026 14:49:45 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 4D8E86023F; Mon, 16 Nov 2026 14:49:41 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 3361E11BC1097; Mon, 16 Nov 2026 15:49:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1794840580; h=from:subject:date:message-id:to:cc:mime-version: content-transfer-encoding:in-reply-to:references; bh=etV+RFlcprPmoGZ+0AEdnBPJAYs8L7Hm7FCHjf7YO8U=; b=DKPYvOpBXOQtfktgRYlO3K7T+JkStULarCLWff5BlsTG0CDX8JX5yWSzto3wNt4KlvscVr OGSEFKSLXalsh0tZLnLc1myREz5jCPFE8mADKRwRfJJF1NqtxwLljGkvm4/3ya6QsyXMsl riSn9haGOI/3fubpBMWCImJ1e899JE418geE77yew5hEDc29O3kr24ggoZrBmQCm9TNggK mZiz62ZWXlFbhp7aLp90dKOA+4U3yISOXscywRnE9i9PJpLD6b7Yrb4zXAGAOiC7tpFf/N IgDztHrMGJrab5ewW/lurkjS1elMVtBvaZuGGs36NZv/BdFPi20qzTSg5QS7JA== From: Paul Cercueil To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni , Bharat Bhushan , Sunil Kovvuri Goutham , Tanmay Jagdale , Jisheng Zhang , George Cherian , Witold Sadowski , stable@vger.kernel.org, Paul Cercueil Subject: [PATCH v4 4/7] spi: cadence-xspi: Clear "SDMA ready" IRQ flag after polling Date: Mon, 16 Nov 2026 15:49:07 +0100 Message-ID: <20261116144910.44151-5-paul.cercueil@bootlin.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261116144910.44151-1-paul.cercueil@bootlin.com> References: <20261116144910.44151-1-paul.cercueil@bootlin.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 From: Tanmay Jagdale When polling for the "SDMA ready" event, once the corresponding bit is set in the CDNS_XSPI_SDMA_TRIGGER we should reset it to zero. Otherwise, any subsequent call to cdns_xspi_is_sdma_ready() will just return early. Fixes: 931e389ded0f ("spi: cadence: Add Marvell xfer operation support") Cc: stable@vger.kernel.org Signed-off-by: Tanmay Jagdale Co-developed-by: Paul Cercueil Signed-off-by: Paul Cercueil --- Note that Sashiko complains about it racing vs. the IRQ handler but that's bogus. This function is never called in a code path where IRQs are enabled at the device level. v4: New patch. --- drivers/spi/spi-cadence-xspi.c | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/drivers/spi/spi-cadence-xspi.c b/drivers/spi/spi-cadence-xspi.c index 6c88116f8f0b..4db734b8990d 100644 --- a/drivers/spi/spi-cadence-xspi.c +++ b/drivers/spi/spi-cadence-xspi.c @@ -1104,12 +1104,20 @@ static bool cdns_xspi_is_sdma_ready(struct cdns_xspi_dev *cdns_xspi, bool sleep) { u32 ctrl_stat; - return !readl_relaxed_poll_timeout - (cdns_xspi->iobase + CDNS_XSPI_INTR_STATUS_REG, - ctrl_stat, - (ctrl_stat & CDNS_XSPI_SDMA_TRIGGER), - sleep ? MRVL_XSPI_POLL_DELAY_US : 0, - sleep ? MRVL_XSPI_POLL_TIMEOUT_US : 0); + if (readl_relaxed_poll_timeout + (cdns_xspi->iobase + CDNS_XSPI_INTR_STATUS_REG, + ctrl_stat, + (ctrl_stat & CDNS_XSPI_SDMA_TRIGGER), + sleep ? MRVL_XSPI_POLL_DELAY_US : 0, + sleep ? MRVL_XSPI_POLL_TIMEOUT_US : 0)) { + return false; + } + + /* Clear the flag */ + writel(CDNS_XSPI_SDMA_TRIGGER, + cdns_xspi->iobase + CDNS_XSPI_INTR_STATUS_REG); + + return true; } static int cdns_xspi_transfer_one_message_b0(struct spi_controller *controller, -- 2.47.3