From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.218.53 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794841854; b=0jJ1w0PPX1Si/wX3NM4N+6UAvufl+03JCFb5Rzs1DjaLRZ4v/96zDUR/f5dWvsao70Xq rqCI8op2zBWJOcP+vG1CzOHkKF5Sp2ol0miY3wVP98cSG3Ujne3yZ4XaLArhXPoKIlnrY 17D7gcy2yB3gmQMg4dVqXyePry0BQDdGGV+2o2NuQ8aQPDm1AOYiXlCUycTvFzp/DpkGf UoQxgQvE6xoaVkA8fbYuyyLo4ATtM6uuyy8c6hiIMdMmJUV8DQEz02VA9DNUQ9ogweB4B fTs7rvCKiciBhO2HgfJbYg9wwV/69WXnqWOf3sQp4e8fPHRaur0PN9COsYlSqa85ZPQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794841854; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=3z6P0aYlufuvnlooWGHkbmG4E1HPBYeLov8HTyHzM/I=; b=DIRz0XmIEs+SFc8yFrELHZ4nDiJAYv7pmVVEss+5IcHxftDjiedDOlOyws7IC1HQBIm5 EAYsXb3GhxhLyaRuSkcb1W+HprVcMV75T8VQECxmGxaL1gf0sslz6FqXyxClGkZsGbGIo 3s2tpSEvuGXc2Jydmo3ITvDJcslrI9UR4w3Xuq67ttu+xVCmbaR89/tDavfOwZm3Nzuex 0MFBTUBrtkb7A8iuld01qiQs5pGeIRD7cqb0knutCWrFMeJdxTS5igPKVMNfqoCn4XfM3 vq2clOwnzqZQVUM8QYO8cP/dqQhqYWHzs3mNOts3SKJ5PS1zfJzALJp6zyIVvzElspA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=HNMo3ME4; arc=none smtp.remote-ip=209.85.218.53 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25343606A896 for ; Mon, 16 Nov 2026 15:10:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 25343606A896 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=HNMo3ME4 Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-c4d427836e9so470079566b.1 for ; Mon, 16 Nov 2026 07:10:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794841852; x=1795446652; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3z6P0aYlufuvnlooWGHkbmG4E1HPBYeLov8HTyHzM/I=; b=HNMo3ME48Cp69TMDdUcMT8gRRbVDtFtLfzuaUUXVp+363GiL0Jr5A7fmdD2Gh8sFBL av+ntTf1MtChIIz0dO2ZGk/eu9AiEZStTlM4xZ4OpLz/aFzEiDtyPqdVxpSg1mVv1wO5 E01JwKTLqAVm5a2spO8XxVjg6opybrYgkWZ/bsLCLfvcHIr6AgknOjre2EHnRx9LwuIF 8Ae+ZVm7dIDoTeYmDlVW/bti7P+uXtU4YI1ysY1TbdPtE2xJpMmxvnNdxGqwwTCaxXl7 r4RZIKj38g6AJDXshpIVZyOgo801qcz/WOQuxI2O+38wq92PQTFnUks/6rUGe1X8s9/P +wVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794841852; x=1795446652; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=3z6P0aYlufuvnlooWGHkbmG4E1HPBYeLov8HTyHzM/I=; b=c/EvVaKzUyMbGwM7v9QsRpvZbS7ubrtar0ttPynBQwHaJMwwJKI6xd6WZTJ0fBXaSe faJNbJGxEyTMbLjXTyOZgCHNmb2xFhfHO1eqyZZznPZflcXXtJnIHuZTmdHVU7p6y26a JmZzL6B3vq7WfxUyWLsWdWMwPuytK74mOv1EXIGY7LJ9LrbF6dxpiQN4PYvsJ3AwY8gR DJntVuJhANmVosa5TaimAiTrtbPkBS40lqXOHOHhb/AOW2rV8lFpfw6Qa20a+NSdLEgE Nj2XRNcuVKNOubiwAEzEEo0WbAEU5/Q875brMjqJD/mey0NcIVHHpGUTq/IbocpyDhkf X/Tg== X-Forwarded-Encrypted: i=1; AL+hErGCxzcySFqaYXyFeY2esbLqGuV9X87Bq0Z9uPX1POghfQvCABKSZy1y+gXa0mvykZafh7mYXwAurZe6HJ8=@vger.kernel.org X-Gm-Message-State: APuU4Z+LRi4vQj0dZfdaqr+WU6dOKMC/j8VLtB1IjPCw4ugutaqx9b69 BJPNY2t0NQKDs2tVpnsMWCspjNGfHvZrVP/xDsPJyhJUsRPbfGta/9S2 X-Gm-Gg: AYBFou1mp4bawQj8WNvLj7T4AEJAOy57rqFxiq65PHsRMgcvg8QbZFtdsgUcljbVd+i a8/Y9sp3M6v6faFK/EdX9Pz/xnq+V85ZlXC1Z8SszoBMXoyysYBE/h1GDVHJvFoh0mwR4ko8+7o N5dplFyS7pWZ7fFcCX/cQlp1qS4AMdhHrE2aRdC/1aVef0uZgtZThte05Azlm6cig6+WXpqIzap gUEuIrV/ZOj6okC+Cu2lkWXCa9TD99sTCCU39izIMvX/2euLYgZDV+mleH7EC/JY1FpF3HxyHCj OCwYKZEbHNIdwXXE0SxlPMeWhuteOTvwgJLT1+Z2Ow9FTuAdjf3zRlhj3HMqr/KKUQR3QjvF8DA 0D4edFoZ482eXtoa4WisQPxWT+twQErOFcC4w9G98WN4JYKsouuUlxzUhBojjLpmuaFfpDoZpP5 hJIrLynh7CWOV74z8Q3F1onyIeRmLzI+LkzWQbQmKAHd7BeNktc78PibbbUFhZDlIpgDZc1aOXr LmPyuwYriq3cyuClBvfkRzAdYbHq54ABwzrvlSBpUpv5Us6a0lWNcQ+8X3c7La7/89q+QcKxyUi vktVizsycRYn2WXGWYPOtq4kP0cXe467TiwB+Yw+7OiO9lNAqem+GboLxkdgj2TVSVLE+Yg6HE7 2WMfRaHAPBw== X-Received: by 2002:a17:907:3ccc:b0:c49:a235:8e0c with SMTP id a640c23a62f3a-c509637e31dmr872386066b.22.1794841852361; Mon, 16 Nov 2026 07:10:52 -0800 (PST) Received: from xeon ([188.163.112.62]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c5095b93a85sm420868466b.84.2026.11.16.07.10.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 07:10:51 -0800 (PST) From: Svyatoslav Ryhel To: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Jonathan Hunter , Neil Armstrong , Jessica Zhang , Mikko Perttunen , Svyatoslav Ryhel Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 10/12] drm/tegra: rgb: Parameterize configuration based on bus flags Date: Mon, 16 Nov 2026 17:10:15 +0200 Message-ID: <20261116151017.274764-11-clamor95@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261116151017.274764-1-clamor95@gmail.com> References: <20261116151017.274764-1-clamor95@gmail.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Parameterize configuration based on bus flags passed from the bridge or panel. The list of supported flags includes now pixel clock polarity, display enable (DE) polarity, and data alignment. Signed-off-by: Svyatoslav Ryhel --- drivers/gpu/drm/tegra/rgb.c | 39 +++++++++++++++++++++++++++++++++---- 1 file changed, 35 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tegra/rgb.c b/drivers/gpu/drm/tegra/rgb.c index d48d498068ac8..faecd6f94359f 100644 --- a/drivers/gpu/drm/tegra/rgb.c +++ b/drivers/gpu/drm/tegra/rgb.c @@ -5,6 +5,7 @@ */ #include +#include #include #include @@ -106,6 +107,7 @@ static void tegra_rgb_encoder_enable(struct drm_encoder *encoder, struct tegra_output *output = encoder_to_output(encoder); struct tegra_rgb *rgb = to_rgb(output); struct drm_connector_state *conn_state; + struct drm_bridge_state *bridge_state; struct drm_crtc_state *crtc_state; struct drm_connector *connector; struct drm_display_mode *mode; @@ -117,12 +119,21 @@ static void tegra_rgb_encoder_enable(struct drm_encoder *encoder, crtc_state = drm_atomic_get_new_crtc_state(state, conn_state->crtc); mode = &crtc_state->adjusted_mode; + /* Get but flags from the bridge state. */ + bridge_state = drm_atomic_get_new_bridge_state(state, output->bridge); + if (bridge_state) + bus_flags = bridge_state->input_bus_cfg.flags; + else + bus_flags = DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE | + DRM_BUS_FLAG_DE_HIGH | + DRM_BUS_FLAG_DATA_MSB_TO_LSB; + tegra_dc_write_regs(rgb->dc, rgb_enable, ARRAY_SIZE(rgb_enable)); value = DE_SELECT_ACTIVE | DE_CONTROL_NORMAL; tegra_dc_writel(rgb->dc, value, DC_DISP_DATA_ENABLE_OPTIONS); - /* configure H- and V-sync signal polarities */ + /* configure H- and V-sync and pixel clock signal polarities */ value = tegra_dc_readl(rgb->dc, DC_COM_PIN_OUTPUT_POLARITY(1)); if (mode->flags & DRM_MODE_FLAG_NHSYNC) @@ -135,11 +146,31 @@ static void tegra_rgb_encoder_enable(struct drm_encoder *encoder, else value &= ~LVS_OUTPUT_POLARITY_LOW; + if (bus_flags & DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE) + value &= ~BIT(PIN_LSC0); + else + value |= BIT(PIN_LSC0); + tegra_dc_writel(rgb->dc, value, DC_COM_PIN_OUTPUT_POLARITY(1)); - /* XXX: parameterize? */ - value = DISP_DATA_FORMAT_DF1P1C | DISP_ALIGNMENT_MSB | - DISP_ORDER_RED_BLUE; + /* configure DE signal polarities */ + value = tegra_dc_readl(rgb->dc, DC_COM_PIN_OUTPUT_POLARITY(3)); + + if (bus_flags & DRM_BUS_FLAG_DE_LOW) + value |= BIT(PIN_LSPI); + else + value &= ~BIT(PIN_LSPI); + + tegra_dc_writel(rgb->dc, value, DC_COM_PIN_OUTPUT_POLARITY(3)); + + /* configure DATA order and alignment */ + value = DISP_DATA_FORMAT_DF1P1C | DISP_ORDER_RED_BLUE; + + if (bus_flags & DRM_BUS_FLAG_DATA_LSB_TO_MSB) + value |= DISP_ALIGNMENT_LSB; + else + value &= ~DISP_ALIGNMENT_LSB; + tegra_dc_writel(rgb->dc, value, DC_DISP_DISP_INTERFACE_CONTROL); tegra_dc_commit(rgb->dc); -- 2.53.0