mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: koraynilay <koray.fra@gmail.com>
To: Namjae Jeon <linkinjeon@kernel.org>, Paulo Alcantara <pc@manguebit.org>
Cc: Tom Talpey <tom@talpey.com>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	Shyam Prasad N <sprasad@microsoft.com>,
	Bharath SM <bharathsm@microsoft.com>,
	Aurelien Aptel <aaptel@suse.com>,
	linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
	koraynilay <koray.fra@gmail.com>,
	Sashiko <sashiko-bot@kernel.org>
Subject: [PATCH] cifs: fix times assignments in cifs_posix_to_fattr()
Date: Mon, 16 Nov 2026 16:45:26 +0100	[thread overview]
Message-ID: <20261116154526.429315-1-koray.fra@gmail.com> (raw)

Currently cifs_posix_to_fattr() wrongly sets SMB's CreationTime to
fattr->cf_ctime.

Fix this by setting fattr->cf_createtime to SMB's CreationTime and
fattr->cf_ctime to SMB's ChangeTime, matching the behaviour of
__dir_info_to_fattr().

This patch also fixes a few related issues reported by sashiko on
another patch (see Sashiko Link tag).

Reproducers for these bugs, with /tmp as the local filesystem folder
exported as [test] in ksmbd.conf and /mnt as the smb folder mounted with
mount -t cifs:

  mount -t cifs //127.0.0.1/test /mnt -o username=ciao,password=c,posix

Issue 1: ctime clobbered by CreationTime during readdir

  mkdir -p /mnt/dir
  touch /mnt/dir/file
  sleep 4
  chmod 644 /mnt/dir/file
  stat -c "ctime and btime before readdir: %Z %W" /mnt/dir/file
  ls -lc /mnt/dir > /dev/null
  stat -c "ctime and btime after readdir:  %Z %W" /mnt/dir/file
  stat -c "ctime and btime on disk:        %Z %W" /tmp/dir/file

output before the fix, notice how ctime is the same as btime after the
readdir, while it's 4 seconds ahead (because of the sleep 4) before the
readdir (on disk timestamps are not touched):

  ctime and btime before readdir: 1794842068 1794842064
  ctime and btime after readdir:  1794842064 1794842064

  ctime and btime on disk:        1794842068 1794842064

output after the fix:

  ctime and btime before readdir: 1794842908 1794842904
  ctime and btime after readdir:  1794842908 1794842904

  ctime and btime on disk:        1794842908 1794842904

Issue 2: btime and ptime wiped out by readdir

[ no reproducer as it only happens after the linked patch series is
  applied, since it needs cifs_i->createtime = fattr->cf_createtime in
  cifs_fattr_to_inode() ]

Issue 3: in-memory inode aliasing (flock bypass on hardlink via readdir)

  mkdir -p /mnt/dir1 /mnt/dir2
  echo "test" > /mnt/dir1/h1
  ln /mnt/dir1/h1 /mnt/dir2/h2
  exec 3< /mnt/dir1/h1
  flock -x -n 3 # get exclusive lock
  ls /mnt/dir2 > /dev/null
  exec 4< /mnt/dir2/h2
  flock -x -n 4
  if [ $? -eq 0 ];then
  	echo "acquired: duplicate in-memory inode"
  else
  	echo "blocked: same inode"
  fi

output before the fix:

  acquired: duplicate in-memory inode

output after the fix:

  blocked: same inode

Fixes: 3d519bd1269f ("cifs: plumb smb2 POSIX dir enumeration")
Cc: stable@vger.kernel.org
Reported-by: Sashiko <sashiko-bot@kernel.org>
Link: https://sashiko.dev/#/patchset/20261115180343.576773-1-koray.fra%40gmail.com?part=10
Link: https://lore.kernel.org/all/20261115180343.576773-11-koray.fra@gmail.com/
Assisted-by: Gemini:3.8-flash-high antigravity-cli-1.5.7
Signed-off-by: koraynilay <koray.fra@gmail.com>
---
Thanks,
koraynilay

 fs/smb/client/readdir.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/smb/client/readdir.c b/fs/smb/client/readdir.c
index 525f99181485..5d335f12eb24 100644
--- a/fs/smb/client/readdir.c
+++ b/fs/smb/client/readdir.c
@@ -253,9 +253,10 @@ cifs_posix_to_fattr(struct cifs_fattr *fattr, struct smb2_posix_info *info,
 	fattr->cf_bytes = le64_to_cpu(info->AllocationSize);
 	fattr->cf_eof = le64_to_cpu(info->EndOfFile);
 
+	fattr->cf_createtime = le64_to_cpu(info->CreationTime);
 	fattr->cf_atime = cifs_NTtimeToUnix(info->LastAccessTime);
 	fattr->cf_mtime = cifs_NTtimeToUnix(info->LastWriteTime);
-	fattr->cf_ctime = cifs_NTtimeToUnix(info->CreationTime);
+	fattr->cf_ctime = cifs_NTtimeToUnix(info->ChangeTime);
 
 	fattr->cf_nlink = le32_to_cpu(info->HardLinks);
 	fattr->cf_cifsattrs = le32_to_cpu(info->DosAttributes);

base-commit: 9928f403dfafd17dfe45678bbc6f623f72528744
prerequisite-patch-id: 049ae0eba275b5be35a238833107e0b251a55aa2
-- 
2.56.0


                 reply	other threads:[~2026-11-16 15:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116154526.429315-1-koray.fra@gmail.com \
    --to=koray.fra@gmail.com \
    --cc=aaptel@suse.com \
    --cc=bharathsm@microsoft.com \
    --cc=linkinjeon@kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pc@manguebit.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=sashiko-bot@kernel.org \
    --cc=sprasad@microsoft.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®