From: "David Härdeman" <david@hardeman.nu>
To: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Cc: "Emmanuel Grumbach" <emmanuel.grumbach@intel.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
"David Härdeman" <david@hardeman.nu>
Subject: [PATCH 0/2] wifi: iwlwifi: release frames before one beyond the reorder window
Date: Mon, 16 Nov 2026 16:56:07 +0100 [thread overview]
Message-ID: <20261116155609.535595-1-david@hardeman.nu> (raw)
An AP that gives up on an MPDU of a BA session without sending a BAR
and keeps transmitting will eventually send a frame with SN ==
head_sn + buf_size. Both iwlmvm and iwlmld store that frame in the slot
of head_sn and then release it ahead of the frames before it, which
all fail the PN check. A single lost MPDU becomes a burst of up to 63
dropped frames, i.e. a TCP loss burst.
I ran into this with an AX210 (iwlmvm) on an rtw88 SDIO AP (RTL8822CS)
that drops frames without a BAR while the client is off-channel for
background scans; the AP side is a separate problem. A kprobe at the
PN check showed every burst starting with the frame at hole + 64.
Patch 1 restores the window check that iwlmvm had before the reorder
buffer was simplified. Tested on 7.2.15 (same code): PN-replay drops
per client scan went from about 280 to about 12, and in normal use
(8 two-minute bidirectional TCP runs each) from 290 to 3 per run.
Patch 2 does the same for iwlmld, which has the same code. I have no
iwlmld hardware; it adds a KUnit case that fails without the fix and
passes with it.
The patches were generated with the help of an LLM; I have reviewed
them (to the best of my ability), and tested patch 1 on actual hardware
as described above (patch 2 only with the KUnit case).
David Härdeman (2):
wifi: iwlwifi: mvm: release frames before one beyond the window
wifi: iwlwifi: mld: release frames before one beyond the window
drivers/net/wireless/intel/iwlwifi/mld/agg.c | 14 ++++++++++
.../wireless/intel/iwlwifi/mld/tests/agg.c | 28 +++++++++++++++++++
drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c | 13 +++++++++
3 files changed, 55 insertions(+)
base-commit: 3627924ed81fd7783394fb2555ea179c6606a231
--
2.47.3
next reply other threads:[~2026-11-16 15:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 15:56 David Härdeman [this message]
2026-11-16 15:56 ` [PATCH 1/2] wifi: iwlwifi: mvm: release frames before one beyond the window David Härdeman
2026-11-16 15:56 ` [PATCH 2/2] wifi: iwlwifi: mld: " David Härdeman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116155609.535595-1-david@hardeman.nu \
--to=david@hardeman.nu \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®