From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=205.220.180.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794846166; b=aaC7jBsySJhdv4M7WKc8ZMb9Z2AYUFFt5p7o0R/CmMJdjLqnpifwgRr5mmcA/3c7x/sR T7NUjileDyYtE0X8z/P4QAsLocOHklBDukA3/8rb1ISx3IgEliE4oCMISmsdBrXpnohhp rKubFvxkohtdjjphcYKwEX2/GEC6T7pvzQj1KbapfIAWwFVV+H3dRIJ877COmOKwWBGUG djckKIuP59yDFMQgcOhpxLzywviRpK/BAu/ndcvK5iGSk8LAhOOb8lv5mP7Aj8PAeLNxw KHBLV8vOrb/N8KJWoX5NUg9bviA9L4GiA9dnYTyaUQwoXjz6czKRupk6JaBCj0o2nhA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794846166; h=DMARC-Filter:Received:DKIM-Signature:Received:Received: DKIM-Signature:X-Google-DKIM-Signature:X-Forwarded-Encrypted: X-Gm-Message-State:X-Gm-Gg:X-Received:X-Received:Received:From:To:Cc: Subject:Date:Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding:X-Authority-Analysis:X-Proofpoint-Spam-Info: X-Proofpoint-Spam-Details-Enc:X-Proofpoint-GUID: X-Proofpoint-ORIG-GUID:X-Proofpoint-Virus-Version: X-Proofpoint-Spam-Details; bh=7/5IBT6uyH8wqYvt8xbeed+YTnT5UfX4kyDmhIwv65c=; b=2CqBQBbbesHrRJ7wofPIEFkODaNREM+TjsgiEgs2gXrODY9StPUKSSwWnCkdH6Ytw7SK fI1vU6BWJAH/8dgjNSBANNU8YCMJ0/E60LuH/sVGd2kkbTg7j68TfsNNLGH6iMglSC96I 9EKJufqcJR0550H7lwlqnEtsPQ7xZP0g6Rg32reaINjhSCEQz69hNDvpp4AHhNIyOd+IJ w0GFTqUHQepplY1ncvO4tXnVu6xU1bIREYi/Q6jg/ObavZAfyPkAULhe/fK5anVNXM53S i/ceU5v2rj0JykhYzJJmWq0YFix9I9AQk7mJhEdoV87p28Cw2VzzgFzh1JhhWnDy92Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=ImKUP3Xz; dkim=pass header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=GXIiAeH4; arc=none smtp.remote-ip=205.220.180.131 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0E40606A332 for ; Mon, 16 Nov 2026 16:22:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C0E40606A332 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256 header.s=qcppdkim1 header.b=ImKUP3Xz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.a=rsa-sha256 header.s=google header.b=GXIiAeH4 Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6AGGIGBV2126178 for ; Mon, 16 Nov 2026 16:22:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=7/5IBT6uyH8 wqYvt8xbeed+YTnT5UfX4kyDmhIwv65c=; b=ImKUP3XzzkcWGQBIHDld29kSpW1 3G0uJ7xw4IKj6KnrhZDSfB9JFndd77V8uovcWSGwnRjYp6meXxZoJBI50ayEkCIh I330kLlI+/Ar3WA9eAymEYIX5A/kqaKYXMhTce83OnuGUbV62i7e5GZ7CKjqm7aK QF8Pn+N1ZojmqzzYyrfv/WTtBipZJUibUu/LVq72U5a0PnScjI1uzPbuh7NmL4o9 B8ItKnCP9ocyMAghENDK6IwB1R6i4ADTkilLUnXEeH+jN+LYIeIb2Lc6KproX9NV 2VR/aeYO4AzSy0m95rDre8ROZELsYzIzCRFwC+uWejLqZtliMUhFFFdJEew== Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4hyxx2hnsn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 16 Nov 2026 16:22:44 +0000 (GMT) Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-375f0fd31f4so2108411eec.0 for ; Mon, 16 Nov 2026 08:22:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1794846164; x=1795450964; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7/5IBT6uyH8wqYvt8xbeed+YTnT5UfX4kyDmhIwv65c=; b=GXIiAeH4pT5S8uS7+eaez0TFEDJmyrXdkKnYDdfFce8rjC1+aWr02YDpgHHI4iQYQN xlcArqaDQl3xI1BfYtu8EOy49MM3N4wfjxOWgsu1mE1ToXpSf9VYUNtKQZMIXWeT1TMM O+F86OvmE/1KarMTyYqQq86NgmA7cCBBcBGcQRNBm/ccjt5RTbc7cdmuXwCWiGiaCxep 3pSkB6oY9IONKhGXnt/y+qPMnU3u9kS2tdIlF0Tz1JqhUvejNYmxsHRCyNAsGozq0SsH 4JHOmI4WVXBi9U/bRWTg25YU2JpEBr4Z4168khymP2uJMaXy+t7h4BCNPPQyu/jswjvr UNZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794846164; x=1795450964; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=7/5IBT6uyH8wqYvt8xbeed+YTnT5UfX4kyDmhIwv65c=; b=T30uwQXNkJD+QLaVxSk2QzH7+MVfO+CE3nFV49g6rKCtqSjhoYQOJ9hJ172Hghyk9J pIOjCaVx6qs/LAUA3S7YuTfkoNGVq3u5TQpuIKTkXEAu4AvzZLNJRRnuqSx923LvhpT0 xEpUsyan6mFNEoowcMXT+DoGnJ3kirbrd/oDS29fsEZ1ZX2RR10sH4pckNaMrweVYGfN 8hfN+FTIkX1wrGNw+SzVtPxsPzwBl6LrLv3ci9ETZHO/ko0fI2zePkXduDW/sETBej5O Qk/Lyael8bIMg6iwqvYWiJ6y1r2v4DdjgwEf4Xro7xCO8Bo7FBU4UpfvKqtc/zc1E8KU RKgg== X-Forwarded-Encrypted: i=1; AL+hErH4/EymP8bevF8I1E3x3uGmUoFXG8CVtmdje5mvRcYVs2dW1o2wd3hH692AHMHGMLeWLoMQ3SJSpAUTkIQ=@vger.kernel.org X-Gm-Message-State: APuU4Z8anZbCXn/GIVVcIS47U0lV9TMNcO3wupPEY/sLrOSKinHcvfRo hJEjg6+88UhU202Lt2AT0Bb3fTvd+6nb8qFqhGYbzC+tfzIpAfjx1KR8cB0aoAUseMV8wY4D90G Xt/DwyC/fTMugE2HZFzDiG27Aw1EuL/pU6Getk0VW5Aa/Q3tmINLsvhbG+JvAoQxck40= X-Gm-Gg: AYBFou3QowLRd4Uq3uUfHl57e3kan7kwtG7h/oEmozKg6SNBwxMRAtXx/XdSI07CgQX XdClmSoRrbPcqEJYhIoc0b46EdBdKg9ysdO4YU5OotJ0ZvebeSEq1VEla7XcugHyqexdoJuYxiE 3fdGDY+hq2+9BFOYZ5qU7QCFU4IKF4wdbuFYqZiAjhTvmYHMUR1gUKJqVmu7BQf/Mq4/xYGIwS/ KeHAJhQ/t7r+KYX+BFAAZB9jb/V43UEs0QCk+C1pzTKpfZvYE4r53jDKcRkT+vR7A+dM/UrQknU 0xNiuvZpqQZAg0aRtphIj35axIxkxjEcGxdwSDozzaxkRDKdemu/JBA+1BOYy+WUvyMugg63Udb GZpbQviOCxmTeFjBQmc1ItpPyb8twXGsjFJ6E8aBOb8+5gTPZqQN1oxzs+0F3N7tsjyq+YgQIVN 7+ X-Received: by 2002:a05:7022:2594:b0:1b4:caae:3324 with SMTP id a92af1059eb24-1b5030ad1d8mr12473119c88.21.1794846163594; Mon, 16 Nov 2026 08:22:43 -0800 (PST) X-Received: by 2002:a05:7022:2594:b0:1b4:caae:3324 with SMTP id a92af1059eb24-1b5030ad1d8mr12473081c88.21.1794846163018; Mon, 16 Nov 2026 08:22:43 -0800 (PST) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1b5031468b7sm38623826c88.5.2026.11.16.08.22.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 08:22:42 -0800 (PST) From: Mukesh Ojha To: Sumit Garg , Bjorn Andersson , Konrad Dybcio , Rob Clark , Dmitry Baryshkov , David Airlie , Simona Vetter , Vikash Garodia , Dikshita Agarwal , "Bryan O'Donoghue" , Mauro Carvalho Chehab , Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jeff Johnson , Mathieu Poirier Cc: Abel Vesa , Sean Paul , Akhil P Oommen , Abhinav Kumar , Jessica Zhang , Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-remoteproc@vger.kernel.org, Mukesh Ojha Subject: [PATCH v3 4/9] media: iris: migrate firmware loading to qcom_mdt_pas_load() and qcom_pas_prepare_and_auth_reset() Date: Mon, 16 Nov 2026 21:51:43 +0530 Message-ID: <20261116162148.2864501-5-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261116162148.2864501-1-mukesh.ojha@oss.qualcomm.com> References: <20261116162148.2864501-1-mukesh.ojha@oss.qualcomm.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=R7WWitRX c=1 sm=1 tr=0 ts=6afb2dd4 cx=c_pps a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=zJRp6_cAMcgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=0taKFLn-hLWpjNWZEgwA:9 a=bBxd6f-gb0O0v-kibOvt:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMTE2MDA2NCBTYWx0ZWRfX6EnoPe+IGvFl tLTeXVFLi4lNbkGRc7361MUeDaki48Sen1zeYBpAnC99ZOUriDHGeZnFl0mJB9ZJWAKzsH73FA5 W9yCcjDoFZu/5Vctqw1Fgeglxfj5FpM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMTE2MDA2NCBTYWx0ZWRfX2arDsL9aZtjP CiwThcIdSI5Bj9LWEa2qxAcz4Z6tMujrk54xs8zwzHGKhOtMnaEvtDM3VvgOmcPLsD7X14uNDWP p1nqCSldfjM2Hfb5KZD5dIYRGGhOLahljmC63bR1d1mV43NHU0syl870fU0dyzzGDgYbrUAsiJC D232OU7xg28xGphMElLd1GYtQSuvhpVdBF86kf2/zzxW1H0yCvCv4N5kMBGD4bUgyu9vIHwmP/M 2xO/em/b6LSN8uqisYXC4xCout4xI2kBfLCQjx1E9U3553a7Mc343gHnKzBIUuvX/qNXRZTMDi7 imFk6w1sDJ3E4mG1vUhv88eJdtk9g17TW3NlLlaig9vQfeshUPvEPTfRsN55JfZxlnXE/XM7ZV9 sgv+HpRfwCl+APyjz2d1LgjecOdL/D64f1dmTUt8PJO9UHYHPsHmuh+QbxC17bTc/Td/QHExk35 c6qqOBawSqcBPgr8Dwg== X-Proofpoint-GUID: 6eXKWcECT9AtDJGWuwPyZcUxVEgBbrh1 X-Proofpoint-ORIG-GUID: 6eXKWcECT9AtDJGWuwPyZcUxVEgBbrh1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.138,FMLib:17.12.100.49 definitions=2026-11-16_05,2026-11-16_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 phishscore=0 adultscore=0 bulkscore=0 malwarescore=0 suspectscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2611040001 definitions=main-2611160064 iris_load_fw_to_memory() calls qcom_mdt_load(), which bundles metadata initialization, memory setup, and segment loading into a single API that does not expose a PAS context. iris_fw_load() calls qcom_pas_auth_and_reset() for TrustZone authentication, which is the intended behaviour. However, a new qcom_mdt_pas_load() has recently been introduced that works with a PAS context and can handle everything qcom_mdt_load() provides, along with additional functionality such as shmbridge creation and retrieving memory from the shmbridge buffer when the same remote processor needs to run while Linux runs at EL2. Embed a struct qcom_pas_context directly in struct iris_core and initialize it with qcom_pas_context_init() inside iris_load_fw_to_memory() on each call. Replace qcom_mdt_load() with qcom_mdt_pas_load() and replace qcom_pas_auth_and_reset() with qcom_pas_prepare_and_auth_reset(). The iris_detect_firmware() scan retains a separate memremap window after qcom_mdt_pas_load() completes, since it needs to read back the loaded image data. Signed-off-by: Mukesh Ojha --- drivers/media/platform/qcom/iris/iris_core.h | 2 ++ .../media/platform/qcom/iris/iris_firmware.c | 27 +++++++++---------- 2 files changed, 15 insertions(+), 14 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_core.h b/drivers/media/platform/qcom/iris/iris_core.h index 3e4cf652bf39..ac73bda072f8 100644 --- a/drivers/media/platform/qcom/iris/iris_core.h +++ b/drivers/media/platform/qcom/iris/iris_core.h @@ -9,6 +9,7 @@ #include #include #include +#include #include #include "iris_hfi_common.h" @@ -129,6 +130,7 @@ struct iris_core { struct platform_inst_fw_cap inst_fw_caps_dec[INST_FW_CAP_MAX]; struct platform_inst_fw_cap inst_fw_caps_enc[INST_FW_CAP_MAX]; struct dma_iova_state *iova_state; + struct qcom_pas_context pas_ctx; }; int iris_core_init(struct iris_core *core); diff --git a/drivers/media/platform/qcom/iris/iris_firmware.c b/drivers/media/platform/qcom/iris/iris_firmware.c index 21f57d37da18..b701a7f43514 100644 --- a/drivers/media/platform/qcom/iris/iris_firmware.c +++ b/drivers/media/platform/qcom/iris/iris_firmware.c @@ -201,21 +201,20 @@ static int iris_load_fw_to_memory(struct iris_core *core) goto err_release_fw; } - mem_virt = memremap(mem_phys, res_size, MEMREMAP_WC); - if (!mem_virt) { - ret = -ENOMEM; - goto err_release_fw; - } - - memset(mem_virt, 0, res_size); - - ret = qcom_mdt_load(dev, firmware, fw_name, - IRIS_PAS_ID, mem_virt, mem_phys, res_size, NULL); + qcom_pas_context_init(&core->pas_ctx, dev, IRIS_PAS_ID, mem_phys, + res_size); + + ret = qcom_mdt_pas_load(&core->pas_ctx, firmware, fw_name, NULL); + if (!ret) { + mem_virt = memremap(mem_phys, res_size, MEMREMAP_WC); + if (!mem_virt) { + ret = -ENOMEM; + goto err_release_fw; + } - if (!ret) iris_detect_firmware(core, fw_name, mem_virt, res_size, desc); - - memunmap(mem_virt); + memunmap(mem_virt); + } err_release_fw: release_firmware(firmware); @@ -233,7 +232,7 @@ int iris_fw_load(struct iris_core *core) return ret; } - ret = qcom_pas_auth_and_reset(IRIS_PAS_ID); + ret = qcom_pas_prepare_and_auth_reset(&core->pas_ctx); if (ret) { dev_err(core->dev, "auth and reset failed: %d\n", ret); return ret; -- 2.55.0