From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=217.194.8.81 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794846258; b=25Ybj0jzFwf+VnqhvmPg+IKZJ5JtjM3DL7E2xD0+1w/b+N/uS4pLmRWVySD+EcTIvtGb lDUF6iDB529gRyTQyTEK2NV5ywfJI48OnSgV5ug35IS5p6O147KkyGwVkaaBxAWzT208E OLhxGo+b9XVv51fntX2cFAEyEWNjcEyy4pXS/AuwLQIJoAzsOb48Zg8A23al4F/4SJDUg 2bqbvC3htLODQogeTOlXQOxIUd8agONVE0VmgYVHQQKd8677ui25sfIOyCh7NUhCJ4cQe Fbiiy7eK9xYshAvzLKF4sDwBo+EGyIiHQOx+RyaRgj6ephxRKfOqKhUzQ6mC8SEuzQg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794846258; h=DMARC-Filter:Received:DKIM-Signature:From:To:Cc:Subject:Date: Message-ID:X-Mailer:MIME-Version:Content-Transfer-Encoding; bh=KNMrpE0c4t3yHoCPTNayHPyVehFylomG/8Vd0gBrhoM=; b=Xv+R4ygMgRZuQmaHSe3AtSUA9fRfvKm1yyHgL1WIRCVQ7sc5lNojXzRa36B9KJs23YLR sIkS1BPM0xLmsiayb+Pwp8EGqK/Zz+MFYiWK6Wi9aCGlMEdBPVC8hPV40rsdhCuYk0fua 6qROK3mRwuQe8e1Zcd6SWBi6G2nNup/4MQoD043L8+Zaj3NIF2Fd5kC4ePONfx1IDUD4x O12AK1QnfE6iYt1ELUGdoQhtwravf/BPJlfVmFeXpaAJbSaD4UapS1bBNNYFPLbo5APoa YCcKJUOlPOcc6N5sgTaPbLCxyRxcnF+jgUAmm7rQZ6ZJB35s2D3SwlcdHuxReTAMK5Q== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=dolcini.it; spf=pass smtp.mailfrom=dolcini.it; dkim=pass header.d=dolcini.it header.i=@dolcini.it header.a=rsa-sha256 header.s=default header.b=uHKupJ25; arc=none smtp.remote-ip=217.194.8.81 Received: from mail11.truemail.it (mail11.truemail.it [217.194.8.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8342B606A323 for ; Mon, 16 Nov 2026 16:24:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 8342B606A323 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=dolcini.it Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dolcini.it Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=dolcini.it header.i=@dolcini.it header.a=rsa-sha256 header.s=default header.b=uHKupJ25 Received: from francesco-nb.. (93-45-146-107.ip102.fastwebnet.it [93.45.146.107]) by mail11.truemail.it (Postfix) with ESMTPA id 67299221F8; Mon, 16 Nov 2026 17:24:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dolcini.it; s=default; t=1794846255; bh=KNMrpE0c4t3yHoCPTNayHPyVehFylomG/8Vd0gBrhoM=; h=From:To:Subject; b=uHKupJ25Lyucg3iduvRru64ARqjufAfVMbrCa5ZzLcCA3RSXYoY+vVTi8yM9INd5Q SeMpFTCoe5qxjn6NExt85CjxjJtqM+8HmiDvbKw8A84wI5Milfm4Lt3l1bbPs5jtRd yjtfCC0X3giJ1/Z4TfVq5HChOKm3rO6wbUA4si4wJcPJgdQpZWKAeQAR+yjB+0YOWd 6AWc9UCfXeK1XUNujE340vX+09qFa3skdZrDFhQlwCxlmUfhdNqwbRRx7pHYBTi7x2 Th0NCNcNqdgdBqx3Dy6gsj3NRQ91GTHzvIXmiElYuhqFpNG43PG/btYREJP7XaP6nR JzeS544h14uyA== From: Francesco Dolcini To: Vinod Koul , Neil Armstrong , Manivannan Sadhasivam Cc: Francesco Dolcini , linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Alexander Stein Subject: [PATCH v1] Revert "phy: freescale: fsl-samsung-hdmi: initialize default rate" Date: Mon, 16 Nov 2026 17:24:08 +0100 Message-ID: <20261116162409.218059-1-francesco@dolcini.it> X-Mailer: git-send-email 2.47.3 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Francesco Dolcini This reverts commit c01ccf91b257741e9edc374a465126bae9ae4711. Programming the 74.25 MHz configuration at probe fails on i.MX8MP boards, the PHY probe aborts and HDMI is no longer available: fsl-samsung-hdmi-phy 32fdff00.phy: PLL failed to lock fsl-samsung-hdmi-phy 32fdff00.phy: error -ETIMEDOUT: failed to configure default rate fsl-samsung-hdmi-phy 32fdff00.phy: probe with driver fsl-samsung-hdmi-phy failed with error -110 Reported-by: Alexander Stein Closes: https://lore.kernel.org/all/13219248.O9o76ZdvQC@steina-w/ Fixes: c01ccf91b257 ("phy: freescale: fsl-samsung-hdmi: initialize default rate") Signed-off-by: Francesco Dolcini --- drivers/phy/freescale/phy-fsl-samsung-hdmi.c | 59 +++++--------------- 1 file changed, 15 insertions(+), 44 deletions(-) diff --git a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c index aaa651abcbc6..d7418c2197c9 100644 --- a/drivers/phy/freescale/phy-fsl-samsung-hdmi.c +++ b/drivers/phy/freescale/phy-fsl-samsung-hdmi.c @@ -44,8 +44,6 @@ #define MHZ (1000UL * 1000UL) #endif -#define PHY_DEFAULT_RATE 74250000 - #define PHY_PLL_DIV_REGS_NUM 7 struct phy_config { @@ -491,6 +489,17 @@ static int fsl_samsung_hdmi_phy_configure(struct fsl_samsung_hdmi_phy *phy, return ret; } +static unsigned long phy_clk_recalc_rate(struct clk_hw *hw, + unsigned long parent_rate) +{ + struct fsl_samsung_hdmi_phy *phy = to_fsl_samsung_hdmi_phy(hw); + + if (!phy->cur_cfg) + return 74250000; + + return phy->cur_cfg->pixclk; +} + /* Helper function to lookup the available fractional-divider rate */ static const struct phy_config *fsl_samsung_hdmi_phy_lookup_rate(unsigned long rate) { @@ -511,14 +520,6 @@ static const struct phy_config *fsl_samsung_hdmi_phy_lookup_rate(unsigned long r &phy_pll_cfg[i] : &phy_pll_cfg[i+1]); } -static unsigned long phy_clk_recalc_rate(struct clk_hw *hw, - unsigned long parent_rate) -{ - struct fsl_samsung_hdmi_phy *phy = to_fsl_samsung_hdmi_phy(hw); - - return phy->cur_cfg->pixclk; -} - static void fsl_samsung_hdmi_calculate_phy(struct phy_config *cal_phy, unsigned long rate, u8 p, u16 m, u8 s) { @@ -639,7 +640,6 @@ static int phy_clk_register(struct fsl_samsung_hdmi_phy *phy) static int fsl_samsung_hdmi_phy_probe(struct platform_device *pdev) { - const struct phy_config *default_cfg; struct fsl_samsung_hdmi_phy *phy; int ret; @@ -664,23 +664,6 @@ static int fsl_samsung_hdmi_phy_probe(struct platform_device *pdev) return dev_err_probe(phy->dev, PTR_ERR(phy->refclk), "failed to get ref clk\n"); - /* - * Establish the rate reported by recalc_rate() before registering the - * clock. Otherwise CCF may skip the first set_rate() when it requests - * the assumed default rate, leaving the PHY unconfigured. - */ - ret = clk_prepare_enable(phy->refclk); - if (ret) - return dev_err_probe(phy->dev, ret, - "failed to enable ref clk\n"); - - default_cfg = fsl_samsung_hdmi_phy_lookup_rate(PHY_DEFAULT_RATE); - ret = fsl_samsung_hdmi_phy_configure(phy, default_cfg); - clk_disable_unprepare(phy->refclk); - if (ret) - return dev_err_probe(phy->dev, ret, - "failed to configure default rate\n"); - pm_runtime_get_noresume(phy->dev); pm_runtime_set_active(phy->dev); pm_runtime_enable(phy->dev); @@ -719,7 +702,7 @@ static int __maybe_unused fsl_samsung_hdmi_phy_suspend(struct device *dev) static int __maybe_unused fsl_samsung_hdmi_phy_resume(struct device *dev) { struct fsl_samsung_hdmi_phy *phy = dev_get_drvdata(dev); - int ret; + int ret = 0; ret = clk_prepare_enable(phy->apbclk); if (ret) { @@ -727,23 +710,11 @@ static int __maybe_unused fsl_samsung_hdmi_phy_resume(struct device *dev) return ret; } - if (!phy->cur_cfg) - return 0; - - ret = clk_prepare_enable(phy->refclk); - if (ret) { - dev_err(phy->dev, "failed to enable ref clk\n"); - goto disable_apbclk; - } - - ret = fsl_samsung_hdmi_phy_configure(phy, phy->cur_cfg); - clk_disable_unprepare(phy->refclk); - if (!ret) - return 0; + if (phy->cur_cfg) + ret = fsl_samsung_hdmi_phy_configure(phy, phy->cur_cfg); -disable_apbclk: - clk_disable_unprepare(phy->apbclk); return ret; + } static DEFINE_RUNTIME_DEV_PM_OPS(fsl_samsung_hdmi_phy_pm_ops, -- 2.47.3