From: "Chang S. Bae" <chang.seok.bae@intel.com>
To: linux-kernel@vger.kernel.org
Cc: x86@kernel.org, tglx@kernel.org, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com,
andrew.cooper3@citrix.com, arjan.van.de.ven@intel.com,
chang.seok.bae@intel.com
Subject: [PATCH RFC v2 7/7] x86/microcode/intel: Apply minimum revision check to early loading
Date: Mon, 16 Nov 2026 16:45:48 +0000 [thread overview]
Message-ID: <20261116164548.900486-8-chang.seok.bae@intel.com> (raw)
In-Reply-To: <20261116164548.900486-1-chang.seok.bae@intel.com>
The minimum revision check is now generally applicable. Establish the
minimum revision check on early loading. Load the patch but taint the
kernel when the check fails.
Adjust the check function so that the early path can pass the current
revision.
Suggested-by: Arjan van de Ven <arjan.van.de.ven@intel.com>
Signed-off-by: Chang S. Bae <chang.seok.bae@intel.com>
---
V1 -> V2: Drop force_minrev support
---
arch/x86/kernel/cpu/microcode/intel.c | 51 +++++++++++++--------------
1 file changed, 25 insertions(+), 26 deletions(-)
diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
index eec8a45b283c..8d598c7ac2c4 100644
--- a/arch/x86/kernel/cpu/microcode/intel.c
+++ b/arch/x86/kernel/cpu/microcode/intel.c
@@ -766,6 +766,29 @@ static int __init save_builtin_microcode(void)
}
early_initcall(save_builtin_microcode);
+static bool ucode_validate_minrev(u32 cur_rev, struct microcode_header_intel *mc_header)
+{
+ /*
+ * Ensure the header declares a minimum revision required to perform a
+ * load. The previously reserved field is 0 in older microcode blobs.
+ */
+ if (!mc_header->min_req_ver) {
+ pr_info("Unsafe microcode update: Microcode header does not specify a required min version\n");
+ return false;
+ }
+
+ /*
+ * Check whether the current revision is either greater or equal to
+ * the minimum revision specified in the header.
+ */
+ if (cur_rev < mc_header->min_req_ver) {
+ pr_info("Unsafe microcode update: Current revision 0x%x too old.\n", cur_rev);
+ pr_info("Current should be at 0x%x or higher. Update incrementally.\n", mc_header->min_req_ver);
+ return false;
+ }
+ return true;
+}
+
/* Load microcode on BSP from initrd or builtin blobs */
void __init load_ucode_intel_bsp(struct early_load_data *ed)
{
@@ -777,6 +800,7 @@ void __init load_ucode_intel_bsp(struct early_load_data *ed)
if (uci.mc && apply_microcode_early(&uci) == UCODE_UPDATED) {
ucode_patch_va = UCODE_BSP_LOADED;
ed->new_rev = uci.cpu_sig.rev;
+ ed->is_safe = ucode_validate_minrev(ed->old_rev, uci.mc);
}
}
@@ -825,31 +849,6 @@ static enum ucode_state apply_microcode_late(int cpu)
return ret;
}
-static bool ucode_validate_minrev(struct microcode_header_intel *mc_header)
-{
- int cur_rev = boot_cpu_data.microcode;
-
- /*
- * Ensure the header declares a minimum revision required to perform a
- * load. The previously reserved field is 0 in older microcode blobs.
- */
- if (!mc_header->min_req_ver) {
- pr_info("Unsafe microcode update: Microcode header does not specify a required min version\n");
- return false;
- }
-
- /*
- * Check whether the current revision is either greater or equal to
- * to the minimum revision specified in the header.
- */
- if (cur_rev < mc_header->min_req_ver) {
- pr_info("Unsafe microcode update: Current revision 0x%x too old\n", cur_rev);
- pr_info("Current should be at 0x%x or higher. Update incrementally.\n", mc_header->min_req_ver);
- return false;
- }
- return true;
-}
-
static bool is_revision_candidate(unsigned int cur_rev, unsigned int rev)
{
/*
@@ -921,7 +920,7 @@ static enum ucode_state parse_microcode_blobs(int cpu, struct iov_iter *iter)
if (!revision_is_safe(&uci->cpu_sig, mc_header.rev))
continue;
- is_safe = ucode_validate_minrev(&mc_header);
+ is_safe = ucode_validate_minrev(uci->cpu_sig.rev, &mc_header);
if (force_minrev && !is_safe)
continue;
--
2.53.0
prev parent reply other threads:[~2026-11-16 17:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 16:45 [PATCH v2 0/7] x86/microcode: Incremental Loading and Early Minimum Revision Check Chang S. Bae
2026-11-16 16:45 ` [PATCH v2 1/7] x86/microcode: Avoid spurious base_rev= match Chang S. Bae
2026-11-16 16:45 ` [PATCH v2 2/7] x86/microcode: Accept a boolean for force_minrev parameter Chang S. Bae
2026-11-16 16:45 ` [PATCH v2 3/7] x86/microcode: Mark early_data __initdata Chang S. Bae
2026-11-16 16:45 ` [PATCH v2 4/7] x86/microcode: Introduce incremental late loading Chang S. Bae
2026-11-16 16:45 ` [PATCH v2 5/7] x86/microcode/intel: Select the lowest revision for incremental loading Chang S. Bae
2026-11-16 16:45 ` [PATCH RFC v2 6/7] x86/microcode: Decouple minimum revision check from late loading Chang S. Bae
2026-11-16 16:45 ` Chang S. Bae [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116164548.900486-8-chang.seok.bae@intel.com \
--to=chang.seok.bae@intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=arjan.van.de.ven@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®