mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Aviv Bakal <avivb@amazon.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>,
	"Lukas Wunner" <lukas@wunner.de>,
	Kuppuswamy Sathyanarayanan
	<sathyanarayanan.kuppuswamy@linux.intel.com>,
	<linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Zeev Zilberman <zeev@amazon.com>
Subject: [PATCH v2 0/3] PCI/PM: Keep hotplug ports that can't wake from D3hot out of D3
Date: Mon, 16 Nov 2026 18:51:07 +0200	[thread overview]
Message-ID: <20261116165110.2773301-1-avivb@amazon.com> (raw)

d4c79b63d82d ("PCI: Allow D3 for native hotplug-capable Root Ports on
non-x86 platforms") lets native pciehp ports runtime suspend to D3hot
on non-x86. The PCIe switch ports on AWS instances advertise PME from
D3hot but do not send it, so hotplug events such as an ENI attach are
lost on Graviton. x86 keeps the old logic, so the problem does not show
up there.

Patches 1-2 handle existing switch devices, which advertise PME:
patch 1 makes pci_bridge_d3_possible() honor PCI_DEV_FLAGS_NO_D3, and
patch 2 sets that flag on the Amazon switch ports.

Patch 3 handles switch devices that advertise no PME from D3hot: such
hotplug ports are kept out of D3.

Changes in v2:
- Patch 1: check a copy of NO_D3 taken in pci_pm_init(), so
  pci_bridge_d3_possible() does not change when a FINAL fixup sets
  the flag after portdrv has probed.
- Patch 2: reuse quirk_no_ata_d3(), renamed to quirk_no_d3().

v1: https://lore.kernel.org/all/20261115171831.1498006-1-avivb@amazon.com/

Aviv Bakal (3):
  PCI/PM: Honor PCI_DEV_FLAGS_NO_D3 in pci_bridge_d3_possible()
  PCI: Avoid runtime D3 on Amazon PCIe switch ports
  PCI/PM: Keep hotplug ports out of D3 if they can't signal PME from
    D3hot

 drivers/pci/pci.c    | 22 +++++++++++++++++++++-
 drivers/pci/quirks.c | 20 ++++++++++++++------
 include/linux/pci.h  |  1 +
 3 files changed, 36 insertions(+), 7 deletions(-)


base-commit: 23c62304dde29abe92013d85910d03a77dada35d
-- 
2.50.1


             reply	other threads:[~2026-11-16 16:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 16:51 Aviv Bakal [this message]
2026-11-16 16:51 ` [PATCH v2 1/3] PCI/PM: Honor PCI_DEV_FLAGS_NO_D3 in pci_bridge_d3_possible() Aviv Bakal
2026-11-16 16:51 ` [PATCH v2 2/3] PCI: Avoid runtime D3 on Amazon PCIe switch ports Aviv Bakal
2026-11-16 16:51 ` [PATCH v2 3/3] PCI/PM: Keep hotplug ports out of D3 if they can't signal PME from D3hot Aviv Bakal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116165110.2773301-1-avivb@amazon.com \
    --to=avivb@amazon.com \
    --cc=bhelgaas@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=manivannan.sadhasivam@oss.qualcomm.com \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=zeev@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®