From: Anil Kaushik <anilkaushikwireless@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, idosch@nvidia.com,
nicolas.dichtel@6wind.com, jacob.e.keller@intel.com,
jiri@resnulli.us, fw@strlen.de, martineau@kernel.org,
v3rdant.xiang@gmail.com, aliceryhl@google.com,
linux-kernel@vger.kernel.org, anilkaushikwireless@gmail.com
Subject: Re: [PATCH net v6] genetlink: Reject joining multicast groups no family owns
Date: Mon, 16 Nov 2026 17:20:49 +0000 [thread overview]
Message-ID: <20261116172049.1617873-1-anilkaushikwireless@gmail.com> (raw)
In-Reply-To: <179482223865.3136.3369549991780791717@kernel.org>
On Mon, Nov 16, 2026 at 09:43:58AM +0000, netdev-bot+sashiko@kernel.org wrote:
> - [Medium] The fix still lets a socket become a member of a multicast
> group ID that no family owns.
This race is not new. It was there before this patch, also for groups
with GENL_MCAST_CAP_*. This patch does not fix it, and the commit
message says so. It needs a privileged module unload at the same time
as the join.
I can send a separate fix for net-next if needed.
> - [Low] The patch changes how the reserved, uAPI-exported static
> multicast group IDs behave, and nothing a uAPI consumer would read...
Agreed. v7 updates the comments on the static IDs and on
NET_DM_GRP_ALERT to say they can be joined only after the family is
registered:
https://lore.kernel.org/netdev/20261116124030.1595567-1-anilkaushikwireless@gmail.com/
Thanks,
Anil
prev parent reply other threads:[~2026-11-16 17:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-12 9:42 Anil Kaushik
2026-11-13 15:11 ` Nicolas Dichtel
2026-11-15 2:57 ` Anil Kaushik
2026-11-16 9:43 ` netdev-bot+sashiko
2026-11-16 17:20 ` Anil Kaushik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116172049.1617873-1-anilkaushikwireless@gmail.com \
--to=anilkaushikwireless@gmail.com \
--cc=aliceryhl@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=v3rdant.xiang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®