From: Shivani Patel <patelshivani2283@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Parthiban Veerasooran <parthiban.veerasooran@microchip.com>,
Christian Gromm <christian.gromm@microchip.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Andy Shevchenko <andriy.shevchenko@intel.com>,
Julia Lawall <julia.lawall@inria.fr>,
Shivani Patel <patelshivani2283@gmail.com>
Subject: [PATCH v2] staging: most: video: Document locks in struct most_video_dev
Date: Tue, 17 Nov 2026 00:03:55 +0530 [thread overview]
Message-ID: <20261116183355.22563-1-patelshivani2283@gmail.com> (raw)
checkpatch.pl reports that list_lock and lock in struct most_video_dev
are defined without a comment.
list_lock protects the pending_mbos list and the mute flag, which are
accessed both from file operations and from the rx completion callback
called by the MOST core. lock is assigned to vdev->lock and is used by
the V4L2 core to serialize ioctls.
Add short comments describing what each lock protects.
Signed-off-by: Shivani Patel <patelshivani2283@gmail.com>
---
v2:
- Add a commit message and Signed-off-by (Andy Shevchenko)
- Use the "staging: most: video:" subject prefix
- Make the comments shorter and accurate
- Drop the outreachy list (Julia Lawall)
drivers/staging/most/video/video.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c
index 3a0445ff6..8833ab5c7 100644
--- a/drivers/staging/most/video/video.c
+++ b/drivers/staging/most/video/video.c
@@ -33,6 +33,7 @@ struct most_video_dev {
bool mute;
struct list_head pending_mbos;
+ /* Protects @pending_mbos and @mute against the rx completion path */
spinlock_t list_lock;
struct v4l2_device v4l2_dev;
@@ -40,6 +41,7 @@ struct most_video_dev {
struct video_device *vdev;
unsigned int ctrl_input;
+ /* Serializes V4L2 ioctls, used as the video_device lock */
struct mutex lock;
wait_queue_head_t wait_data;
--
2.50.1 (Apple Git-155)
reply other threads:[~2026-11-16 18:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116183355.22563-1-patelshivani2283@gmail.com \
--to=patelshivani2283@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=christian.gromm@microchip.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=parthiban.veerasooran@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®