mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hungyu Lin <dennylin0707@gmail.com>
To: tytso@mit.edu
Cc: adilger.kernel@dilger.ca, libaokun@linux.alibaba.com,
	jack@suse.cz, ojaswin@linux.ibm.com, ritesh.list@gmail.com,
	yi.zhang@huawei.com, namjae.jeon@samsung.com,
	a.sangwan@samsung.com, linux-ext4@vger.kernel.org,
	linux-kernel@vger.kernel.org, dennylin0707@gmail.com
Subject: [PATCH] ext4: check RLIMIT_FSIZE in insert range
Date: Mon, 16 Nov 2026 18:58:10 +0000	[thread overview]
Message-ID: <20261116185810.82581-1-dennylin0707@gmail.com> (raw)

ext4_insert_range() grows the file by len bytes but only checks the new
size against s_maxbytes. FALLOC_FL_INSERT_RANGE can therefore make a
file larger than RLIMIT_FSIZE allows, while ftruncate() and the
fallocate() modes that extend a file fail with -EFBIG and SIGXFSZ. xfs,
f2fs and ntfs3 already refuse to insert a range past the limit.

Fix this by validating the new size with inode_newsize_ok(), as
ext4_do_fallocate() and ext4_zero_range() do.

Fixes: 331573febb6a ("ext4: Add support FALLOC_FL_INSERT_RANGE for fallocate")
Cc: stable@vger.kernel.org
Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
 fs/ext4/extents.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index ad0d80e33f60..94b9e091ef5f 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -5803,6 +5803,9 @@ static int ext4_insert_range(struct file *file, loff_t offset, loff_t len)
 	/* Check whether the maximum file size would be exceeded */
 	if (len > inode->i_sb->s_maxbytes - inode->i_size)
 		return -EFBIG;
+	ret = inode_newsize_ok(inode, inode->i_size + len);
+	if (ret)
+		return ret;
 
 	/*
 	 * Persist the pending zeroed EOF block to ensure i_disksize
-- 
2.43.0


                 reply	other threads:[~2026-11-16 18:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116185810.82581-1-dennylin0707@gmail.com \
    --to=dennylin0707@gmail.com \
    --cc=a.sangwan@samsung.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=jack@suse.cz \
    --cc=libaokun@linux.alibaba.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namjae.jeon@samsung.com \
    --cc=ojaswin@linux.ibm.com \
    --cc=ritesh.list@gmail.com \
    --cc=tytso@mit.edu \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®