From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.171 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794858144; b=QnvfMHgUzzco8Ukg0WMpAFLqeSIn0S64C8fOXRE18BOuLvIbmOBrj0FbCeJNFWR9NmSp riSyNO3Zctf1KCHSxQcNzc5eUeDvUxSk7mHXRUkTCvS+825awOYEiG9SiPNJsXU5nqEK5 srAfL0OwXaIJrndWvUG9xW91MqOl2CUBzpACoGr3OIyD/lU3zKeI3K0V9SO5M/Whsl0uA zdHaZcJ9r81C27EIkW8VOunsj8fGP/b6D5zrENM/t8bHzDqghpiUHzgSRhksddlBfnsj+ J2AvJ0e/JNnj8tZs5Q6MdFwxFAtYQtf7kywexYfd/vMoX3TVNOAdK9+7nlNDFwieZTQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794858144; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:MIME-Version: Content-Transfer-Encoding; bh=YQ2w1SKYNQZpDiN+RPlgH5e5kIzAXTbHX2JmN1bVYs8=; b=nXRypeGwK/cUrouo1d7aYNreS2BkUCuuS27kiJ0ieJG7/r89L6GLYEBeA2SFkjMbOTE9 I6pVEc7kPFKYFA7S74ZupDj6iX/dCmbb50dPxCxe631o07SmGJa3fuixW738CR9gqvXRv gw0+jF/zMKl+ZbI9L9iWkEwNrqzooI3hGloug1oUd71Wbxz+3BuudNebW8BlyxeG1yk4J vyWyvj56yWaUXQSEgAuO9JG/7jSDZwBhr5S1tFN4cmieg06l5+hGH/fXXyWkCzcUzj04o ACSKfeAtaPaWOwfBaImx12UilkveEfKnrKyJZJ3BuOAn2Xy49v8+T5f1lBFbE5qXhYg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b="E/0nh+BP"; arc=none smtp.remote-ip=74.125.82.171 Received: from mail-dy1-f171.google.com (mail-dy1-f171.google.com [74.125.82.171]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 135CA606A31C for ; Mon, 16 Nov 2026 19:42:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 135CA606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=E/0nh+BP Received: by mail-dy1-f171.google.com with SMTP id 5a478bee46e88-3791619605cso7264326eec.0 for ; Mon, 16 Nov 2026 11:42:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794858143; x=1795462943; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=YQ2w1SKYNQZpDiN+RPlgH5e5kIzAXTbHX2JmN1bVYs8=; b=E/0nh+BPbckGUnmAJe4GE0O8g2kmQhtn83sBlsn6Y6a04e4BISc5m2L5hTs8UDvzb3 bYgz38bh4PLy/HK0ueN7+vPC6ApKmZseRXUgu6VHsmxiSNX4QXnWPn2tt0Xdp8bdBow7 s0K1VO/EU0ZH+Zsw2UDxxmp97O1j82ms48rXuF24tbc8BEwQomHrzLeAnDTnbOWBysN+ Nba2PmAvy1FGSbJpDZArGIKwhX0e1K00rDja9wDqDSAKCq15IWG+88tOpiSNa1xD6aXI +7k/lAFovvO9Tp0KfypCpnNi0+NG9dv4UD2kkbDGkmWMxwf2nqyJzFARVY2u+CvwugC1 lTsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794858143; x=1795462943; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YQ2w1SKYNQZpDiN+RPlgH5e5kIzAXTbHX2JmN1bVYs8=; b=c3WaM6iIppa9ULyH2pED6PeVzZ8XoGmVMinMrrohvVIOLfX1FizzEi1UoyHi6rJwhf JPTbID6u30c8v1Hs2eqUJ251u2M5R7QlpR+b7TM43P+bzzjhEskH9UHkuqT8iL8SQ7eu 7+CQmlz14QVy2IAGtFSCupXhw0DCbCtPfJCesQ8Nm2zi/R0FvF29qnDXq/s20YIhqJP+ Gd9n0czFaAKDY8gZNd9mKYl9E2GuTJpUkoVB+k2GddCvSmhI25hg44aPFde3ClQ4BKnh 29sEoOB9JOKckfTmQze0Xwvyy6JOgb7SSJI41lJVApsIOC6H/FP8sNA714P7L5DSf9ex Hiag== X-Forwarded-Encrypted: i=1; AL+hErGqgXNB4fTqYG+AjAynUbLL0hGCXGo81n0i47A9Ee5AcBTZURsNpo2XxTSJ4pEPcEo/mN1d6v7H1DU7DUA=@vger.kernel.org X-Gm-Message-State: APuU4Z9wWZ5Lse647JNeKtMtWapiy22mQzLMi3TEK3b7PyT18pb7f2g5 uQGgbMCJbWYry3nHWuIURtUflqySC5tYbS6I++MeCxzSW3SNXbXC7l4X X-Gm-Gg: AZFdTZeiaPAIH6a8HggINRaWx7fpyVNpzYnAdE5WOpK3tMn6GPgg3YxHHN5CXhjVxNW WIqqau5tUzDHZBtLBDzUunHjDDpe4KROUbP7AC93jhziqCTMtvbZpUKCtU3q8mTKQzlBlkAlogZ rDr/LSIonQuCH9x7eP7cnCJobLnmSaA4ty59JwZ3hLPdXsRG/fxPgDGGlU1Zx7heKAEzNkpctnk vJBCM0qthbfha8PDxf6ArnGC4URICyghRG+qcZU3xZ2Ntf01tJH7+wdAgWMRaohCR4aY//PrwnI pc47S+LFh5b2yo1V1Z6WYRqQ1Ny4dr9SQqQaThUFeZpdKmReDt5c9Ki7mWAtPEkDHxh3C9yAInm Dy+i89H4RVzRnTzoPhTYA62pM5zJfTRwC+stYToQ82oGLcaMe1smW/+DfcivwtSywpDwH82qhNj BHN55yr0oHzSi8y14vIoH0HZF8kqAMku0j3od0cZcLkq13tAFO4HQvBqtULtBCeherh50xzvFAL QvmlQdNzgecgg3XofKR1w1YbGCRFW6ZNNXu3F/Q1slHk1JmLnkAkk7/SCFM2x/mdleqQ/kIMKtP hV7Zko75OxZWtND/oRNZF6dVopqp5wvbCV8eaPoI52YBr5EbH8FpYxqoBYLw8XE9y7A0RX3lABj c90HB7twgV6/6996nEGPDsIraJEd6TG4rIBItg2h3NVqH5g5YyfOj1TuFuNfu5lg+u2JXtuQrR/ SebfOV50F8spbYPZcUSOwvlsuqXFlBYayk0fShjAJlViNL1UbtOSe3p2v+mS16l9M= X-Received: by 2002:a05:7301:d189:b0:36e:e349:f2cb with SMTP id 5a478bee46e88-3796628e28amr11639657eec.19.1794858143008; Mon, 16 Nov 2026 11:42:23 -0800 (PST) Received: from kapoor.iiserb.ac.in ([203.18.51.239]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-380e031f3e5sm3238446eec.12.2026.11.16.11.42.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 11:42:22 -0800 (PST) From: Arnav Kapoor To: Jonathan Cameron Cc: Mudit Sharma , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Arnav Kapoor Subject: [PATCH] iio: light: bh1745: fix 16-bit register accesses Date: Tue, 17 Nov 2026 01:12:10 +0530 Message-ID: <20261116194214.45174-1-kapoorarnav43@gmail.com> X-Mailer: git-send-email 2.53.0 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The 16-bit colour data and threshold registers are little-endian LSB/MSB pairs, but the driver accesses them through regmap_bulk_read() and regmap_bulk_write() with an int or u16 buffer and no byte-order conversion: - bh1745_read_raw() reads 2 bytes into an uninitialised int, so the upper 16 bits returned to user space are stack contents. - bh1745_read_thresh() reads 2 bytes straight into *val, which the IIO core leaves uninitialised, with the same result for the event threshold attributes. - bh1745_write_thresh() writes the first 2 bytes of an int, which are the upper (zero) bytes on big-endian. - bh1745_trigger_handler() stores the raw bytes in a u16 although the scan type is IIO_CPU. Use an __le16 buffer for all of them and convert with le16_to_cpu() / cpu_to_le16(). Fixes: eab35358aae7 ("iio: light: ROHM BH1745 colour sensor") Signed-off-by: Arnav Kapoor --- Compile-tested only (W=1, checkpatch --strict clean); I don't have BH1745 hardware. On little-endian the raw read currently returns the register value plus whatever was on the stack in the upper 16 bits of the uninitialised int; the threshold read has the same problem through iio_ev_value_show(), whose val is not initialised either. drivers/iio/light/bh1745.c | 29 +++++++++++++++++++---------- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/iio/light/bh1745.c b/drivers/iio/light/bh1745.c index 2b8ff36071b8..9c14499f848a 100644 --- a/drivers/iio/light/bh1745.c +++ b/drivers/iio/light/bh1745.c @@ -421,19 +421,20 @@ static int bh1745_read_raw(struct iio_dev *indio_dev, int *val, int *val2, long mask) { struct bh1745_data *data = iio_priv(indio_dev); + __le16 value; int ret; - int value; switch (mask) { case IIO_CHAN_INFO_RAW: if (!iio_device_claim_direct(indio_dev)) return -EBUSY; - ret = regmap_bulk_read(data->regmap, chan->address, &value, 2); + ret = regmap_bulk_read(data->regmap, chan->address, &value, + sizeof(value)); iio_device_release_direct(indio_dev); if (ret) return ret; - *val = value; + *val = le16_to_cpu(value); return IIO_VAL_INT; @@ -503,6 +504,7 @@ static int bh1745_read_thresh(struct iio_dev *indio_dev, enum iio_event_info info, int *val, int *val2) { struct bh1745_data *data = iio_priv(indio_dev); + __le16 value; int ret; switch (info) { @@ -510,18 +512,22 @@ static int bh1745_read_thresh(struct iio_dev *indio_dev, switch (dir) { case IIO_EV_DIR_RISING: ret = regmap_bulk_read(data->regmap, BH1745_TH_LSB, - val, 2); + &value, sizeof(value)); if (ret) return ret; + *val = le16_to_cpu(value); + return IIO_VAL_INT; case IIO_EV_DIR_FALLING: ret = regmap_bulk_read(data->regmap, BH1745_TL_LSB, - val, 2); + &value, sizeof(value)); if (ret) return ret; + *val = le16_to_cpu(value); + return IIO_VAL_INT; default: @@ -547,6 +553,7 @@ static int bh1745_write_thresh(struct iio_dev *indio_dev, enum iio_event_info info, int val, int val2) { struct bh1745_data *data = iio_priv(indio_dev); + __le16 value; int ret; switch (info) { @@ -554,10 +561,12 @@ static int bh1745_write_thresh(struct iio_dev *indio_dev, if (val < 0x0 || val > 0xFFFF) return -EINVAL; + value = cpu_to_le16(val); + switch (dir) { case IIO_EV_DIR_RISING: ret = regmap_bulk_write(data->regmap, BH1745_TH_LSB, - &val, 2); + &value, sizeof(value)); if (ret) return ret; @@ -565,7 +574,7 @@ static int bh1745_write_thresh(struct iio_dev *indio_dev, case IIO_EV_DIR_FALLING: ret = regmap_bulk_write(data->regmap, BH1745_TL_LSB, - &val, 2); + &value, sizeof(value)); if (ret) return ret; @@ -741,18 +750,18 @@ static irqreturn_t bh1745_trigger_handler(int interrupt, void *p) u16 chans[4]; aligned_s64 timestamp; } scan = { }; - u16 value; + __le16 value; int ret; int i; int j = 0; iio_for_each_active_channel(indio_dev, i) { ret = regmap_bulk_read(data->regmap, BH1745_RED_LSB + 2 * i, - &value, 2); + &value, sizeof(value)); if (ret) goto err; - scan.chans[j++] = value; + scan.chans[j++] = le16_to_cpu(value); } iio_push_to_buffers_with_ts(indio_dev, &scan, sizeof(scan), base-commit: a6d9114f68c4b5507b2d945bd6d1e37415f913c5 -- 2.53.0