mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnav Kapoor <kapoorarnav43@gmail.com>
To: Takashi Iwai <tiwai@suse.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
	Kailang Yang <kailang@realtek.com>,
	Dorian Cruveiller <doriancruveiller@gmail.com>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	Arnav Kapoor <kapoorarnav43@gmail.com>
Subject: [PATCH] ALSA: hda/realtek: Don't apply the Legion Slim 7 quirk to Lenovo V14 G2 ITL
Date: Tue, 17 Nov 2026 01:25:00 +0530	[thread overview]
Message-ID: <20261116195503.11530-1-kapoorarnav43@gmail.com> (raw)

The Lenovo V14 G2 ITL (82KA) has PCI SSID 17aa:380e and an ALC257 with
codec SSID 17aa:38b7. No entry matches the PCI SSID, so the codec SSID
fallback picks the Legion Slim 7 16APH8 entry for PCI SSID 17aa:38b7:

  ALC257: picked fixup  for codec SSID 17aa:38b7

That applies ALC287_FIXUP_CS35L41_I2C_2 and sets up component binding
for two CS35L41 amplifiers, which this machine doesn't have; its single
speaker pair is driven by the ALC257 itself (pin 0x14).

Add a codec SSID entry after the Legion one, so the Legion keeps
matching on its PCI SSID first and the V14 G2 ITL gets
ALC269_FIXUP_LENOVO_XPAD_ACPI, the fixup the Lenovo vendor fallback
gives it when nothing else matches.

Fixes: 99af5b11c57d ("ALSA: hda/realtek: enable SND_PCI_QUIRK for Lenovo Legion Slim 7 Gen 8 (2023) serie")
Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
---
Tested on a V14 G2 ITL (BIOS GGCN55WW, 7.0 kernel) by booting
with snd_sof_intel_hda_generic.hda_model=lenovo-xpad-led, which selects the
same fixup this entry does: dmesg then shows "picked fixup lenovo-xpad-led
(model specified)", and speakers, headphones, headset mic and internal mic
all work as before. Build-tested (W=1) on next-20261113.

 sound/hda/codecs/realtek/alc269.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 96fa8c2782bb..73a89e3cbce4 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -8605,6 +8605,10 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x38b5, "Legion Slim 7 16IRH8", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x17aa, 0x38b6, "Legion Slim 7 16APH8", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x17aa, 0x38b7, "Legion Slim 7 16APH8", ALC287_FIXUP_CS35L41_I2C_2),
+	/* Lenovo V14 G2 ITL has PCI SSID 17aa:380e and codec SSID 17aa:38b7, which
+	 * falls back to the Legion Slim 7 16APH8 entry above; this must come after it
+	 */
+	HDA_CODEC_QUIRK(0x17aa, 0x38b7, "Lenovo V14 G2 ITL", ALC269_FIXUP_LENOVO_XPAD_ACPI),
 	SND_PCI_QUIRK(0x17aa, 0x38b8, "Yoga S780-14.5 proX AMD YC Dual", ALC287_FIXUP_TAS2781_I2C),
 	SND_PCI_QUIRK(0x17aa, 0x38b9, "Yoga S780-14.5 proX AMD LX Dual", ALC287_FIXUP_TAS2781_I2C),
 	SND_PCI_QUIRK(0x17aa, 0x38ba, "Yoga S780-14.5 Air AMD quad YC", ALC287_FIXUP_TAS2781_I2C),

base-commit: 84abb955b1015477aa11a96e2f3ac1b938b77f48
-- 
2.53.0


                 reply	other threads:[~2026-11-16 19:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116195503.11530-1-kapoorarnav43@gmail.com \
    --to=kapoorarnav43@gmail.com \
    --cc=doriancruveiller@gmail.com \
    --cc=kailang@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®