mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org,
	"Borislav Petkov (AMD)" <bp@alien8.de>,
	stable@vger.kernel.org, x86@kernel.org
Subject: Re: [tip: x86/urgent] x86/build: Do not allow X86_NATIVE_CPU to be enabled when compile testing
Date: Mon, 16 Nov 2026 13:45:17 -0700	[thread overview]
Message-ID: <20261116204517.GB1037705@ax162> (raw)
In-Reply-To: <CAHk-=wgmkoWHWwaQ6nsGoCiBp0hrpJuiwmoVbQ=Efun8JyUNKw@mail.gmail.com>

On Mon, Nov 16, 2026 at 07:48:34AM -0800, Linus Torvalds wrote:
> On Mon, 16 Nov 2026 at 05:02, Nathan Chancellor <nathan@kernel.org> wrote:
> >
> > On Mon, Nov 16, 2026 at 10:40:01AM +0100, Ingo Molnar wrote:
> > > Can we just limit the feature to when host == target, ie. to not
> > > work it around in such a crude fashion?
> >
> > That was my v1 but Boris didn't like it:
> >
> >   https://lore.kernel.org/20261113-x86-no-march-native-on-non-x86_64-v1-1-cbc8b096d1c4@kernel.org
> 
> Well, that is admittedly very crude and hacky.

I guess that's one way to describe it.

> Maybe we should have some config variables that depend on HOSTCC, and
> detect it *that* way. It does appear that we don't have any model for
> cross-compiling in the Kconfig setup, but maybe  we should..
> 
> I'd actually love to have support for making the compiler itself part
> of Kconfig, so that the gcc-vs-clang could be *in* the .config file
> rather than being an external thing to it.

I guess you mean having CC and HOSTCC and friends as values in Kconfig?

> I've mentioned that before, and the problem has typically been that we
> end up depending on 'CC' outside of the Kconfig scripts and
> independently of the current config.
> 
> The recent work to move the compiler flags into Kconfig itself may
> have lessened some of those dependencies, but there's probably still
> lots of small details.
> 
> But for the whole "cross-compile", maybe we can just say that
> X86_NATIVE_CPU depends on '$CC' being the same as '$HOSTCC'.

Unfortunately, that would not for the LLVM case that the commit message
brings up since HOSTCC == CC (we switch targets using '--target'),

> Or even do '$(CC) -v" and '$(HOSTCC) -v' and check for 'Target' being
> the same, and having a CONFIG_CROSSCOMPILE thing for that?

Hmmm, not a bad idea. That does seems to work based on my initial tests,
which would probably be the most generic way to solve this? I am not
sure I want to extrapolate '-march=native' out of x86 right now since I
think architecture maintainers should have the option to support it or
not. However, this would at least lay the ground work for generically
abstracting it (hopefully making Boris happy) and allowing it to still
be enabled in the allmodconfig case (hopefully making Ingo happy) while
still resolving my original issue.

diff --git a/arch/x86/Kconfig.cpu b/arch/x86/Kconfig.cpu
index 6e7a366f0798..4643b3482d94 100644
--- a/arch/x86/Kconfig.cpu
+++ b/arch/x86/Kconfig.cpu
@@ -217,6 +217,7 @@ config RUSTC_HAS_APXF
 config X86_NATIVE_CPU
 	bool "Build and optimize for local/native CPU"
 	depends on X86_64
+	depends on !CROSS_COMPILING
 	depends on CC_HAS_MARCH_NATIVE
 	depends on !RUST || RUSTC_HAS_APXF
 	help
diff --git a/scripts/Kconfig.toolchain b/scripts/Kconfig.toolchain
index 2acbd40a38f1..ac2e3de50ac0 100644
--- a/scripts/Kconfig.toolchain
+++ b/scripts/Kconfig.toolchain
@@ -32,6 +32,9 @@ config CLANG_VERSION
 	default $(cc-version) if CC_IS_CLANG
 	default 0
 
+config CROSS_COMPILING
+	def_bool $(success,$(srctree)/scripts/check-cross-compiling.sh "$(HOSTCC)" "$(CC) $(CLANG_FLAGS)")
+
 config AS_IS_GNU
 	def_bool $(success,test "$(as-name)" = GNU)
 
diff --git a/scripts/check-cross-compiling.sh b/scripts/check-cross-compiling.sh
new file mode 100755
index 000000000000..fd1af38926a9
--- /dev/null
+++ b/scripts/check-cross-compiling.sh
@@ -0,0 +1,19 @@
+#!/bin/sh
+# SPDX-License-Identifier: GPL-2.0
+
+hostcc="$1"
+cc="$2"
+
+get_target() {
+    "$@" -v 2>&1 | grep -o 'Target: \([^-]\+\)'
+}
+if ! hostcc_target=$(get_target $hostcc); then
+    echo >&2 "Could not get target for HOSTCC!"
+    return 1
+fi
+if ! cc_target=$(get_target $cc); then
+    echo >&2 "Could not get target for CC!"
+    return 1
+fi
+
+test "$hostcc_target" != "$cc_target"
-- 
Cheers,
Nathan

  parent reply	other threads:[~2026-11-16 20:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16  6:05 tip-bot2 for Nathan Chancellor
2026-11-16  9:40 ` Ingo Molnar
2026-11-16 13:01   ` Nathan Chancellor
2026-11-16 15:48     ` Linus Torvalds
2026-11-16 15:53       ` Linus Torvalds
2026-11-16 20:45       ` Nathan Chancellor [this message]
2026-11-16 22:36       ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116204517.GB1037705@ax162 \
    --to=nathan@kernel.org \
    --cc=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®