From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=74.125.82.174 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794862417; b=xR/H57vOn7gkU5x/pdRURXhWPVSS+hua+Kabs/OS7GiyD+hzh0jkI1yJPRlRPk653MYW KFp4M+l4R4P/HU2rv3D9qf+nAMAjcbijMwqH30vkjpmWTXSglKZl1kLED0xmE9ySjBABh e0NgNExueDLoR0R8TD6kkuzvNeQZEazV2dNYBxUbH1kKucrQR3vUgatwNW0HGEUtsKvdH qxYZUPJHac+Ln4KBOCfys6ijPbiGFuc3SOXgwrBEgzB/dm5qOj/BPA8gKCz/WbzyZt6Z6 nEhqTDD6Pf6dHV94rvgGhohdZlSNyOlo/sAYgzHfunaJMNpuFPCt+/p4N8gf9mIdOQw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794862417; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-ID:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=JBnzKQZzBT4WyH0+pQkXtO3eXK3ZrINhKYQbrALuTEY=; b=btwIs6gTiXIkbcxpv8JFyHSDm+YlKT/C+4gNbwdTa//stJJaeNcIRbsv4G7TskvFU8Lf sZB7idgiMdvzqSrd1gVztf8VB1TNWaagR3mY+9wWzcIlWZDo3cM2thdmjCAQtDmXeH5Fs K98i0mnwFR0/dYipTsxMlojlYWhiIOryQXxupgRs7041eSEbCwYtZkkuTwYycq2Gbt2S5 5No3ZX1p1rMBQlXEbihRA38zDH9iNGMAvur2DRGSf27tjS151bOQoIJg4JlrrEb0TTPGI bT/KawochVC0dXpwswiJv+0xViql0n2Yl6Jez4UuxXOIrj/tBdusvk8lC22d/tFJQZQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=deEhDzMw; arc=none smtp.remote-ip=74.125.82.174 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80FF4606A887 for ; Mon, 16 Nov 2026 20:53:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 80FF4606A887 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256 header.s=google header.b=deEhDzMw Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-33fb4680717so10193647eec.1 for ; Mon, 16 Nov 2026 12:53:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1794862417; x=1795467217; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=JBnzKQZzBT4WyH0+pQkXtO3eXK3ZrINhKYQbrALuTEY=; b=deEhDzMw8mkqzMDHotoO7tdUq4HM4qpNrY2H/iDB8iqRi99H7InpKzckbLq1QOHbkP ajOxMhcqfpvUAvx8qCi1/1oJ1A9WODrejNe6gQQhmK4i41WLluJXigQR6D9FrPB0G+X2 eHYEgosAh/dTUUDqhqCu8ae6b7e5hlJf/kr8Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794862417; x=1795467217; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=JBnzKQZzBT4WyH0+pQkXtO3eXK3ZrINhKYQbrALuTEY=; b=vjrfOGESDfeKxjh5+mBA45Uhrwh3BzpkjNxL5mcKvhTGSSouaWcvJqiZeQJHMjNSjf iMp0oKrAKBNw/kRqgxtLGkrlGnvsjqkV2YDogMpZztPhOdVz1bLvA5F0Ki022XfGCMqk TBkGQ+O2QsWe7jNY+1QlGEbtLqszydBgqnop9h6zHMgVFl1W2utkg7GygY24rre54Ym7 UK/SoJvkzQUvwjUzzGfb2Hn6WinC+3h567+SN+Rb/AmraYiKdVXrAQNwSgRVrNiDZ+fr 7m6+DhJYj4GCFKiyvB8zGsMNcMQkB0chbf4Gpeng7hQMUgKFQsLT/Fi4MYE1P4OwR5fn s5wA== X-Forwarded-Encrypted: i=1; AL+hErFU7L5qpzdo31ELAyfxhKRd30/ybD+A2ABYHJEQ5yPudg2kY4N4AF6KXOtApWU0qJBRey5gkkfLCJ7Wh+Q=@vger.kernel.org X-Gm-Message-State: APuU4Z970XchwUwly8hQNklVBQveFlbFayUWUw956PFt9bwvNK6/jSwG Aqcr2BPyLD9VLL0CI/pXk/UdPSFT0qYbQOiW2xO+E9finK1RSsGE1hbUKzieIfogaA== X-Gm-Gg: AZFdTZcJQUP4IUsGl+wQQRc+O8FbAXepoxTSRDhT3/Cm7XAFzW4u1JjvY4dUdYeGnsO eoNMttmVHcOE9baYH9WUH617XdcdxiDDUGbk5pelR6WxvPn/sK3iSK4FTYJqy8LHZu0+OTKk/+x 24j2+3gHITdUj3VnJxCQoEWonut5r+JiUGfuJogOtw60usGYmTVB25aOdeIztBtV3dgPi+8pek8 OaGeeCmMsu5DdreVohktRSmyYqry7sNXmA80jRoAaZc9kXWzsrjIdpYJnPBfIgAfea6TEBqKMS9 8l1QRK+2wsUv+IqTiSUTnl1l60ByY+D2mSdnRq+llh4+M4RMm2TyaRcIM3y6XxiWr1tF8g4Ba79 Anp9IlyXhlb/LCLFmQUmIIer09BOezSpqmuDY14aMKa5Ya3jUwgiTlqQ80ManLYTDv8n08eL56L g7FkJg0adGb68kF2YJtcD7JZxE/jSVMbaUapth/isTOooBiAhWZ96CAOUMZm9c9gPcIO/JqJ1qs AVFYj/v45iCBq6x49fuUHj0fRU3NG2rdtWNz/Ci03rw0PUjqiEvJYPfWERHGxHLg/DJHKHlfPhl pH1XTHFKbwgwQeJK2Mc4M28bsQD2BLwhntoVKF0+pkGVMCk7Jg1os3zls2+xIDifUKQJuZMBm/6 zPqiu+SfYIDQvlQ== X-Received: by 2002:a05:7301:a4:b0:378:b1be:2d3e with SMTP id 5a478bee46e88-37967ae558emr12079086eec.32.1794862416514; Mon, 16 Nov 2026 12:53:36 -0800 (PST) Received: from dianders.sjc.corp.google.com ([2a00:79e0:2e7c:8:40c8:6e27:a2df:3321]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-379563e6b6dsm67120390eec.21.2026.11.16.12.53.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2026 12:53:35 -0800 (PST) From: Douglas Anderson To: Devicetree-compiler@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio Cc: Devicetree@vger.kernel.org, Tudor Ambarus , Chen-Yu Tsai , Saravana Kannan , David Gibson , =?UTF-8?q?Andr=C3=A9=20Draszik?= , Simon Glass , linux-kernel@vger.kernel.org, Brian Norris , Peter Griffin , Julius Werner , Douglas Anderson Subject: [PATCH v4 02/14] pylibfdt: Make Property a subclass of bytes instead of bytearray Date: Mon, 16 Nov 2026 12:52:59 -0800 Message-ID: <20261116205320.1621386-3-dianders@chromium.org> X-Mailer: git-send-email 2.56.0.679.gc527c65306-goog In-Reply-To: <20261116205320.1621386-1-dianders@chromium.org> References: <20261116205320.1621386-1-dianders@chromium.org> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit `Property` represents a snapshot of a property's name and value read from a flattened device tree. Making `Property` a subclass of the immutable `bytes` type instead of mutable `bytearray` prevents callers from accidentally mutating a `Property` instance in place when sharing it across data structures (such as `DeviceTree`), makes `Property` hashable, and allows `Property` instances to be passed directly to `Fdt.setprop()` without converting to `bytes` first. Also return `bytes` instead of `bytearray` from the `fdt_get_property_by_offset()` SWIG typemap and drop the redundant `bytearray()` conversion in `FdtRo.getprop()`. Assisted-by: Gemini:gemini-pro-prerelease Signed-off-by: Douglas Anderson --- Changes in v4: - New patch making Property a subclass of bytes instead of bytearray (David Gibson) pylibfdt/libfdt.i | 17 +++++++++-------- tests/pylibfdt_tests.py | 1 + 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/pylibfdt/libfdt.i b/pylibfdt/libfdt.i index fa5f499ed96d..8a7dfed85f15 100644 --- a/pylibfdt/libfdt.i +++ b/pylibfdt/libfdt.i @@ -492,7 +492,7 @@ class FdtRo(object): Returns: Value of property as a Property object (which can be used as a - bytearray/string), or -ve error number. On failure, returns an + bytes/string), or -ve error number. On failure, returns an integer error Raises: @@ -502,7 +502,7 @@ class FdtRo(object): quiet) if pdata[0] is None: return pdata[1] - return Property(prop_name, bytearray(pdata[0])) + return Property(prop_name, pdata[0]) def hasprop(self, nodeoffset, prop_name, quiet=()): """Check if a node has a property @@ -893,7 +893,7 @@ class Fdt(FdtRo): return check_err(fdt_del_node(self._fdt, nodeoffset), quiet) -class Property(bytearray): +class Property(bytes): """Holds a device tree property name and value. This holds a copy of a property taken from the device tree. It does not @@ -902,11 +902,12 @@ class Property(bytearray): Properties: name: Property name - value: Property value as a bytearray + value: Property value as bytes """ - def __init__(self, name, value): - bytearray.__init__(self, value) - self.name = name + def __new__(cls, name, value): + obj = super().__new__(cls, value) + obj.name = name + return obj def __copy__(self): return type(self)(self.name, self) @@ -1275,7 +1276,7 @@ typedef uint32_t fdt32_t; if ($1) { resultobj = PyUnicode_FromString( fdt_string(fdt1, fdt32_to_cpu($1->nameoff))); - buff = PyByteArray_FromStringAndSize( + buff = PyBytes_FromStringAndSize( (const char *)($1 + 1), fdt32_to_cpu($1->len)); resultobj = SWIG_AppendOutput(resultobj, buff); } diff --git a/tests/pylibfdt_tests.py b/tests/pylibfdt_tests.py index ae46b29a8f5c..78d8976c0cf3 100644 --- a/tests/pylibfdt_tests.py +++ b/tests/pylibfdt_tests.py @@ -191,6 +191,7 @@ class PyLibfdtBasicTests(unittest.TestCase): root = 0 poffset = self.fdt.first_property_offset(root) prop = self.fdt.get_property_by_offset(poffset) + self.assertIsInstance(prop, bytes) self.assertEqual(prop.name, 'compatible') self.assertEqual(prop, b'test_tree1\0') for copied in (copy.copy(prop), copy.deepcopy(prop)): -- 2.56.0.679.gc527c65306-goog