mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnav Kapoor <kapoorarnav43@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Andy Shevchenko" <andriy.shevchenko@intel.com>,
	"Gwendal Grignou" <gwendal@chromium.org>,
	"Stephen Boyd" <swboyd@chromium.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Arnav Kapoor" <kapoorarnav43@gmail.com>
Subject: [PATCH 0/6] iio: proximity: sx93xx: fix raw reads, thresholds, hysteresis and gain
Date: Tue, 17 Nov 2026 02:23:08 +0530	[thread overview]
Message-ID: <20261116205320.26070-1-kapoorarnav43@gmail.com> (raw)

The remaining sx93xx fixes I had, sent as one series and grouped by
driver, as asked by Jonathan.

1: sx_common: a raw read can return on a stale completion (left by an
   interrupted read, or by conversions while another device uses the
   sensor's trigger), and it then turns off the CONVDONE interrupt the
   trigger depends on. The interrupted-read case was reported by
   Sashiko on Zhang Jie's sx9324 resolution patch.
2, 5: sx9324/sx9360 read_thresh() reports code r as r * r / 2, but
   write_thresh() inverts it with int_sqrt(2 * val), so writing back a
   value that was just read lowers odd codes by one; some negative
   values also wrap around instead of being rejected.
3, 6: sx9324/sx9360 write_hysteresis() turns negative values into the
   largest hysteresis.
4: the sx9360 gain encoding fix from the RFC, now a patch on top of
   "iio: proximity: sx9360: reject out-of-range hardware gain
   values" (in iio testing), as suggested by Jonathan. It uses the 
   encoding sx9324 got in 108e4d4de2b5 and that Semtech's own SX9360
   driver uses (codes 1..4 = x1..x8, 0 reserved).

Based on iio testing with the patches applied there since it was last
pushed (sx9324 reserved gain on read, sx9310 proxraw-strength = <0>,
sx9360 out-of-range gain).

Changes to patch 4 since the RFC:
- Rebased on the applied out-of-range gain patch; GAIN_8 becomes 0x4
  and the range check uses ilog2(val) + 1
- Commit message cites the Semtech vendor driver

RFC: https://lore.kernel.org/all/20261107112335.444813-1-kapoorarnav43@gmail.com/

The threshold change was checked against a userspace copy of both
conversions: all 256 codes round-trip, and every write picks the
largest code whose reported threshold doesn't exceed the request.
Compile-tested only (W=1); I don't have SX93xx hardware.

Arnav Kapoor (6):
  iio: proximity: sx_common: fix raw reads while the trigger is in use
  iio: proximity: sx9324: fix proximity threshold writes
  iio: proximity: sx9324: reject negative hysteresis values
  iio: proximity: sx9360: fix hardware gain encoding
  iio: proximity: sx9360: fix proximity threshold writes
  iio: proximity: sx9360: reject negative hysteresis values

 drivers/iio/proximity/sx9324.c    |  9 ++++++++-
 drivers/iio/proximity/sx9360.c    | 29 ++++++++++++++++++++++-------
 drivers/iio/proximity/sx_common.c | 25 +++++++++++++++++++------
 3 files changed, 49 insertions(+), 14 deletions(-)


base-commit: 8fda275449b68a96f0a38a61daa35cc39b0fb9d8
-- 
2.53.0


             reply	other threads:[~2026-11-16 20:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 20:53 Arnav Kapoor [this message]
2026-11-16 20:53 ` [PATCH 1/6] iio: proximity: sx_common: fix raw reads while the trigger is in use Arnav Kapoor
2026-11-16 20:53 ` [PATCH 2/6] iio: proximity: sx9324: fix proximity threshold writes Arnav Kapoor
2026-11-16 20:53 ` [PATCH 3/6] iio: proximity: sx9324: reject negative hysteresis values Arnav Kapoor
2026-11-16 20:53 ` [PATCH 4/6] iio: proximity: sx9360: fix hardware gain encoding Arnav Kapoor
2026-11-16 20:53 ` [PATCH 5/6] iio: proximity: sx9360: fix proximity threshold writes Arnav Kapoor
2026-11-16 20:53 ` [PATCH 6/6] iio: proximity: sx9360: reject negative hysteresis values Arnav Kapoor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116205320.26070-1-kapoorarnav43@gmail.com \
    --to=kapoorarnav43@gmail.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=gwendal@chromium.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®