From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=96.67.55.147 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794862902; b=uBffxDWSha5Gbofz1XnwG+Ng8nLfxCb1kFtYyAUqWwA2b+tdNBzKBnLTPyXOcPQuNIye RQCuo+LOckPkH1IUOuOk/mcca4OyS0q2uuHyhO2qQLjU23QUmfIsoP8GUXpHd8ECWqUlS TGg1MsXK3mIqwXQaUbUCO1reD0cSzngecQ+WEaqXql1gpypS3GWiv4HwK7Br6JTHh1Hzg Mtgo1InltErRNUqZ7qcqzBWkN3e/MThWalpgcZvgQ6VXjuB9e4+bZzReU8Na48fqnoRI/ 6oGoTUSzn/xOMVffpS8slN6pgGWOWiR5J9EIWQom13t0xX0cf+Au+WXX2/mLaDWaESw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794862902; h=DMARC-Filter:DKIM-Signature:Received:From:To:Cc:Subject:Date: Message-ID:X-Mailer:In-Reply-To:References:MIME-Version: Content-Transfer-Encoding; bh=SNg/eN30d+0BFvF9t/QYVmNoDb1lzvAqSarbFDg/MKE=; b=H2RIlK5zOQFOH+pdKwy5isHRnVaJStGDt/J2NYbRCezU2mozzPX7hHDS1oDLUnHZlbdr RUWuNmimeU5aBLqLuz0Upxh0HpRF8bywogqtnDRR8YFFE/jyeIw0K+R3vo4dfJ97sUShB cWrwQu26+nwUBKAQsh5hnFb7Iwtg0a+0lcUsxDvT6uSgVA3ZK3uh8YfzJLp+W4f7eZYdl uWz7UhIJ8Hzh83RG5fWz7w+bXe+TNtZlyZyf1scq+dkn2YOCvnWyQ45I1p9LaGNbn0i20 lVFU6KWa/u45wx0J/iHrx0q1lchNUj+7PnZCHZVTzY8LeUum5rPeX4I4b8cTLgPWzUQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=surriel.com; spf=pass smtp.mailfrom=surriel.com; dkim=pass header.d=surriel.com header.i=@surriel.com header.a=rsa-sha256 header.s=mail header.b=mrsaKYkX; arc=none smtp.remote-ip=96.67.55.147 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE083606A337 for ; Mon, 16 Nov 2026 21:01:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org BE083606A337 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=surriel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=surriel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=surriel.com header.i=@surriel.com header.a=rsa-sha256 header.s=mail header.b=mrsaKYkX DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=surriel.com ; s=mail; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID; bh=SNg/eN30d+0BFvF9t/QYVmNoDb1lzvAqSarbFDg/MKE=; b=mrsaKY kXv/n7TJSEdoqakNsKMv/0MMiRPOUVpqIP+KTWomcUu8LXPpJ8U1hHHun47Ojsy2/kxRXcnLFu8KE 2n5O+870QbnSlgq/MMWdesn2Y4dsstadJywXaUDpKhvoGBr20yaSSFtMrG8OalzLED+WBam1YITuy Whs0xpbWJxcZad5rcFHod9gb4b4OWaukwQyM+hFH7w4007Xs6a3YFBz36C0bR/zx0zsyKLcRMQu5i Dx9JaQIG9v0GKX3+btTOUIaoZlOD5+xjt7D02f+Yld9a7XtRvRGa3AftjnQJPVEvKnd1uiOKqaPM/ PD7h4lmtKL7Ak6ipj2m4hiNNyiqQ==; Received: from [2601:18c:8100:a0e0:5a47:caff:fe78:8708] (helo=fangorn.surriel.com) by shelob.surriel.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.5) (envelope-from ) id 1xT3pS-00000007LIv-1tGF; Mon, 16 Nov 2026 21:01:30 +0000 From: Rik van Riel To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, David Hildenbrand , Andrew Morton , Suren Baghdasaryan , Lorenzo Stoakes , Christoph Hellwig , Yuan-Hao Hsu , John Hubbard , Jason Gunthorpe , Peter Xu , Rik van Riel Subject: [PATCH v5 2/8] mm/gup: break out gup_flush_pages() helper Date: Mon, 16 Nov 2026 16:01:21 -0500 Message-ID: <20261116210127.3837898-3-riel@surriel.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261116210127.3837898-1-riel@surriel.com> References: <20261116210127.3837898-1-riel@surriel.com> X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit __get_user_pages() flushes each page's caches in an open-coded loop right after filling the array. Move it into a gup_flush_pages() helper. No functional changes intended. Suggested-by: David Hildenbrand Signed-off-by: Rik van Riel --- mm/gup.c | 27 +++++++++++++++++++-------- 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/mm/gup.c b/mm/gup.c index e0698d2075b4..d35fedbce7e1 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -729,6 +729,24 @@ static void gup_fill_pages(struct page **pages, struct page *page, pages[i] = page + i; } +/* + * Flush the caches for @nr_pages pages stored in @pages. The caller + * already holds folio references on the pages. + */ +static void gup_flush_pages(struct vm_area_struct *vma, unsigned long address, + struct page **pages, unsigned long nr_pages) +{ + unsigned long i; + + if (!pages) + return; + + for (i = 0; i < nr_pages; i++) { + flush_anon_page(vma, pages[i], address + i * PAGE_SIZE); + flush_dcache_page(pages[i]); + } +} + #ifdef CONFIG_PGTABLE_HAS_HUGE_LEAVES /* FOLL_FORCE can write to even unwritable PUDs in COW mappings. */ static inline bool can_follow_write_pud(pud_t pud, struct page *page, @@ -1566,9 +1584,6 @@ static long __get_user_pages(struct mm_struct *mm, page_increm = nr_pages; if (pages) { - struct page *subpage; - unsigned int j; - /* * This must be a large folio (and doesn't need to * be the whole folio; it can be part of it), do @@ -1599,11 +1614,7 @@ static long __get_user_pages(struct mm_struct *mm, } gup_fill_pages(pages + i, page, page_increm); - for (j = 0; j < page_increm; j++) { - subpage = page + j; - flush_anon_page(vma, subpage, start + j * PAGE_SIZE); - flush_dcache_page(subpage); - } + gup_flush_pages(vma, start, pages + i, page_increm); } i += page_increm; -- 2.56.0