From: Thaison Phan <thaisonphan@google.com>
To: "Chia-Yu Chang (Nokia)" <chia-yu.chang@nokia-bell-labs.com>
Cc: "Thaison Phan" <thaisonphan@google.com>,
"Eric Dumazet" <edumazet@kernel.org>,
"Neal Cardwell" <ncardwell@google.com>,
"Kuniyuki Iwashima" <kuniyu@google.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Ilpo Järvinen" <ij@kernel.org>,
"Olivier Tilmans (Nokia)" <olivier.tilmans@nokia.com>,
"Simon Horman" <horms@kernel.org>,
"Stan Iliev" <stani@google.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 2/2] tcp: accecn: initialize AccECN fields in syncookie path
Date: Mon, 16 Nov 2026 21:58:56 +0000 [thread overview]
Message-ID: <20261116215856.813379-1-thaisonphan@google.com> (raw)
In-Reply-To: <AS2PR07MB912321354BBBB27BEC882C11A37C2@AS2PR07MB9123.eurprd07.prod.outlook.com>
On Mon, Nov 16, 2026 at 02:16:40PM +0000, Chia-Yu Chang (Nokia) wrote:
> Thanks for the fix, the only change I propose is to clarify the above message into:
>
> "For AccECN connections where the listener marks ECT on the SYN-ACK, leaving
> syn_ect_snt as 0 causes tcp_accecn_third_ack() to see a mismatch between the
> expected Not-ECT and the peer's reflected ECT in the ACE field, erroneously
> flagging TCP_ACCECN_ACE_FAIL_RECV in accecn_fail_mode.
> Refer to Table 4 of RFC 9768 for more details."
>
> Because RFC3168 ECN does not use this syn_ect_snt.
Thanks for reviewing. That wording is clearer and more precise.
I sent out v2 [1] yesterday before seeing your note, so once the 24-hour
repost window passes I will send a v3 incorporating your clarification
(assuming v2 hasn't already been picked up by then).
[1] https://lore.kernel.org/netdev/20261116023709.132684-1-thaisonphan@google.com/
prev parent reply other threads:[~2026-11-16 21:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-14 16:12 [PATCH net 0/2] tcp: initialize missing request_sock " Thaison Phan
2026-11-14 16:12 ` [PATCH net 1/2] tcp: initialize ir_rmt_addr and ir_loc_addr in cookie_v6_check() Thaison Phan
2026-11-15 8:06 ` Eric Dumazet
2026-11-16 2:30 ` Thaison Phan
2026-11-14 16:12 ` [PATCH net 2/2] tcp: accecn: initialize AccECN fields in syncookie path Thaison Phan
2026-11-15 8:13 ` Eric Dumazet
2026-11-16 2:32 ` Thaison Phan
2026-11-16 14:16 ` Chia-Yu Chang (Nokia)
2026-11-16 21:58 ` Thaison Phan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116215856.813379-1-thaisonphan@google.com \
--to=thaisonphan@google.com \
--cc=chia-yu.chang@nokia-bell-labs.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=ij@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=olivier.tilmans@nokia.com \
--cc=pabeni@redhat.com \
--cc=stani@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®