From: Andreas Gruenbacher <agruenba@redhat.com>
To: William Chuang <founder@logarcheon.com>
Cc: Andreas Gruenbacher <agruenba@redhat.com>,
gfs2@lists.linux.dev, linux-kernel@vger.kernel.org,
syzbot+5a5f492ccae698fd7434@syzkaller.appspotmail.com,
stable@vger.kernel.org
Subject: [PATCH] gfs2: Fix NULL pointer dereference in gfs2_seek_data/gfs2_seek_hole
Date: Mon, 16 Nov 2026 23:08:43 +0100 [thread overview]
Message-ID: <20261116220843.378480-1-agruenba@redhat.com> (raw)
In-Reply-To: <20261116180002.44336-1-founder@logarcheon.com>
On Mon, Nov 16, 2026 at 7:01 PM William Chuang <founder@logarcheon.com> wrote:
> When the filesystem has been withdrawn, gfs2_glock_nq() returns -EIO
> without queuing the holder, and gfs2_glock_nq_init() then calls
> gfs2_holder_uninit(), which sets gh.gh_gl to NULL.
>
> gfs2_seek_data() and gfs2_seek_hole() call gfs2_glock_dq_uninit()
> unconditionally, so in that case gfs2_glock_dq() dereferences a NULL
> glock when it takes gl->gl_lockref.lock, causing a general protection
> fault.
>
> Only release the holder when it was successfully acquired, matching the
> pattern already used elsewhere in this file (such as gfs2_fiemap() and
> gfs2_getattr()).
>
> Fixes: 3a27411cb4bc ("gfs2: Implement SEEK_HOLE / SEEK_DATA via iomap")
> Reported-by: syzbot+5a5f492ccae698fd7434@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=5a5f492ccae698fd7434
> Cc: stable@vger.kernel.org
> Signed-off-by: William Chuang <founder@logarcheon.com>
Thanks.
Could you please replace this with the following fix and resend?
Andreas
--
gfs2_seek_data() and gfs2_seek_hole() call gfs2_glock_nq_init(), and
independent of the outcome, they call gfs2_glock_dq_uninit(). When the
gfs2_glock_nq() call in gfs2_glock_nq_init() fails, gfs2_glock_nq_init()
returns with an error code and gh.gh_gl is set NULL. This causes a NULL
pointer dereference in gfs2_glock_dq().
Fix that by only calling gfs2_glock_dq_uninit() when
gfs2_glock_nq_init() succeeds.
Fixes: 3a27411cb4bc ("gfs2: Implement SEEK_HOLE / SEEK_DATA via iomap")
Reported-by: syzbot+5a5f492ccae698fd7434@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=5a5f492ccae698fd7434
Cc: stable@vger.kernel.org
Signed-off-by: William Chuang <founder@logarcheon.com>
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index 2c2dc459c037..d4678e4832b3 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -2253,9 +2253,11 @@ loff_t gfs2_seek_data(struct file *file, loff_t offset)
inode_lock_shared(inode);
ret = gfs2_glock_nq_init(gl, LM_ST_SHARED, 0, &gh);
- if (!ret)
- ret = iomap_seek_data(inode, offset, &gfs2_iomap_ops);
+ if (ret)
+ goto out;
+ ret = iomap_seek_data(inode, offset, &gfs2_iomap_ops);
gfs2_glock_dq_uninit(&gh);
+out:
inode_unlock_shared(inode);
if (ret < 0)
@@ -2272,9 +2274,11 @@ loff_t gfs2_seek_hole(struct file *file, loff_t offset)
inode_lock_shared(inode);
ret = gfs2_glock_nq_init(gl, LM_ST_SHARED, 0, &gh);
- if (!ret)
- ret = iomap_seek_hole(inode, offset, &gfs2_iomap_ops);
+ if (ret)
+ goto out;
+ ret = iomap_seek_hole(inode, offset, &gfs2_iomap_ops);
gfs2_glock_dq_uninit(&gh);
+out:
inode_unlock_shared(inode);
if (ret < 0)
next prev parent reply other threads:[~2026-11-16 22:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 18:00 William Chuang
2026-11-16 22:08 ` Andreas Gruenbacher [this message]
[not found] <20261116175346.44221-1-founder@logarcheon.com>
2026-11-16 17:54 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116220843.378480-1-agruenba@redhat.com \
--to=agruenba@redhat.com \
--cc=founder@logarcheon.com \
--cc=gfs2@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+5a5f492ccae698fd7434@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®