mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kordian Chmielewski <kudzo51@gmail.com>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: netdev@vger.kernel.org, Doug Berger <opendmb@gmail.com>,
	Nicolai Buchwitz <nb@tipi-net.de>,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2 0/4] net: mdio: Clause 45 support for mdio-bcm-unimac
Date: Mon, 16 Nov 2026 23:38:13 +0100	[thread overview]
Message-ID: <20261116223813.980043-1-kudzo51@gmail.com> (raw)
In-Reply-To: <20261116213449.1682731-1-florian.fainelli@broadcom.com>

On Mon, 16 Nov 2026 13:34:45 -0800, Florian Fainelli wrote:
> This patch series adds support for Clause 45 MDIO operations within the
> mdio-bcm-unimac driver.

Tested v2 on the same TP-Link Archer AX6000 (BCM4908) with OpenWrt and
Linux 6.18.55, again in place of our own C45 support. Patch 1 needed the
context of one hunk adjusted to apply there, because OpenWrt carries a
hack patch that adds a function right after get_phy_c45_devs_in_pkg();
the added and removed lines are unchanged.

The BCM54991E at address 0x1d, which our out-of-tree PHY driver switches
to C45 in probe, still takes its firmware over C45 and links at 1000
Mbit/s, the link comes back after ethtool -r, and 8400 C45 reads through
SIOCGMIIREG gave no errors.

This bus is registered from DT, so the C45 scan does not run on it. For
patch 1, a test module registered a bus without DT whose reads go to the
UniMAC bus and whose writes fail, with read_c45 set and phy_mask leaving
only three empty addresses. On this UniMAC, a C22 or C45 read from an
empty address fails with -EIO. With v1, get_phy_device() for C45
returned -EIO there and mdiobus_register() failed with -EIO. With v2 it
returns -ENODEV, and the bus registers with no PHY found, as it does
with C22 alone.

The new check in unimac_mdio_reset() still never matches here, as no
node on this bus has the ethernet-phy-ieee802.3-c45 compatible; the
PHY's node has only its ID compatible.

Tested-by: Kordian Chmielewski <kudzo51@gmail.com>

      parent reply	other threads:[~2026-11-16 22:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 21:34 Florian Fainelli
2026-11-16 21:34 ` [PATCH net-next v2 1/4] net: phy: Map C45 probe read errors to -ENODEV during bus scan Florian Fainelli
2026-11-16 21:34 ` [PATCH net-next v2 2/4] net: mdio: mdio-bcm-unimac: Define MDIO_OP_SHIFT Florian Fainelli
2026-11-16 21:34 ` [PATCH net-next v2 3/4] net: mdio: mdio-bcm-unimac: Poll for completion at 1us granularity Florian Fainelli
2026-11-16 21:34 ` [PATCH net-next v2 4/4] net: mdio: mdio-bcm-unimac: Add Clause 45 support Florian Fainelli
2026-11-16 22:38 ` Kordian Chmielewski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261116223813.980043-1-kudzo51@gmail.com \
    --to=kudzo51@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=nb@tipi-net.de \
    --cc=netdev@vger.kernel.org \
    --cc=opendmb@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®