From: Florian Fainelli <florian.fainelli@broadcom.com>
To: bcm-kernel-feedback-list@broadcom.com,
Florian Fainelli <florian.fainelli@broadcom.com>,
linux-kernel@vger.kernel.org
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Damien Le Moal <dlemoal@kernel.org>,
Niklas Cassel <cassel@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Tejun Heo <tj@kernel.org>,
Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com>,
"open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)"
<linux-ide@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:BROADCOM IPROC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list:GENERIC PHY FRAMEWORK" <linux-phy@lists.infradead.org>
Subject: Re: [PATCH v4 5/6] ARM: dts: broadcom: Use noncoherent SATA DMA on BCM958625HR
Date: Mon, 16 Nov 2026 15:07:27 -0800 [thread overview]
Message-ID: <20261116230727.1490184-1-florian.fainelli@broadcom.com> (raw)
In-Reply-To: <20261029212513.4126083-6-florian.fainelli@broadcom.com>
From: Florian Fainelli <f.fainelli@gmail.com>
On Thu, 29 Oct 2026 14:25:12 -0700, Florian Fainelli <florian.fainelli@broadcom.com> wrote:
> The AHCI controller on BCM958625HR fails with the dma-coherent property
> inherited from bcm-nsp.dtsi. Soft reset times out waiting for the first
> FIS command, subsequent engine resets fail, and the disk is not detected.
>
> AHCI allocates its command tables and received-FIS buffers with the DMA
> API. Declaring the controller coherent bypasses the cache handling that
> these buffers require on this board. Removing the property restores
> hard disk detection and operation, as confirmed with a diagnostic DTB
> that changed only this property.
>
> Use noncoherent DMA for SATA on BCM958625HR, matching the downstream SDK.
>
> Fixes: 56e2ff0346a3 ("ARM: dts: NSP: Add dma-coherent to relevant DT entries")
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian
next prev parent reply other threads:[~2026-11-16 23:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 21:25 [PATCH v4 0/6] Fix SATA support for NSP SoCs Florian Fainelli
2026-10-29 21:25 ` [PATCH v4 1/6] phy: broadcom: brcm-sata: Keep NSP ports in the shared PCB window Florian Fainelli
2026-11-16 23:09 ` Florian Fainelli
2026-10-29 21:25 ` [PATCH v4 2/6] dt-bindings: ata: sata-brcm: Describe the NSP IDM registers Florian Fainelli
2026-11-04 10:47 ` Krzysztof Kozlowski
2026-10-29 21:25 ` [PATCH v4 3/6] ata: ahci_brcm: Initialize the NSP interface clock and reset Florian Fainelli
2026-10-29 21:25 ` [PATCH v4 4/6] ARM: dts: broadcom: Add the NSP SATA IDM registers Florian Fainelli
2026-11-16 23:07 ` Florian Fainelli
2026-10-29 21:25 ` [PATCH v4 5/6] ARM: dts: broadcom: Use noncoherent SATA DMA on BCM958625HR Florian Fainelli
2026-11-16 23:07 ` Florian Fainelli [this message]
2026-10-29 21:25 ` [PATCH v4 6/6] ARM: dts: broadcom: Enable SATA " Florian Fainelli
2026-11-16 23:07 ` Florian Fainelli
2026-11-02 16:52 ` [PATCH v4 0/6] Fix SATA support for NSP SoCs Niklas Cassel
2026-11-07 12:45 ` (subset) " Niklas Cassel
2026-11-09 19:54 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261116230727.1490184-1-florian.fainelli@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=cassel@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlemoal@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mani@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=tj@kernel.org \
--cc=vkoul@kernel.org \
--cc=yendapally.reddy@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®