From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794872825; b=OBsF/0Se+1iD0ZmaSi3odBV9dj2DcGAi8hBNjPsiC69rtDH6RFl5kBz8veQ9sT1/rGvg ZZ33EZXRiDc6Ne8Iu+ZYXviC64wi/Alr9XhLIV4kVzMKQny84P0KPU3HLPn7uzk9ZqZ7H hNwqzMXIG2gUskkFJ0mrefHIpR2Ywo9yw9qNgBGT2wKaYwHnarAASDnlO611ilECO/O4T OoAT8WoDNhCYHLq9C2UBg/9MYcv8O37gXiWMyWczWSeTjvTUhmrpotIgzY7PiGLW/G+EO bTaEqjTGugHKlkbpI6k7xdu5C2Omm1Q6PgvO+K7t2Zvp49p+ARhw0yHhjE3pb1dvOcg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794872825; h=Received:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Transfer-Encoding; bh=IfW/9ErRwtcHu20sOYq0cbtUPMtOYwHFB8qlDiv+HII=; b=rDyglbuyRcfgLupsuyhQE67NIZNoJfnSx479u1A0cV0Gz9wPH6e/VO/Kk1v7EgaYd52/ V1WpEf+WPGaEJ6xPgHP3/dB8+yeNoTXw7FH0C146hh1/iSU8OJDTJ/2PaW2F5WEFIdPko kflOhLe5/yub7wDNrgMSOJLMecBhRoupXjHEbCDZUd2VUX1mLnJStLZRnXn6o2RAireoo 2FeAPBUyENkiP7C+aDo9sVrAES5TONQXe/vabF31239z+3IkUXEaHJjq9zITnpJp50Ewa NC3SKYyWVbDqkkhe6NAXiqEypUc241BcBlMBPXkZGAJkdVyoY27/k4I+MYsEpdBpMNA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=nfKFqBOn; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89DA5606A31C; Mon, 16 Nov 2026 23:47:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=nfKFqBOn Received: by smtp.kernel.org (Postfix) with ESMTPSA id DE0681F000C4; Mon, 16 Nov 2026 23:47:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794872825; bh=IfW/9ErRwtcHu20sOYq0cbtUPMtOYwHFB8qlDiv+HII=; h=From:To:Cc:Subject:Date; b=nfKFqBOn+bjAxeANFyYQQP1zuSPWdhsH/GW0YCKD9SvkwdRsSBjW6FELONhTvX57G i/NU7IplNb4povih/XtwBCdnKOVb0nOBaMtUYQgd7GdYNowCgD+jGfnQmCAJo58AZ5 62eda0UVpjbXPGdUD4WVYy/fQSfeD/lH/KcUuFu0Z9lzrPGCHBXZrHPqKZmqUNFDIQ i2lxDQ8HE80afthXOKhuHS6e7pWjXPGsjVDl2MelJ8ZR968g5L50TxYp6ntq78wM5E SigR3ZR5IHexHxDRzijr2bbf440nzHYSae636xh1xu5cjkKZi+Gp2kpJgQXGCppZsg COU61u4LxuQAQ== From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Thomas Gleixner , James Clark , Jiri Olsa , Ian Rogers , Adrian Hunter , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo Subject: [PATCH v4 0/12] perf coverage: A harness for perf, and the fixes it found Date: Mon, 16 Nov 2026 20:46:46 -0300 Message-ID: <20261116234659.3950531-1-acme@kernel.org> X-Mailer: git-send-email 2.56.1 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arnaldo Carvalho de Melo Hi, Nothing measured how much of perf the test suite reaches. Patch 1 adds tools/perf/scripts/coverage.sh: it builds perf with clang source based coverage, runs the complete perf test suite and reports line and function coverage for the whole tree, optionally against a baseline, with --table and --html like pahole's coverage_table.py. Also as 'make -C tools/perf coverage', 'coverage-prep' and 'coverage-table'. The useful output is the list of files with the most uncovered lines, computed over the whole tree and not only the files the tests already touch: that is where new tests should try to get more coverage. The rest is what the first runs found, in the code, the build and the tests: - The data type resolver missed 32-bit absolute addressing (patch 2) and clang DWARF 5 DW_OP_addrx globals (patch 3); a struct pointer kept in a register at -O2 had no test (patch 6). - The flexible array member had no test; one showed the struct row at 0.00% while the member said 100.00% (patches 4-5). - --insn-stat was printed before the loop that accounts the samples, so --code-with-type showed zeros (patch 7). - The libbfd probe printed a missing bfd.h error five times per build-test run (patch 8). - FEATURE-DUMP didn't record llvm-perf and rust, disabling both in the build-test builds (patch 9). - The Intel PT virtual LBR check lost every aux sample with a single data page (patch 10). - The dlfilter test kept samples whose IP the kernel now zeroes on a userspace-to-kernel skid (patch 11). - The LBR inline unwinding check failed instead of reporting Skip when the AMD PMU rejects branch sampling (patch 12). In a root run on this box (coverage-prep as the developer, the tests as root; the machine has no Intel PT, so the PT tests skip) the suite covered 51.12% of perf's 205,007 lines. The only failure is the POLL_HUP tracepoint regression, in code this series does not change. The harness and the tests were developed with an AI coding assistant (OpenCode), which drafted the script and the tests and helped debug the failures; I reviewed every change and reproduced each failure before fixing it. What changed from v3: - Patch 1: a .profraw left half written used to make llvm-profdata drop the whole merge, and with it the run's measurement; the bad files are now skipped and counted (found running the harness on the arm64 boards). - Patch 2: only set mem_ref for bare number operands when the offset is non-zero, and guard find_data_type against reg1 == -1 (sashiko-bot). - Patch 3: move DW_OP_addrx fallback to dwarf-aux.h so annotate-data.c builds with older elfutils, and fix typo in Fixes SHA (sashiko-bot). - Patch 12: only "Invalid argument"/"not supported" skips (exit 2); stderr goes to a file, any other record failure prints it and fails. - Ian Rogers' Reviewed-by on v3 is carried on patches 4-6, 8 and 10-11; patches 1 and 12 changed after that review and need a new look. What changed from v2: - Patch 2 is new: absolute addressing is resolved, so the new data type tests pass on 32-bit non-PIE builds and skip on 32-bit PIE. - Patches 3, 4 and 6: the C programs became 'perf test -w' workloads (global_data, flex_array, regptr), the shell tests no longer compile anything (Ian Rogers). - Patch 6: regptr uses long long members, so the offsets are the same on ILP32 and LP64. - Patch 5: add the missing annotated_member__extent() stub, so a build with slang but without libdw works (sashiko-bot); it is now a method of struct annotated_member. What changed from v1: - Patch 9 (cs-etm) is gone: Leo Yan's series replaces it. - Patch 1: O= is accepted by all targets, the Python extension is in the report, -f is normalized and the delta matches its baseline. - Patch 5: the TUI browser counts flexible array accesses too. - Patch 7: the stats test skips without libdw. - Patches 10 and 12: Fixes tags corrected. Best regards, - Arnaldo Arnaldo Carvalho de Melo (12): perf scripts: Add a coverage harness for perf perf annotate: Handle absolute addressing in data type profiling perf annotate-data: Resolve DW_OP_addrx global variables perf tests: Exercise the flexible array member path perf annotate-data: Count flexible array accesses for the whole struct perf tests: Exercise data type resolution from a register perf annotate: Print the stats after the annotations perf tests: Silence the libbfd probe in build-test perf build: Record the display-only features in FEATURE-DUMP perf tests: Fix the Intel PT virtual LBR check perf test: Drop samples without an IP in the dlfilter test perf test: Skip the LBR inline unwinding check when unsupported tools/perf/.gitignore | 1 + tools/perf/Makefile | 11 +- tools/perf/Makefile.config | 4 + tools/perf/Makefile.perf | 4 + tools/perf/builtin-annotate.c | 10 +- tools/perf/scripts/coverage.sh | 738 +++++++++++++++++++++++++ tools/perf/tests/builtin-test.c | 3 + tools/perf/tests/make | 2 +- tools/perf/tests/shell/addr2line_inlines.sh | 23 +- tools/perf/tests/shell/annotate_stats.sh | 64 +++ tools/perf/tests/shell/data_type_flex_array.sh | 108 ++++ tools/perf/tests/shell/data_type_global.sh | 70 +++ tools/perf/tests/shell/data_type_register.sh | 64 +++ tools/perf/tests/shell/script_dlfilter.sh | 2 +- tools/perf/tests/shell/test_intel_pt.sh | 9 +- tools/perf/tests/tests.h | 3 + tools/perf/tests/workloads/Build | 6 + tools/perf/tests/workloads/flex_array.c | 54 ++ tools/perf/tests/workloads/global_data.c | 55 ++ tools/perf/tests/workloads/regptr.c | 60 ++ tools/perf/ui/browsers/annotate-data.c | 7 +- tools/perf/util/annotate-arch/annotate-x86.c | 45 +- tools/perf/util/annotate-data.c | 28 +- tools/perf/util/annotate-data.h | 8 + tools/perf/util/annotate.c | 23 +- tools/perf/util/annotate.h | 6 + tools/perf/util/dwarf-aux.c | 37 +- tools/perf/util/dwarf-aux.h | 5 + 28 files changed, 1421 insertions(+), 29 deletions(-) create mode 100755 tools/perf/scripts/coverage.sh create mode 100755 tools/perf/tests/shell/annotate_stats.sh create mode 100755 tools/perf/tests/shell/data_type_flex_array.sh create mode 100755 tools/perf/tests/shell/data_type_global.sh create mode 100755 tools/perf/tests/shell/data_type_register.sh create mode 100644 tools/perf/tests/workloads/flex_array.c create mode 100644 tools/perf/tests/workloads/global_data.c create mode 100644 tools/perf/tests/workloads/regptr.c base-commit: cc905a18a647a8e3ad42cd1596baa0e08fba26eb v1-head: 3f5465bea8f5a97a v2-head: 9706c488afffeb6d v3-head: f2daf1586528671a v4-head: b9e240a1b80ecd2a -- 2.56.0