From: Sudeep Holla <sudeep.holla@kernel.org>
To: Cristian Marussi <cristian.marussi@arm.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org,
philip.radford@arm.com, Sudeep Holla <sudeep.holla@kernel.org>,
Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH 2/2] firmware: arm_scmi: Fix SCMI Power Control driver removal
Date: Tue, 17 Nov 2026 14:09:54 +0000 [thread overview]
Message-ID: <20261117-flat-nonchalant-dragon-a2dcb8@sudeepholla> (raw)
In-Reply-To: <avw8CvBXXWNx4YGX@pluto>
On Tue, Nov 17, 2026 at 11:35:38AM +0000, Cristian Marussi wrote:
> On Mon, Nov 16, 2026 at 06:14:50PM +0000, Sudeep Holla wrote:
> > On Mon, Nov 16, 2026 at 08:42:11AM +0000, Cristian Marussi wrote:
[...]
> >
> > Just wondering if it is better to stop receiving notifications from firmware
> > first and then cancel any pending work ? Basically reverse order of probe
> > for remove.
> >
>
> I think the order is irrelevant given the dead_srcu gating, BUT indeed I
> kept this order so as to keep the undo in reverse order: in fact the
> probe at first issues some INIT_WORK, but the real schedule_work happens
> only later after a notif is received, so the order is:
>
> - init_srcu
> - static WORK init
> - register SCMI notif callback
> - RX notify msg
> - register reboot notifier
> - schedule delayed work
>
> Also, even if the notifiers are inhibited by dead_srcu, I felt better to
> cancel that work as soon as possible.
>
> Thoughts ?
>
All valid points, with that I am OK to leave it as is. I was mainly thinking
of avoiding any further notifications when the device is being removed. So
doing that as early as possible would avoid handling of any late notifications
from the SCMI firmware.
--
Regards,
Sudeep
prev parent reply other threads:[~2026-11-17 14:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 8:42 [PATCH 0/2] SCMI Power Control fixes Cristian Marussi
2026-11-16 8:42 ` [PATCH 1/2] firmware: arm_scmi: Fix deadlock between reboot notifier and forceful work Cristian Marussi
2026-11-16 18:25 ` Sudeep Holla
2026-11-17 11:25 ` Cristian Marussi
2026-11-17 14:06 ` Sudeep Holla
2026-11-16 8:42 ` [PATCH 2/2] firmware: arm_scmi: Fix SCMI Power Control driver removal Cristian Marussi
2026-11-16 18:14 ` Sudeep Holla
2026-11-17 11:35 ` Cristian Marussi
2026-11-17 14:09 ` Sudeep Holla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117-flat-nonchalant-dragon-a2dcb8@sudeepholla \
--to=sudeep.holla@kernel.org \
--cc=arm-scmi@vger.kernel.org \
--cc=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philip.radford@arm.com \
--cc=sashiko-bot@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®