From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=91.218.175.12 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794925433; b=ZmIJejlvM0pNkYVPK08PADdUsC6kjfS1o9opshqLaiBoTZ/JXUNcABgeRt5oGnYlBHnO DsnrdPe0GpCnHMw2S2+2pGwBMvBMaAIWaUuWYFe2+hhA1atyDE1pibTBAnYE+I/DmwJzU y7wSy6EEFuMWxIHAR7ENQJqJBWnBR6D1777RGF0tDtpc+eRVgvKiTjX9uQGsZ5MVj1lE+ qmNDkLx9FIHLr6zHAqDrDtuVPvw5Tr02broPmayQ5X16GQCXXEvJqrexmMSMbT1ue8u5j EVrE9G93M6VBk3VOKNxNPf9BoevO77TSU9XQDSpnI0X+x8C5G2QIMfp/PZ4vI7D46Gg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794925433; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=+guh6iE7xYHMDxDlAuP+z2BJ/SuqIHLRli0tfKpcKSA=; b=VQiQ8Dr0DCieizl3KMemA7jXb0zTHw1UQ0DZc/JbyzMRpSBwoHk0ZmFxKlawzmNDKPZ9 USljB9aMkUGxV+luiQn//72AMhZWD3O+JAAYapBhmtMFZ+g0sqvutpi+xeSPq70qKDPTr agXcbeiHu+Se6/mLgEzx8/GykgGpc84/MFdWsow/n9Jf3D83pZST7CbszhjM3spMD0rUA MIzWh+Bt/9AmzG3AUYY7AlQY/DeD6Jy9LCOhRbz87xI6VFUQBFBy7ll808iW8vN9zNQXm tRsvKVkpHOQSVN/hVgihFFXuJuhcmI5xjU+XTyD26EhFl+E2eEBrVjBUVmwGyX2+FkQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=n8EjsBSG; arc=none smtp.remote-ip=91.218.175.12 Received: from mta0.migadu.com (out-12.mta0.migadu.com [91.218.175.12]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2A81606A337 for ; Tue, 17 Nov 2026 14:23:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org E2A81606A337 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=n8EjsBSG X-Envelope-To: linux-kernel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=vVEQh/xrnvg3iNH7ktwVr6B+e0axcBBg8VcjYROWAzs=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794925431; v=1; x=1795530231; b=n8EjsBSG+Ee9ykzmSLTJnG/Cibj9X7WjI++nFAR8yngKRKtOUu4zPtZ9VUsIDASylbFGOavJ rijtRk+aSB2JzY4FQj48ufPfHyh8k3PlppMcvn+eIEh11MHpRQok1gVO0kWoiHyxS/RN/ZWSTaq EkFxlUv8TIAqaNTBxkwL46XM= X-Envelope-To: linux-kernel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 08b26d05a708a200; Tue, 17 Nov 2026 14:23:50 +0000 X-Mizu-Trace-ID: 08b26d05a708a200 X-Migadu-Flow: FLOW_OUT Date: Tue, 17 Nov 2026 14:23:46 +0000 From: "Jose Fernandez (Anthropic)" To: Zhang Yi , Theodore Ts'o Cc: Jan Kara , Baokun Li , Ojaswin Mujoo , Andreas Dilger , "Ritesh Harjani (IBM)" , guolingxing , Josef Bacik , Chris Mason , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, regressions@lists.linux.dev Subject: Re: [REGRESSION] ext4: silent data loss when a split at I/O completion gets ENOSPC Message-ID: <20261117-jf-ext4-enospc-reply-zhangyi-v9-b19eeb966ad0@linux.dev> References: X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Nov 17, 2026 Zhang Yi wrote: > I think the solution should be based on Ojaswin's counting approach in > [1] or the PENDING_CONVERSION solution we discussed, and then, after > extent splitting fails, try to flush the journal and retry. Thanks for the quick POC. Our agents ran it on [1] rebased on 23c62304dde2 with the report's reproducer, in two separate setups (QEMU without KVM). None of 72 files lost data in either, against 42 and 53 of 72 with [1] alone. They found two gaps: - The new branch in ext4_ext_handle_unwritten_extents() skips both ext4_update_inode_fsync_trans() calls, so fdatasync() and O_DSYNC can return before the commit. On a full filesystem mounted with commit=3600, a shutdown test lost the write in all 13 buffered fdatasync() and O_DSYNC cases that reach the zeroout. They pass with [1] alone and with that call added. - Direct writes into preallocated files can still get ENOSPC with the POC, on a few percent of files in both setups, with no data lost. The POC tries the zeroout before the commit and retry. Should it be the other way around? And will you take guolingxing's patch ([2] in my report) as well? - Jose