From: Edward Srouji <edwards@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>, Jason Gunthorpe <jgg@ziepe.ca>,
"Sabrina Dubroca" <sd@queasysnail.net>
Cc: <linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, Edward Srouji <edwards@nvidia.com>,
"Akiva Goldberger" <agoldberger@nvidia.com>,
Michael Gur <michaelgur@nvidia.com>
Subject: [PATCH rdma-next 10/11] RDMA/mlx5: Resolve the bfreg UAR-index core device from the ucontext
Date: Tue, 17 Nov 2026 16:01:21 +0200 [thread overview]
Message-ID: <20261117-mlx5-sd-prep-v1-10-8efd124c7895@nvidia.com> (raw)
In-Reply-To: <20261117-mlx5-sd-prep-v1-0-8efd124c7895@nvidia.com>
From: Akiva Goldberger <agoldberger@nvidia.com>
bfregn_to_uar_index() and its get_uars_per_sys_page() helper took an
mlx5_ib_dev only to reach dev->mdev. A bfreg is allocated on the owning
ucontext's core device, so take a struct mlx5_core_dev and have the QP and
DEVX callers resolve it from the ucontext via uctx_to_mdev().
No functional change.
Signed-off-by: Akiva Goldberger <agoldberger@nvidia.com>
Reviewed-by: Michael Gur <michaelgur@nvidia.com>
Signed-off-by: Edward Srouji <edwards@nvidia.com>
---
drivers/infiniband/hw/mlx5/devx.c | 5 ++--
drivers/infiniband/hw/mlx5/main.c | 5 ++--
drivers/infiniband/hw/mlx5/mlx5_ib.h | 7 +++---
drivers/infiniband/hw/mlx5/qp.c | 49 ++++++++++++++++++++----------------
4 files changed, 36 insertions(+), 30 deletions(-)
diff --git a/drivers/infiniband/hw/mlx5/devx.c b/drivers/infiniband/hw/mlx5/devx.c
index d0b1876f9e8afc6de57f7db1631327bb7c9b91ba..c0314288c2a4f86bf9f7d3f2f314574c73d3bc63 100644
--- a/drivers/infiniband/hw/mlx5/devx.c
+++ b/drivers/infiniband/hw/mlx5/devx.c
@@ -1076,20 +1076,19 @@ static int UVERBS_HANDLER(MLX5_IB_METHOD_DEVX_QUERY_UAR)(
struct uverbs_attr_bundle *attrs)
{
struct mlx5_ib_ucontext *c;
- struct mlx5_ib_dev *dev;
u32 user_idx;
s32 dev_idx;
c = devx_ufile2uctx(attrs);
if (IS_ERR(c))
return PTR_ERR(c);
- dev = to_dev(c->ibucontext.device);
if (uverbs_copy_from(&user_idx, attrs,
MLX5_IB_ATTR_DEVX_QUERY_UAR_USER_IDX))
return -EFAULT;
- dev_idx = bfregn_to_uar_index(dev, &c->bfregi, user_idx, true);
+ dev_idx = bfregn_to_uar_index(uctx_to_mdev(c), &c->bfregi, user_idx,
+ true);
if (dev_idx < 0)
return dev_idx;
diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
index 0d9ef66765c6894b76067593420dab0350d9847c..50d0762db3d5a7007e6b44507fe56964b469d65b 100644
--- a/drivers/infiniband/hw/mlx5/main.c
+++ b/drivers/infiniband/hw/mlx5/main.c
@@ -1916,7 +1916,7 @@ static int calc_total_bfregs(struct mlx5_ib_dev *dev, bool lib_uar_4k,
if (req->total_num_bfregs > MLX5_MAX_BFREGS)
return -ENOMEM;
- uars_per_sys_page = get_uars_per_sys_page(dev, lib_uar_4k);
+ uars_per_sys_page = get_uars_per_sys_page(dev->mdev, lib_uar_4k);
bfregs_per_sys_page = uars_per_sys_page * MLX5_NON_FP_BFREGS_PER_UAR;
/* This holds the required static allocation asked by the user */
req->total_num_bfregs = ALIGN(req->total_num_bfregs, bfregs_per_sys_page);
@@ -2630,7 +2630,8 @@ static int uar_mmap(struct mlx5_ib_dev *dev, enum mlx5_ib_mmap_cmd cmd,
if (dyn_uar) {
int uars_per_page;
- uars_per_page = get_uars_per_sys_page(dev, bfregi->lib_uar_4k);
+ uars_per_page = get_uars_per_sys_page(dev->mdev,
+ bfregi->lib_uar_4k);
bfreg_dyn_idx = idx * (uars_per_page * MLX5_NON_FP_BFREGS_PER_UAR);
if (bfreg_dyn_idx >= bfregi->total_num_bfregs) {
mlx5_ib_warn(dev, "invalid bfreg_dyn_idx %u, max=%u\n",
diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h b/drivers/infiniband/hw/mlx5/mlx5_ib.h
index 61c663c7bfc9cf20b3b40dbb8aa4f621fe1d8ea8..b77a8eab6b9e672beafe55162b3cb75cdeb910c7 100644
--- a/drivers/infiniband/hw/mlx5/mlx5_ib.h
+++ b/drivers/infiniband/hw/mlx5/mlx5_ib.h
@@ -1648,15 +1648,16 @@ static inline int get_srq_user_index(struct mlx5_ib_ucontext *ucontext,
return verify_assign_uidx(cqe_version, ucmd->uidx, user_index);
}
-static inline int get_uars_per_sys_page(struct mlx5_ib_dev *dev, bool lib_support)
+static inline int get_uars_per_sys_page(struct mlx5_core_dev *mdev,
+ bool lib_support)
{
- return lib_support && MLX5_CAP_GEN(dev->mdev, uar_4k) ?
+ return lib_support && MLX5_CAP_GEN(mdev, uar_4k) ?
MLX5_UARS_IN_PAGE : 1;
}
extern void *xlt_emergency_page;
-int bfregn_to_uar_index(struct mlx5_ib_dev *dev,
+int bfregn_to_uar_index(struct mlx5_core_dev *mdev,
struct mlx5_bfreg_info *bfregi, u32 bfregn,
bool dyn_bfreg);
diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
index 01babb9a0003abe2520200fcec2e9eb9224516e7..98bceae575724ca7a25936a1b1094f5801ffbcae 100644
--- a/drivers/infiniband/hw/mlx5/qp.c
+++ b/drivers/infiniband/hw/mlx5/qp.c
@@ -715,40 +715,43 @@ enum {
NUM_NON_BLUE_FLAME_BFREGS = 1,
};
-static int max_bfregs(struct mlx5_ib_dev *dev, struct mlx5_bfreg_info *bfregi)
+static int max_bfregs(struct mlx5_core_dev *mdev,
+ struct mlx5_bfreg_info *bfregi)
{
- return get_uars_per_sys_page(dev, bfregi->lib_uar_4k) *
+ return get_uars_per_sys_page(mdev, bfregi->lib_uar_4k) *
bfregi->num_static_sys_pages * MLX5_NON_FP_BFREGS_PER_UAR;
}
-static int num_med_bfreg(struct mlx5_ib_dev *dev,
+static int num_med_bfreg(struct mlx5_core_dev *mdev,
struct mlx5_bfreg_info *bfregi)
{
- return max(0, max_bfregs(dev, bfregi) - bfregi->num_low_latency_bfregs -
+ return max(0, max_bfregs(mdev, bfregi) -
+ bfregi->num_low_latency_bfregs -
NUM_NON_BLUE_FLAME_BFREGS);
}
-static int first_med_bfreg(struct mlx5_ib_dev *dev,
+static int first_med_bfreg(struct mlx5_core_dev *mdev,
struct mlx5_bfreg_info *bfregi)
{
- return num_med_bfreg(dev, bfregi) ? 1 : -ENOMEM;
+ return num_med_bfreg(mdev, bfregi) ? 1 : -ENOMEM;
}
-static int first_hi_bfreg(struct mlx5_ib_dev *dev,
+static int first_hi_bfreg(struct mlx5_core_dev *mdev,
struct mlx5_bfreg_info *bfregi)
{
int med;
- med = num_med_bfreg(dev, bfregi);
+ med = num_med_bfreg(mdev, bfregi);
return ++med;
}
-static int alloc_high_class_bfreg(struct mlx5_ib_dev *dev,
+static int alloc_high_class_bfreg(struct mlx5_core_dev *mdev,
struct mlx5_bfreg_info *bfregi)
{
int i;
- for (i = first_hi_bfreg(dev, bfregi); i < max_bfregs(dev, bfregi); i++) {
+ for (i = first_hi_bfreg(mdev, bfregi); i < max_bfregs(mdev, bfregi);
+ i++) {
if (!bfregi->count[i]) {
bfregi->count[i]++;
return i;
@@ -758,16 +761,16 @@ static int alloc_high_class_bfreg(struct mlx5_ib_dev *dev,
return -ENOMEM;
}
-static int alloc_med_class_bfreg(struct mlx5_ib_dev *dev,
+static int alloc_med_class_bfreg(struct mlx5_core_dev *mdev,
struct mlx5_bfreg_info *bfregi)
{
- int minidx = first_med_bfreg(dev, bfregi);
+ int minidx = first_med_bfreg(mdev, bfregi);
int i;
if (minidx < 0)
return minidx;
- for (i = minidx; i < first_hi_bfreg(dev, bfregi); i++) {
+ for (i = minidx; i < first_hi_bfreg(mdev, bfregi); i++) {
if (bfregi->count[i] < bfregi->count[minidx])
minidx = i;
if (!bfregi->count[minidx])
@@ -778,7 +781,7 @@ static int alloc_med_class_bfreg(struct mlx5_ib_dev *dev,
return minidx;
}
-static int alloc_bfreg(struct mlx5_ib_dev *dev,
+static int alloc_bfreg(struct mlx5_core_dev *mdev,
struct mlx5_bfreg_info *bfregi)
{
int bfregn = -ENOMEM;
@@ -788,9 +791,9 @@ static int alloc_bfreg(struct mlx5_ib_dev *dev,
mutex_lock(&bfregi->lock);
if (bfregi->ver >= 2) {
- bfregn = alloc_high_class_bfreg(dev, bfregi);
+ bfregn = alloc_high_class_bfreg(mdev, bfregi);
if (bfregn < 0)
- bfregn = alloc_med_class_bfreg(dev, bfregi);
+ bfregn = alloc_med_class_bfreg(mdev, bfregi);
}
if (bfregn < 0) {
@@ -846,7 +849,7 @@ static void mlx5_ib_lock_cqs(struct mlx5_ib_cq *send_cq,
static void mlx5_ib_unlock_cqs(struct mlx5_ib_cq *send_cq,
struct mlx5_ib_cq *recv_cq);
-int bfregn_to_uar_index(struct mlx5_ib_dev *dev,
+int bfregn_to_uar_index(struct mlx5_core_dev *mdev,
struct mlx5_bfreg_info *bfregi, u32 bfregn,
bool dyn_bfreg)
{
@@ -857,7 +860,7 @@ int bfregn_to_uar_index(struct mlx5_ib_dev *dev,
if (bfregi->lib_uar_dyn)
return -EINVAL;
- bfregs_per_sys_page = get_uars_per_sys_page(dev, bfregi->lib_uar_4k) *
+ bfregs_per_sys_page = get_uars_per_sys_page(mdev, bfregi->lib_uar_4k) *
MLX5_NON_FP_BFREGS_PER_UAR;
index_of_sys_page = bfregn / bfregs_per_sys_page;
@@ -869,7 +872,7 @@ int bfregn_to_uar_index(struct mlx5_ib_dev *dev,
if (bfregn > bfregi->num_dyn_bfregs ||
bfregi->sys_pages[index_of_sys_page] == MLX5_IB_INVALID_UAR_INDEX) {
- mlx5_ib_dbg(dev, "Invalid dynamic uar index\n");
+ dev_dbg(mdev->device, "Invalid dynamic uar index\n");
return -EINVAL;
}
}
@@ -994,7 +997,8 @@ static int _create_user_qp(struct mlx5_ib_dev *dev, struct ib_pd *pd,
bfregn = MLX5_IB_INVALID_BFREG;
break;
case MLX5_QP_FLAG_BFREG_INDEX:
- uar_index = bfregn_to_uar_index(dev, &context->bfregi,
+ uar_index = bfregn_to_uar_index(uctx_to_mdev(context),
+ &context->bfregi,
ucmd->bfreg_index, true);
if (uar_index < 0)
return uar_index;
@@ -1003,7 +1007,7 @@ static int _create_user_qp(struct mlx5_ib_dev *dev, struct ib_pd *pd,
case 0:
if (qp->flags & IB_QP_CREATE_CROSS_CHANNEL)
return -EINVAL;
- bfregn = alloc_bfreg(dev, &context->bfregi);
+ bfregn = alloc_bfreg(uctx_to_mdev(context), &context->bfregi);
if (bfregn < 0)
return bfregn;
break;
@@ -1013,7 +1017,8 @@ static int _create_user_qp(struct mlx5_ib_dev *dev, struct ib_pd *pd,
mlx5_ib_dbg(dev, "bfregn 0x%x, uar_index 0x%x\n", bfregn, uar_index);
if (bfregn != MLX5_IB_INVALID_BFREG)
- uar_index = bfregn_to_uar_index(dev, &context->bfregi, bfregn,
+ uar_index = bfregn_to_uar_index(uctx_to_mdev(context),
+ &context->bfregi, bfregn,
false);
qp->rq.offset = 0;
--
2.49.0
next prev parent reply other threads:[~2026-11-17 14:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 14:01 [PATCH rdma-next 00/11] RDMA/mlx5: Preparation for SD support Edward Srouji
2026-11-17 14:01 ` [PATCH rdma-next 01/11] RDMA/mlx5: Enforce dev/mdev naming for device pointers Edward Srouji
2026-11-17 14:01 ` [PATCH rdma-next 02/11] RDMA/mlx5: Rename to_mdev() helpers that return an IB device Edward Srouji
2026-11-17 14:01 ` [PATCH rdma-next 03/11] RDMA/mlx5: Select the PD and SRQ core device through the PD Edward Srouji
2026-11-17 14:01 ` [PATCH rdma-next 04/11] RDMA/mlx5: Select the core device through PD for QP commands Edward Srouji
2026-11-17 14:01 ` [PATCH rdma-next 05/11] RDMA/mlx5: Cache the MR core device and resolve the MW's via its PD Edward Srouji
2026-11-17 14:01 ` [PATCH rdma-next 06/11] RDMA/mlx5: Select the AH core device through their PD Edward Srouji
2026-11-17 14:01 ` [PATCH rdma-next 07/11] RDMA/mlx5: Select the QP core device through its PD Edward Srouji
2026-11-17 14:01 ` [PATCH rdma-next 08/11] RDMA/mlx5: Resolve core device from ucontext for DEVX resources Edward Srouji
2026-11-17 14:01 ` [PATCH rdma-next 09/11] RDMA/mlx5: Cache the CQ core device and resolve it via cq_to_mdev() Edward Srouji
2026-11-17 14:01 ` Edward Srouji [this message]
2026-11-17 14:01 ` [PATCH rdma-next 11/11] RDMA/mlx5: Resolve UAR and mmap core devices via the ucontext Edward Srouji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261117-mlx5-sd-prep-v1-10-8efd124c7895@nvidia.com \
--to=edwards@nvidia.com \
--cc=agoldberger@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=michaelgur@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®